Received-SPF: pass (google.com: domain of linux-kernel+bounces-91956-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Niklas Cassel <Niklas.Cassel@wdc.com>
To: Frank Li <Frank.Li@nxp.com>
CC: "bhelgaas@google.com" <bhelgaas@google.com>,
	"gustavo.pimentel@synopsys.com" <gustavo.pimentel@synopsys.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>, "jdmason@kudzu.us"
	<jdmason@kudzu.us>, "jingoohan1@gmail.com" <jingoohan1@gmail.com>,
	"kw@linux.com" <kw@linux.com>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "linux-pci@vger.kernel.org"
	<linux-pci@vger.kernel.org>, "lpieralisi@kernel.org" <lpieralisi@kernel.org>,
	"mani@kernel.org" <mani@kernel.org>, "robh@kernel.org" <robh@kernel.org>
Subject: Re: [PATCH v2 1/1] PCI: dwc: Fix index 0 incorrectly being
 interpreted as a free ATU slot
Thread-Topic: [PATCH v2 1/1] PCI: dwc: Fix index 0 incorrectly being
 interpreted as a free ATU slot
Thread-Index: AQHaboXQLML6t2DiAku/eXc/Po9wGLEo26AA
Date: Tue, 5 Mar 2024 09:05:59 +0000
Message-ID: <ZebgdpKt7x2hDivM@fedora>
References: <20240304224616.1238966-1-Frank.Li@nxp.com>
In-Reply-To: <20240304224616.1238966-1-Frank.Li@nxp.com>
Accept-Language: en-US
Content-Language: en-US
wdcipoutbound: EOP-TRUE
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?ew+vcVImqH9fByCLeW16mrCzToVWfAs5sPxuT6RjNLZ11R8Ac7OWerrbjxy+?=
 =?us-ascii?Q?OcZJxRCsCCAbWtjtdPdWtglxkNG4GoS3VLlEcd5eYfsQ81fBDawTZAsZlVol?=
 =?us-ascii?Q?8LvOAxWkVlvV2pOlCVrfaj73JCscGbj7HdXvzHqmr4WrmYbDUEUCXRdmZolJ?=
 =?us-ascii?Q?DyUP8+XNf5Jc7vFA0/0rnjT2CLR3v2SgZnzJe6KqMMTwKguJZEfhRFreXfNl?=
 =?us-ascii?Q?KsNRwDR3pck4cnRRtAvODcvjCr5tuOaxes66bBJsa0sRz2K6VBPees5/O7Po?=
 =?us-ascii?Q?SRvCGbwLx+3jTKtEqyVWUr+wBRiTiwxN3jylJskPiNlvFnlm8HABJ1vdN9JY?=
 =?us-ascii?Q?aoav2v1jKwsgQ0X6llFQS8qv6GU2Hb5HDbWDA2WGYba15a9kc/iuCaWbvJix?=
 =?us-ascii?Q?NwjjtPphQ1BiVnkitnCkmvLXquDhOPlHPIy8ceOo08o4Os24H0DkfEC3i+yr?=
 =?us-ascii?Q?rqbE+FYHEYY2DEQSRlNEzrHhNzHGC4HVYl/9pO/RQoKWxhiebU8pLuZMQwHL?=
 =?us-ascii?Q?Iei8/I8KQ4xbZaQ0OxH0wAOzGID726q4rwXM/Jki81GpjG2oVpQyepKtbXlr?=
 =?us-ascii?Q?OFPJHogl9coiLCJAISh1WppQp0KqOt4ertob9PhJwClwDWhVoxe085kKgz5L?=
 =?us-ascii?Q?C/oJik3QUnoD+NS+8mUqXBng++eoAl/Ga401Q/Ea8HwTOwk4r6hrLWrYK1nM?=
 =?us-ascii?Q?oTBSJbkQjbppQgzVFqWaBsDgRXtCbJjw5xWWby73+xhOd4AH08rz7GjHAq+h?=
 =?us-ascii?Q?y1wiHrNZ5WX1UJMtjn4PR3W42h1uCdzsmrRZK40+SXvs98+Q+gVbpCP+NURW?=
 =?us-ascii?Q?0PvCJ9pXhDM6h9tzIndym5oZkNcTCRQZ8LE7ZCJCwFB6uybHaGFRJL+YSk7n?=
 =?us-ascii?Q?8xD9FS7ciaIBOaVzCVdRuBkn9sV+sxmyf7X+vg8NOD17MR0SaJrBCQF6ZJ0T?=
 =?us-ascii?Q?fcSbymhb+hw3i4c9ragCCFRgTw9vzf4ge0U9PaxNJOqHBCPGtEWBCQ4R/OGV?=
 =?us-ascii?Q?FvehQNlDoFHwGQIrko3oculdQl2d/J2KoZHd6vTkJAgoSx0DRRs0iaCeJkTL?=
 =?us-ascii?Q?dZwlMorlpniv2v4Khlk1JUXsh9EdaZg9+o2zpGWewTQnxGXaXE41YUcxkXWl?=
 =?us-ascii?Q?B/GHk/OFuk6VkNDIIQjgy/JBEYDM2Odza+2wrH4jdFx6ar9e28DSNNqsadQC?=
 =?us-ascii?Q?Xk/n3zeUwXqp84ItLjFHxNjup6xBGrkqpRyF0Cm5J7Vs+VHlouTwmSMisobJ?=
 =?us-ascii?Q?Jjm7i5L8gqeyQx3cX8GycvWFWZPQIJYlYeZbVBL45yl76g9kQJTncESGMcHK?=
 =?us-ascii?Q?1/Or6OUMD5I7lIZrk4jx+WREl3LBCMoFOstbmwSwNloNxBQuvJcZCbbhxecl?=
 =?us-ascii?Q?awtHEHm2vvbhs3A1fnuUtWBi43Xd4cQvFWlDHa8939nP9CytZtTgfKMGJtDe?=
 =?us-ascii?Q?caOE62+BaLsEmkV9JXIM9UyyVxme+jRRYF7CfPGdklCItaF9iswlDdvzugPp?=
 =?us-ascii?Q?cZcsOJs5OzKyOKLanU3C6/EsyRkRXiVpYfT9brb1jv15lFGiSesX43zDQMeC?=
 =?us-ascii?Q?O989Sp9VArUQqBIr2V0/5+Djjxt9KT2VQvG/WkUEHpgWBV+gsUhj68mES5oE?=
 =?us-ascii?Q?4A=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-ID: <BE3CC955A5F43A45BDA49CB7755821C8@namprd04.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0:
	+hj82A5VwY8z1sJxXDv5GFroRZRcw2U+eNMF73G2Pb5UysfzHf+96rUpidD/u6YFFkcfSX76mppTMTrDD2H3f5d/folbEsYdLocM7KNAmYzHQp1LJBiGyIHqN+TjdgRcMWBYyjWLJjXSqoV8ggH6hnq8vjHDKvDpXZDKJqz06sBKdKhtH2su2rgKsfIBfmO1f6zPIuiuPtUIz0i+hrjVCA3rDWzLjMEIEEaoRiy5UsOmlqDjV12nbMejhwMrR+hbZe5isXPK22rs0+6e8FVkmJZ3dIRp1wcFpi5YnbTtEfWaZIA4fRPenaB4xJXBwKPBoBkU1k9SIfhCxQZ6Yc1z5cm2Nez+oCK2CMn3Jzfg/wjxeYTANpW86kQNkFJwX9VdIgVn5L5uFfANcrjmZ2NdNQHf19CrMk7uHzSTbrIRj9JWzQJNT1V6Io9Y7TpgWLhAL5SOouDO8BS4aX7iQK6zZ7jTDZPVk2qbPJynZKu55/HXTcLKwsT5tO/LN3iGq4wzXAysnDADIzduk+tqadYHEN+kLEJRrBrwXc2sT50kr/+kaYNwioQCNVBrpnKNj1vmP76beOBy/YfrKn6WblcfvPKs4EYaDTARovqFvqP4s3rsL7C54JIZvZ7bucRbE+ah
X-OriginatorOrg: wdc.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ0PR04MB8326.namprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f348b054-2e7b-4546-9558-08dc3cf37988
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 09:05:59.2925
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: b61c8803-16f3-4c35-9b17-6f65f441df86
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: K/KycHTtgrJmreLFtG2dCEJB+BTc+QOJjlakE+z5FYm4hWZw0+ArVw6kDvZ9OeeFi4ALiMOzn7slSxjCG9cejA==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA1PR04MB8468

On Mon, Mar 04, 2024 at 05:46:16PM -0500, Frank Li wrote:
> dw_pcie_ep_inbound_atu()
> {
> 	...
> 	if (!ep->bar_to_atu[bar])
> 		free_win =3D find_first_zero_bit(ep->ib_window_map, pci->num_ib_windows=
);
> 	else
> 		free_win =3D ep->bar_to_atu[bar];
> 	...
> }
>=20
> The atu index 0 is valid case for atu number. The find_first_zero_bit()
> will return 6 when second time call into this function if atu is 0. Suppo=
se
> it should use branch 'free_win =3D ep->bar_to_atu[bar]'.
>=20
> Change 'bar_to_atu' to free_win + 1. Initialize bar_to_atu as 0 to indica=
te
> it have not allocate atu to the bar.
>=20
> Reported-by: Niklas Cassel <Niklas.Cassel@wdc.com>
> Closes: https://lore.kernel.org/linux-pci/ZXt2A+Fusfz3luQV@x1-carbon/T/#u
> Fixes: 4284c88fff0e ("PCI: designware-ep: Allow pci_epc_set_bar() update =
inbound map address")
> Reviewed-by: Niklas Cassel <niklas.cassel@wdc.com>
> Signed-off-by: Frank Li <Frank.Li@nxp.com>

Tested-by: Niklas Cassel <niklas.cassel@wdc.com>=