Received-SPF: pass (google.com: domain of linux-kernel+bounces-91982-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 5 Mar 2024 09:15:28 +0000
From: Sean Young <sean@mess.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@kernel.org>
Subject: Re: [PATCH v1 1/1] media: ir-spi: Remove unused of_gpio.h
Message-ID: <ZebisPvr_eFPm_0o@gofer.mess.org>
References: <20240304180331.1200827-1-andriy.shevchenko@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240304180331.1200827-1-andriy.shevchenko@linux.intel.com>

On Mon, Mar 04, 2024 at 08:03:31PM +0200, Andy Shevchenko wrote:
> of_gpio.h is deprecated and subject to remove.
> The driver doesn't use it, simply remove the unused header.
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/rc/ir-spi.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/media/rc/ir-spi.c b/drivers/media/rc/ir-spi.c
> index bbc81bed4f90..8afc3cd70b87 100644
> --- a/drivers/media/rc/ir-spi.c
> +++ b/drivers/media/rc/ir-spi.c
> @@ -8,7 +8,6 @@
>  #include <linux/fs.h>
>  #include <linux/module.h>
>  #include <linux/mutex.h>
> -#include <linux/of_gpio.h>

This does not build, I get errors saying of_property_read_bool() is undefined.
I think we need linux/of.h instead of linux/of_gpio.h.


Sean

>  #include <linux/regulator/consumer.h>
>  #include <linux/spi/spi.h>
>  #include <media/rc-core.h>
> -- 
> 2.43.0.rc1.1.gbec44491f096