Received-SPF: pass (google.com: domain of linux-kernel+bounces-91983-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240228185116.1269-1-vamshigajjela@google.com> <ZeA7dVBmm1yuf6F9@hovoldconsulting.com>
In-Reply-To: <ZeA7dVBmm1yuf6F9@hovoldconsulting.com>
From: VAMSHI GAJJELA <vamshigajjela@google.com>
Date: Tue, 5 Mar 2024 14:46:01 +0530
Message-ID: <CAMTSyjq6rOSeZND4iRdg_ooLf6P8rpx7oU5+tfCGjN1JVHhesg@mail.gmail.com>
Subject: Re: [PATCH] spmi: hisi-spmi-controller: Do not override device identifier
To: Johan Hovold <johan@kernel.org>
Cc: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>, Stephen Boyd <sboyd@kernel.org>, 
	Johan Hovold <johan+linaro@kernel.org>, Caleb Connolly <caleb.connolly@linaro.org>, 
	linux-kernel@vger.kernel.org, stable@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 29, 2024 at 1:38=E2=80=AFPM Johan Hovold <johan@kernel.org> wro=
te:
>
> On Thu, Feb 29, 2024 at 12:21:16AM +0530, Vamshi Gajjela wrote:
> > 'nr' member of struct spmi_controller, which serves as an identifier
> > for the controller/bus. This value is a dynamic ID assigned in
> > spmi_controller_alloc, and overriding it from the driver results in an
> > ida_free error "ida_free called for id=3Dxx which is not allocated".
> >
> > Signed-off-by: Vamshi Gajjela <vamshigajjela@google.com>
> > Fixes: 70f59c90c819 ("staging: spmi: add Hikey 970 SPMI controller driv=
er")
> > Cc: stable@vger.kernel.org
> > ---
>
> This is v2, which should be indicated in the patch subject and with a
> short changelog here (e.g. mentioning the split and rebase on 6.8-rc).
ack, Thanks
>
> Johan