Received-SPF: pass (google.com: domain of linux-kernel+bounces-91990-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 05 Mar 2024 04:20:54 -0500
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Breno Leitao <leitao@debian.org>, 
 kuba@kernel.org, 
 davem@davemloft.net, 
 pabeni@redhat.com, 
 edumazet@google.com, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, 
 Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 horms@kernel.org, 
 dsahern@kernel.org
Message-ID: <65e6e3f62c314_3cfad29462@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240304183810.1474883-1-leitao@debian.org>
References: <20240304183810.1474883-1-leitao@debian.org>
Subject: Re: [PATCH net-next 1/2] net: tuntap: Leverage core stats allocator
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Breno Leitao wrote:
> With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and
> convert veth & vrf"), stats allocation could be done on net core
> instead of in this driver.
> 
> With this new approach, the driver doesn't have to bother with error
> handling (allocation failure checking, making sure free happens in the
> right spot, etc). This is core responsibility now.
> 
> Remove the allocation in the tun/tap driver and leverage the network
> core allocation instead.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Willem de Bruijn <willemb@google.com>