Received-SPF: pass (google.com: domain of linux-kernel+bounces-91991-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 05 Mar 2024 04:21:10 -0500
From: Willem de Bruijn <willemdebruijn.kernel@gmail.com>
To: Breno Leitao <leitao@debian.org>, 
 kuba@kernel.org, 
 davem@davemloft.net, 
 pabeni@redhat.com, 
 edumazet@google.com, 
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, 
 Jason Wang <jasowang@redhat.com>
Cc: netdev@vger.kernel.org, 
 linux-kernel@vger.kernel.org, 
 horms@kernel.org, 
 dsahern@kernel.org
Message-ID: <65e6e40618790_3cfad29492@willemb.c.googlers.com.notmuch>
In-Reply-To: <20240304183810.1474883-2-leitao@debian.org>
References: <20240304183810.1474883-1-leitao@debian.org>
 <20240304183810.1474883-2-leitao@debian.org>
Subject: Re: [PATCH net-next 2/2] net: tap: Remove generic .ndo_get_stats64
Precedence: bulk
Mime-Version: 1.0
Content-Type: text/plain;
 charset=utf-8
Content-Transfer-Encoding: 7bit

Breno Leitao wrote:
> Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is
> configured") moved the callback to dev_get_tstats64() to net core, so,
> unless the driver is doing some custom stats collection, it does not
> need to set .ndo_get_stats64.
> 
> Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it
> doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64
> function pointer.
> 
> Signed-off-by: Breno Leitao <leitao@debian.org>

Reviewed-by: Willem de Bruijn <willemb@google.com>