Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp287998lqs; Tue, 5 Mar 2024 01:53:32 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVjKuRic1B1rugMKfl8KbcjKRgPbEvxOa37S720PSSRPq1cSMO3NK8Aaf1qT17jbhvFGbgbj/A2YdMYdFvjUO39/VL3UDE+4Ih5cJuFXg== X-Google-Smtp-Source: AGHT+IFXV76EqXIS5i2sGvfxdiPx3PlUYVa+6jXS7ED7hHqGBoMOpWZ7c5iWWMpAU15QncpwQhnO X-Received: by 2002:a17:902:bb8d:b0:1dd:26b0:2685 with SMTP id m13-20020a170902bb8d00b001dd26b02685mr1068016pls.66.1709632412230; Tue, 05 Mar 2024 01:53:32 -0800 (PST) Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id d4-20020a170902654400b001dccc775680si9555325pln.56.2024.03.05.01.53.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 01:53:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92032-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@kernel.org header.s=k20201202 header.b="oF9+D/O4"; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-92032-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92032-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id E3D52282851 for ; Tue, 5 Mar 2024 09:53:31 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id AD70354772; Tue, 5 Mar 2024 09:53:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="oF9+D/O4" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D17E653387; Tue, 5 Mar 2024 09:53:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709632397; cv=none; b=e2tOVXm+hq8VUd2F28drlQqA36yPxhK7YwbgKRe1sci1sZyyDorJ3xZwGHhDMxQoNv1556zBJISLo2JTQbkHY4E/XCyaKsM79d50RpzeVOhYi4A/m2XF7bCaukcI3tPudGpZXPZ55k5Zq9AMw7+OTNe0aC8EI9ePSPJ8X0JVQ4Q= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709632397; c=relaxed/simple; bh=PZNtxETNBMvwgRvNajtlng5m/Fskjy/Sopf4o4P6IvA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=OW+7WXGKfUzhO1v02SrMrQE7La6d6Dcrf2gMx0CkxU1pInMs/AArr+oNfJB3KKwHK61SKNxfmqAzmiTB2SyRMf1wWvgW/zUftIei/8vqRd+yoDYMC/m6x7WRS3b+/U1sInYCn1yC88doavZm+cuUcET6faaNbo3qELZeh00DVlk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=oF9+D/O4; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id E4817C433F1; Tue, 5 Mar 2024 09:53:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709632397; bh=PZNtxETNBMvwgRvNajtlng5m/Fskjy/Sopf4o4P6IvA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=oF9+D/O4L8XlTVRDRjDyp84tWeSb4IdLktYVkVK46OBtmMYkTCxzWDaqF7We/jSkf 3JPFGEHV96Vt8UOdVTKaousir12DzaHU+1U6HAWcpoCO5apQ7PRI8bm6wAAesYHu9S PppNoY1mhxcSlbEV8OAsS4z63HP0MC+vvZDdfv+JenQoTEzoMs0OedWErkLB+2QBY5 Z6akL1FDwaUiG/fZxxP3nSWazkSpjrGLdSC3LlCq8NpYUyBsqzMyQSxx1hVXRE1u50 IzFG+hLWHjDrrU5og5zECV2P8RlJo4t2Ql8BiV52B5WLLzc7l2nlXjBPttJFmQlTMT 1P/CYP/YVOFFA== Date: Tue, 5 Mar 2024 10:53:13 +0100 From: Andi Shyti To: Jesper Nilsson Cc: Krzysztof Kozlowski , Alim Akhtar , Naveen Krishna Ch , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org, kernel@axis.com Subject: Re: [PATCH v2] i2c: exynos5: Init data before registering interrupt handler Message-ID: References: <20240304-i2c_exynos5-v2-1-7b9c312be719@axis.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240304-i2c_exynos5-v2-1-7b9c312be719@axis.com> Hi Jesper, I have taken your patch in my testing branch, but... > + /* Clear pending interrupts from u-boot or misc causes */ > + exynos5_i2c_clr_pend_irq(i2c); > + > + i2c->irq = ret = platform_get_irq(pdev, 0); .. I get this checkpatch note: CHECK: multiple assignments should be avoided #60: FILE: drivers/i2c/busses/i2c-exynos5.c:932: + i2c->irq = ret = platform_get_irq(pdev, 0); You are still in time to fix it, or you can fix it later or you can leave it as for me it's not a big deal. But, please, next time, make sure to run checkpatch before sending a patch. Thanks, Andi