Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp317353lqs; Tue, 5 Mar 2024 03:02:34 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXuQlLo/pw92lbwqmmnFnt/lIDXzcX8ti43yx5GNoNDRnh5+FkReULtaTl6W3p3MX/B4zqx+rkX7dsygaeaBTeLDR1gmRC/Tf+5BxJH6A== X-Google-Smtp-Source: AGHT+IFZjUeZALYXOlf1GqkQ+DhRlso4SwCyBzcpavSYB3WLk18MSV+71gr2z+ldB6YNkqFoILWS X-Received: by 2002:a05:6358:5e08:b0:17b:f051:85b1 with SMTP id q8-20020a0563585e0800b0017bf05185b1mr1173535rwn.3.1709636554414; Tue, 05 Mar 2024 03:02:34 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709636554; cv=pass; d=google.com; s=arc-20160816; b=tiTEFeXjQB+wdde1trq+4uBgo7E8x+o15StJRvzKu4PGSq5rwheoML7RLtIAeNzN/M LlN3nrAh/ONZxM/IkAAOALLnTSrjnoKXCZEH+DOEaIuEbIisvdLYRu+9QcZ0XZTJnGbk 91WhoDyJEVTYuFaXNn1R4KGGc64g1Hi5zJata6KWhwgiSvdkkofVJZnaXMoIU9vNTKVj Lj6HRi8nbcxgWMXJLd2bucQknvKvS4KEYIzezJNWaLxcIWiU5iCrY6dCwz8AlRGl6hYz 0lMN8kmK/Wag6rtd3zUM4SZqN9h0BYwSr3MkFmjn/xQHjpjOI3iTui+qw0i1Bm/Fn1sA aJKQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=xPuHQcklJTcuhcQurcuZovTdWGwzKidbYfnoix/AruM=; fh=U19BMt/qfQxjz5yZ+bgJYtEkpRO757sNVr1y4kux6Qk=; b=kJ4VKSqKULGUXphoHop5pk6vXlr6wKHVJdctoHXhulAJADOEMinYGYoikg/X8XALYj QWTD99+nAK0OsLiqtER1eqVpZAI/5Nc2lmWUmMzQDtHSkFYbkzXdDZlfexLEQO9DI41w keIxqIerNfh+h0x22j8TDpWDWPkDGBmjfSaMA+vXIcuV2Low+HZE9S/OeFJRX5C5oGyF bCbz/WTQP/B35gQzt58PcHOeRzaYPmrcTout3u6Zn0r/AW6huGMJyzX46f1bpbluKwx6 qCn6bXxeydkcPF30stH5Lh+/asJ+d76X8Yry6WrQKxv9akqcwPYGYbZxCPhTaRzJl5D6 5gbQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=kTX1GA0l; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-92201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92201-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id v41-20020a05622a18a900b0042ed5977267si8399229qtc.655.2024.03.05.03.02.34 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 03:02:34 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@sang-engineering.com header.s=k1 header.b=kTX1GA0l; arc=pass (i=1 spf=pass spfdomain=sang-engineering.com dkim=pass dkdomain=sang-engineering.com); spf=pass (google.com: domain of linux-kernel+bounces-92201-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92201-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 270441C21FD3 for ; Tue, 5 Mar 2024 11:02:34 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D96D05B687; Tue, 5 Mar 2024 10:58:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b="kTX1GA0l" Received: from mail.zeus03.de (www.zeus03.de [194.117.254.33]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C14F35A7B4 for ; Tue, 5 Mar 2024 10:58:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=194.117.254.33 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709636311; cv=none; b=POUdoA3EfFJA863y8X4PmdvXd1zT2EL+2S9MiKALZsJadCXEyj6rvf4+JzXAksFZ+Gfi7ht0xoe4P6pQEtqYjh/xNiQzJIRyv0LAO3DxtrCsGJXQPTb+wO82k67BVgzyq4dc0fmpoakE24nsYkw/l6Oe+/VZMdszbfzb8cUToJA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709636311; c=relaxed/simple; bh=f7Q8xEnTZun4xlenz0nLn7ZHUaKzak+LPVyCMOJnHYA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=UKnJK3QDi67CtxDEJWdmgNwJzibX3BUSDfvuCqa7vVbNqn27wnu/4n865whj1R5d2cObynveT+h/54HiyHOf8D5nQ1OE/u/eK4jf5a7cq6K1mfnBwK7oc/MwGPgR1XSvsmaGcEopF+GXEB1DymRxfFAbRRp+knw5s2xbwtDpG20= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com; spf=pass smtp.mailfrom=sang-engineering.com; dkim=pass (2048-bit key) header.d=sang-engineering.com header.i=@sang-engineering.com header.b=kTX1GA0l; arc=none smtp.client-ip=194.117.254.33 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=sang-engineering.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=sang-engineering.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= sang-engineering.com; h=date:from:to:cc:subject:message-id :references:mime-version:content-type:in-reply-to; s=k1; bh=xPuH QcklJTcuhcQurcuZovTdWGwzKidbYfnoix/AruM=; b=kTX1GA0lnCujzRpEw9OQ rUf8RLNGxnHfeTnxvRugGMgNOHiuBlIMSoyIcfHESYVtpvetbi7d2kSRIoubybVl vmF6zkwqGXm3vv3jDA2XwzD3WugrtvRESyfFil06+f6z3sTRWlz+C7+AUa4Odqzy X/CjAf+dIG6GgylR8zoh+xDwECD0VIQPtlFhI1G3PCPfl1/M5Kia+ifxw2fcjUgf pBUc+qauGd0+LWQIjKJxIhE3gql6pht/u/k4MJCuJKBPVDFr57k2ZZwqTKEpILgH STpj6uOPHbWzAEMIDjlOHJ/RZo0UthXHFDFQ8Z0oDVMYgAUuGnnOScmFZUBlmGlI lA== Received: (qmail 3848895 invoked from network); 5 Mar 2024 11:58:26 +0100 Received: by mail.zeus03.de with ESMTPSA (TLS_AES_256_GCM_SHA384 encrypted, authenticated); 5 Mar 2024 11:58:26 +0100 X-UD-Smtp-Session: l3s3148p1@rMW/uOcS3K0gAwDPXyskAOYD60938Lkb Date: Tue, 5 Mar 2024 11:58:26 +0100 From: Wolfram Sang To: linux-renesas-soc@vger.kernel.org Cc: Dirk Behme , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] mmc: tmio: comment the ERR_PTR usage in this driver Message-ID: Mail-Followup-To: Wolfram Sang , linux-renesas-soc@vger.kernel.org, Dirk Behme , Ulf Hansson , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org References: <20240305105623.3379-2-wsa+renesas@sang-engineering.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="I+w6onKpvUCg+xgS" Content-Disposition: inline In-Reply-To: <20240305105623.3379-2-wsa+renesas@sang-engineering.com> --I+w6onKpvUCg+xgS Content-Type: text/plain; charset=us-ascii Content-Disposition: inline > + /* Ready for new mrqs */ > + host->mrq = NULL; > host->clk_cache = ios->clock; For the record: I think these two statements should be swapped. First set the new value, then allow new mrqs. However, I want to test this change internally before submitting it. --I+w6onKpvUCg+xgS Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCgAdFiEEOZGx6rniZ1Gk92RdFA3kzBSgKbYFAmXm+s4ACgkQFA3kzBSg KbY4LxAArWrACN31Hi0404iyhszQZuB/3l564QxUJ2iBDOPZ5LA9U5jwKum+FLSa wuuT+47FsXuSvCl0AAghHLO6J6iqoX7uiUkBwA5RB9/CJDEN/PpZ58iJJl2H/9/0 cZpS9hkSJSx4Rlf8QKgIn9ACD+CzYMXvW+H1dJdKsrl4Zfs45OKMZtyyE9FPLQN0 1zRj/hdFsPJXbGmz6rSJSBKShevsG51gdfpuj/5a5ckt7uGuJ0YSWjhMJXZFSBsQ FtBBwncclxs4sl+iZG1iM4UopSCMce8wqDQN51ccNVNCYlcDWRlV+CWkIJxMnh3l 63DpxdcMsUFgojcBVGyMKZ3nSfYTIbe7I1mSAYSL7cVm0fQKznruwC0F5lxYR7uk NdjoSUpFcVAG8lO3DZz9SZIy6v09S0NmWwvA9GSTCNrwaUFZ+fx4ZI8BMABcUdMD Y7pQ/gLHQW1O4G0D3Uds4HaEmHprA47wcg/JaguFyxgT55LRIhib7KbrlEgH6vdw GwIS3cvemQuVo3Fi0yeDIr6hbU8YEX+Ulmr8WcqZR7h02suF6BxstCLUviDqt+e1 gyasU3CCcjMBgrlR8v69Ci1u9JeUREMD+hE0qzNxiqGlX9VVuwNry5W5+Qr0IBGK aTnT7wgY5dz3SEl3IYsE4+Q93AA46/FUVxGu0t8E9r1jKmZR6kA= =LaVY -----END PGP SIGNATURE----- --I+w6onKpvUCg+xgS--