Received-SPF: pass (google.com: domain of linux-kernel+bounces-92278-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <3fb62749-8c66-47ae-9b8b-7e670ebf4841@oracle.com>
Date: Tue, 5 Mar 2024 11:29:11 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v5 2/7] scsi: libsas: Define NCQ Priority sysfs attributes
 for SATA devices
Content-Language: en-US
To: Igor Pylypiv <ipylypiv@google.com>, Damien Le Moal <dlemoal@kernel.org>,
        Niklas Cassel <cassel@kernel.org>, Jason Yan <yanaijie@huawei.com>,
        "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        Jack Wang <jinpu.wang@cloud.ionos.com>, Hannes Reinecke <hare@suse.de>,
        Xiang Chen <chenxiang66@hisilicon.com>,
        Artur Paszkiewicz <artur.paszkiewicz@intel.com>,
        Bart Van Assche <bvanassche@acm.org>
Cc: TJ Adams <tadamsjr@google.com>, linux-ide@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240305005103.1849325-1-ipylypiv@google.com>
 <20240305005103.1849325-3-ipylypiv@google.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <20240305005103.1849325-3-ipylypiv@google.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?d2Z3Z3dVZjZOdVVVaHFUZUxDTUUra01uamYwbkU5UUNZelJIU0xKVlNTMHlJ?=
 =?utf-8?B?M3M4TDJYaXVsK2FVU1Npd29hWmtNRTQ0L1l0YXlrcTUwTVJNbDlSd3dlRHhC?=
 =?utf-8?B?bWJ2RHlyd0t4MjBhU0VpZUFJNHV2SmdKZ3FxcnF1MTlFWGZQaXMxc3YvR2FB?=
 =?utf-8?B?STVWcXU2ZW1UeStzT0doeHpVVkdUcUdOV1RFSmlTSDJkS3hZRlNmVmpSM0hP?=
 =?utf-8?B?THJaM0psNDN6UUM1SHIwWU1uZlRTaTQvQVljbEdLN2ZDNTNLa24rWUZpQS8x?=
 =?utf-8?B?dUYzcExTVjJZbjkyam1xNktqb0JyTmNEcDBqZmI1V1FiTEVzWEVpendnQUNm?=
 =?utf-8?B?eURIV2RvdVpSS0FoMjFFWkNNR1pWWmpoTm41bG1IWUFXRTEzeFdEdG1iNWo3?=
 =?utf-8?B?cnF5cHBOV3gxeldSODlvNWRKeDhBWnZnYXRwTTJuWUc3RGxCYUVLR2RSS1lC?=
 =?utf-8?B?aUFrb0dyTDlvVXJURlJQZXBYM1RwRGszNUhmV2VFaU93MUh0VjZtMS9yVDdS?=
 =?utf-8?B?bDBjbXFQU2RoTklpclMzcWtQakNoNHJVUVRBeUlJcGo0dFBSRGxOYXN1VVEz?=
 =?utf-8?B?SC9xM2RiZkNWeTFaRnNBcGNIWjVyUUd2RUhsVFRsQWRXK0h4V3RVN01uN0R4?=
 =?utf-8?B?VitaWkVNblN0R0NwMHc2ZVpkbzJNdDNKZEFQWlIrQjNiUEhQckFOZlE5b0dn?=
 =?utf-8?B?OFVKNG92aEppMWtNbGFVTUtEcnI2emM2a0JhUUFkSFc1Yk9sZ1A3Wi90VGhl?=
 =?utf-8?B?Z1l4U2NyMXFOYllCRDF2Z3VIM2M3dURVYUl0aWtodHVybERLTVdhbDYwaWlr?=
 =?utf-8?B?bHUwTDA2UG1ZZGZjRUE0MVY2ZDNWNkV1MXJPK2d5b1Z2Y2dKbzZBcGRvYUFW?=
 =?utf-8?B?WmxnVjR1RmdrNEE0bDlDNDVXT1U1OU4wUHRIWGROTy8ySzNHTnplWnozNWZo?=
 =?utf-8?B?amFxTlR1c09tM3RhT1d6T09SdHFraXNUVlBsdnFqK2FKVW9Pc2tlUUxwM3hI?=
 =?utf-8?B?eDlrREE5dmxkY1A5S0F3alRKRklpTGs1YmkxdkVFQXVHSERZdXlFTWh1TUJO?=
 =?utf-8?B?aDM3clRTS05ra3NKcWxTcXFYMzdncUNQN3hqZS8zVFQ5VTNKYm1Nc0FIRHAz?=
 =?utf-8?B?TGU5WXA2d242ekxDZkpQRVkvM2RCK1pJckliMmwyLzBoK0lOaFE0TVlnWEtM?=
 =?utf-8?B?MExaalVZM2cyRHNQTXdFbWt5ZFg0MFRwdEZjbXp0L2NpRnA5NnhOVnRYNlds?=
 =?utf-8?B?emo2d1U2eDNJM29uVHJJSkFnb1Vac2IyazBSSWdMdmhDL04yY0RQOW16WHZ6?=
 =?utf-8?B?NG5PT1JBdnlrbUFWMkpJc0VoUDdJY2t3NVFXMkNsZkt5UzI2N1ZQRmJJKzly?=
 =?utf-8?B?bGVXSmgyZ09pTkZ6ZU9oNzNJc1ZpejRSZ1YvTnZ2ZldUWGZqeHFaSDcraE9J?=
 =?utf-8?B?VXo4QzFIcnFXWWJDNTBmekkxREovNFBPbXhTc3VGYXlqNFF2b0l3TmhIb3Ur?=
 =?utf-8?B?MXV4TlpDVS84djNiK0xtR1AxNGlsT2RldzNCZ2xhckNSaWN3TzNvYzVHalVl?=
 =?utf-8?B?Q0ZEWlorMnhOcTZ1VmZJZTlzaFlKbTVFVTVabFpkdXJWdlZuRFJNcFhKcTFk?=
 =?utf-8?B?OTdmQ3o1RlBGNllmQ2VoWVFRYS8wZHFBVUJIUEpiN0gxMjdEbjNCNVRISkgz?=
 =?utf-8?B?VzNmQWVaTGdlZWs0MmxXcVIxeml1cjJ6NGl6OVdhdWxONnE4Y2lRWDNCQjhw?=
 =?utf-8?B?MVN2VjltRXZYUDkrM1F5WmMxc2REMkIzYVk4ZkhjdVRlYWRvbE12UFkzUVFG?=
 =?utf-8?B?aktUNi9nTC9VYnY4NVZBNDdWa1IyV2hoWFBzc1B6ZlpkZFd0V2xQR09NZ0hP?=
 =?utf-8?B?cEdEZC9NU3VpQzEyelhpYWMrb2V2bkU4Ulc5dEZoREdUUXMzalZIZk1UYUpx?=
 =?utf-8?B?cVdiekNObXpqRjZrbi9WRzNydVQybTJ1djFUajhOL2ZsZWJ1SERaN3IvdWFy?=
 =?utf-8?B?OE8zRy8wR2QwL0MxaDFFQ1BRM3RtQ1NwVUNCMlNzTFZlMVdDRE5zQ2c0djcr?=
 =?utf-8?B?d1VxRVBYc0xJeW1adElqMmNSckhOQXE1Z0gwYllhaC8zR3VoYVg2cVdHWE5p?=
 =?utf-8?B?UUV1OXBPVk5aTjFMbWhoWVY4emxWam16cFJMSjVSMHJja2NBazdQYUowYU9H?=
 =?utf-8?B?UEE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	9unOMZ30a7u1H629fNs8bBK5KeOXYycog5QF7NmK3bBGqPOKQX0Uj4YaTb9w6VipC32o9bASXpXFwAhFNvn6FCAnIbAm010xOSmjXRvzZ6hzfXvku69YuA/rFGfjXnMdt11D9E2myyVneNFyzmC4AcAitVE7iRtOev5JzuCdCNs8NWXNLpZuychdok5+MI9iMuXcBBZTZBDKP+SXsibqp6+u/hJfX6T1W2I8nizk9BACAB6yoaQyAsu+MBkjqXQIJqLPdRSK0hopiblUISxw8l3bIPgTObmMD00RqozewOfkIyyoD3CFXuzGwtYtMCNRb6ARk9XkL/4IenRDeyvx7wtQFWLjjUkZGysUmKw3KQA8ROAfBXE5GvznSoHDZg5sEfEo27Z3+DQTioqK/gks/4Irfm2eFt/V1Nmw7eWAWXk+0wCs11vJmRnEHBfCW+nJziDJmsDhpVZdWti4rQpDyORY7+0GRl7G+74bX9VNzHkr103Buej4STJkxS7qOVzk9WiIXMQw6m3wCXHTQkW485Y7sTKBe06dkHZGy8U8zWRqoJuebFfHnm4/Ibgp7iAa3ZdkzsfoN1csPrxd9HKXXId6bWeJWrvBXc0lezGgsjU=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 16e04042-6f32-4abf-5301-08dc3d077d9e
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 11:29:16.3537
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uIsbmX4YT2b6qQKxKa7WkiqIgNxxhF4NTHdXh/xjLZTFSKlhpilfX/Lm9QOXDRoDGsr/9b6I4vEpGYb/vfa+Ng==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR10MB6284
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-05_08,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxlogscore=999 bulkscore=0 mlxscore=0
 spamscore=0 phishscore=0 suspectscore=0 malwarescore=0 adultscore=0
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2403050092
X-Proofpoint-ORIG-GUID: hKAvgLIEZUfjbVfNG8Mrgn1i41fp43gC
X-Proofpoint-GUID: hKAvgLIEZUfjbVfNG8Mrgn1i41fp43gC

On 05/03/2024 00:50, Igor Pylypiv wrote:
>   
>   static inline void sas_ata_disabled_notice(void)
> @@ -123,6 +125,10 @@ static inline int sas_ata_add_dev(struct domain_device *parent, struct ex_phy *p
>   	sas_ata_disabled_notice();
>   	return -ENODEV;
>   }
> +
> +static const struct attribute_group sas_ata_sdev_attr_group = {
> +	.attrs = NULL,
> +};

I just noticed a build issue.

With CONFIG_SCSI_SAS_ATA not set, I get this for W=1 build:

In file included from drivers/scsi/hisi_sas/hisi_sas.h:29,
                 from drivers/scsi/hisi_sas/hisi_sas_v1_hw.c:7:
/include/scsi/sas_ata.h:129:37: error: ‘sas_ata_sdev_attr_group’
defined but not used [-Werror=unused-const-variable=]
  129 | static const struct attribute_group sas_ata_sdev_attr_group = {

I suppose that marking sas_ata_sdev_attr_group as __maybe_unused is ok, 
but less than ideal. The linker should strip it out of files when unused.

I think that this is also ok:

#define sas_ata_sdev_attr_group (struct attribute_group) {}

The compiler here will create a empty structure and have 
&sas_ata_sdev_attr_group point at it.

Thanks,
John