Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754763AbYADXoS (ORCPT ); Fri, 4 Jan 2008 18:44:18 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753073AbYADXoI (ORCPT ); Fri, 4 Jan 2008 18:44:08 -0500 Received: from gprs189-60.eurotel.cz ([160.218.189.60]:37437 "EHLO amd.ucw.cz" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752877AbYADXoH (ORCPT ); Fri, 4 Jan 2008 18:44:07 -0500 Date: Sat, 5 Jan 2008 00:44:13 +0100 From: Pavel Machek To: Kent Yoder Cc: Marcel Selhorst , Andrew Morton , TPM Device Driver List , linux-kernel@vger.kernel.org, David Smith Subject: Re: [tpmdd-devel] [PATCH] - TPM save state before suspending to ram Message-ID: <20080104234413.GB800@elf.ucw.cz> References: <477D491F.1060001@selhorst.net> <20080104163917.GB27447@elf.ucw.cz> <499d6ed30801041209o4da54b3bw39335f3342e528f0@mail.gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <499d6ed30801041209o4da54b3bw39335f3342e528f0@mail.gmail.com> X-Warning: Reading this can be dangerous to your mental health. User-Agent: Mutt/1.5.17 (2007-11-01) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2315 Lines: 70 On Fri 2008-01-04 14:09:01, Kent Yoder wrote: > On Jan 4, 2008 10:39 AM, Pavel Machek wrote: > > > > On Thu 2008-01-03 21:44:15, Marcel Selhorst wrote: > > > Dear list, > > > > > > this patch fixes a bug, that prevents the TPM chip to resume correctly from a > > > suspended state. > > > > > > Signed-off-by: Marcel Selhorst > [cut] > > > > I'm not sure if we want to use variable-size array on stack. What > > hacks are you doing with max_t/max? > > Pavel > > Hi Pavel, > > Here's an alternate solution from David, signoffs pending -- > > commit 058f1e3c4d4e2de5a7188608a1c2e0722498fd4b > Author: David Smith > Date: Fri Jan 4 03:33:11 2008 +0900 > > Fix for TPM suspend/resume failure > > diff --git a/drivers/char/tpm/tpm.c b/drivers/char/tpm/tpm.c > index 9bb5429..79d2fd5 100644 > --- a/drivers/char/tpm/tpm.c > +++ b/drivers/char/tpm/tpm.c > @@ -1046,12 +1046,6 @@ void tpm_remove_hardware(struct device *dev) > } > EXPORT_SYMBOL_GPL(tpm_remove_hardware); > > -static u8 savestate[] = { > - 0, 193, /* TPM_TAG_RQU_COMMAND */ > - 0, 0, 0, 10, /* blob length (in bytes) */ > - 0, 0, 0, 152 /* TPM_ORD_SaveState */ > -}; > - > /* > * We are about to suspend. Save the TPM state > * so that it can be restored. > @@ -1059,8 +1053,14 @@ static u8 savestate[] = { > int tpm_pm_suspend(struct device *dev, pm_message_t pm_state) > { > struct tpm_chip *chip = dev_get_drvdata(dev); > + u8 savestate[] = { > + 0, 193, /* TPM_TAG_RQU_COMMAND */ > + 0, 0, 0, 10, /* blob length (in bytes) */ > + 0, 0, 0, 152 /* TPM_ORD_SaveState */ > + }; > + > if (chip == NULL) > - return -ENODEV; > + return -ENODEV; > > tpm_transmit(chip, savestate, sizeof(savestate)); > return 0; Yep, but please fix the whitespace. Pavel -- (english) http://www.livejournal.com/~pavelmachek (cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/