Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp355227lqs; Tue, 5 Mar 2024 04:20:32 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVYvvE7edfRTM/U0DgX/0bATLFC5mebUO2ecBk9q/Uxn/fTGv044a8NSl9/PYSt+n7RsS6jHaGtI9MpKR2JW1STmlaZsRoK/BaMLQu0fQ== X-Google-Smtp-Source: AGHT+IGrdqpW99yr+Uu5qt6oY8FILAQuV4/U94c5JIkSGe9YaLJEXoNW048tcEVu7FH0nQt/AjLh X-Received: by 2002:a05:6a21:3282:b0:1a1:4598:d5a5 with SMTP id yt2-20020a056a21328200b001a14598d5a5mr1522870pzb.21.1709641232604; Tue, 05 Mar 2024 04:20:32 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709641232; cv=pass; d=google.com; s=arc-20160816; b=MXNHnxy6FlPgYynVs5XPRyHuDleet7DcC6jxzV6skuMXKKSGDbpXp81H48DoJFbdxG DkeLeCM5UkPJj2sR4NcAw6+BTdyljg0p391CnesMkz8m0qoo3InCUfF2zpB5DJhxmoiv nPX0gL38GpUGDPFmfrXaeyPKyEgtxTS4aQ5ZTUAXOG7PBhlh0Rm9iloQllk1wJMoiTxv uZZp7wgdhjs06t7TgkEJvbQdbuxQlkVDYvXEKIhXXGmSA90P2pco5tOQRiixECGEJeU4 U37qZ/Ocb7EQcLpsbXi1cOp5/iz7QdeG2vU+vsVUcJw6bwnMk1jdWlZHt7be2rn2oaxg T40Q== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :dkim-signature; bh=D6ktVqDmV7ss5l9SPN0xrD5/Tg3eFMGNcebSziUH+H4=; fh=brZETTzuIYFelLp8bKrYo1W4eEY6EyCDgruCgOuc+YU=; b=uEyS0Knzqu2iDaXPPQrGMBorwpsTRwHYrrLeERkNrj0icif5ITfDmvmovqbGMBq2oS VGb5OpqCDltFW0GByGR2GlqWpNHG0L71SH6QL6IT9z+sBb1kITN5lH1An8C2Buh1wCha xXYemRCrQ74z2e6rNueI4I8ITnbTCALcq+G2t4mIeolFyqNLgoGB4G3r/IbClbxWw0la PTzL1KvXgvZTwNa0aCDx9qSx6Qt3wYhpjWM3FIQh90A2lM3r178V51LwBJPQW31IwjsO BtO5bfd7uOzsqnjb1bwMixWo3F2QyESBbhok6GTdbI/RPY+n7+ZEfXHkisdthAINjwPK rrpQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlwGSpUt; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-92340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92340-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id p15-20020a62ab0f000000b006dfecfeab74si9824965pff.337.2024.03.05.04.20.32 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 04:20:32 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=wlwGSpUt; arc=pass (i=1 spf=pass spfdomain=linaro.org dkim=pass dkdomain=linaro.org dmarc=pass fromdomain=linaro.org); spf=pass (google.com: domain of linux-kernel+bounces-92340-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92340-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 35032B226E4 for ; Tue, 5 Mar 2024 12:16:00 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 0337E5A793; Tue, 5 Mar 2024 12:15:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="wlwGSpUt" Received: from mail-yb1-f171.google.com (mail-yb1-f171.google.com [209.85.219.171]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 177965B5B5 for ; Tue, 5 Mar 2024 12:15:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.171 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709640916; cv=none; b=msu9CaofcmSdlqSnEEEEGXuNA+67dScmiPlH4j4fxI7+1IiLYSqOTZmYPZx1yzV1O3J7feNgiUfPFQWS0wZHlNjMFk2k2NBA6Gk1LcvM0JMS7b9CzLPZcvSlUWCsIyNzgAe1MKkMC7e2wTiZ1+HsK8sUmWKEP5bkx2izyQ6kPaY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709640916; c=relaxed/simple; bh=g7XHUxRHu85gEg3FW1hsjzi+N1cNjvNBBFKV+KzP3B4=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=F1jdo70MKjwdGZF6uHSk9Hk8+5lrOVlSHo6ZPAgX7ObB89r4/e/Gk83rDnrvOqnIXOygQcLYk+BZ3j+lHOlNsYB/yQe7fac+xd/Ax6eQMwNH5cI+tfQr/CoGHZpSERL3q9oCi3rB1gfMb87og9I8Vn1Yzhpm3/WYFOLxhdVVopc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=wlwGSpUt; arc=none smtp.client-ip=209.85.219.171 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f171.google.com with SMTP id 3f1490d57ef6-dccb1421bdeso566821276.1 for ; Tue, 05 Mar 2024 04:15:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709640914; x=1710245714; darn=vger.kernel.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=D6ktVqDmV7ss5l9SPN0xrD5/Tg3eFMGNcebSziUH+H4=; b=wlwGSpUtcQfN2v6GKRwzs64vl/MMHf4ERNAhx/2dLZbLFQ/8MsWTehTQh8hXvvx91p FFHpGdMoAMVvgm3Gfqco6XRnwy9+f8uzfFV938ImW4UdRqTI5yt+znA5idhrUbHUHZ0/ Oz3j7NA2VOetrc+b1V8Xd9myZf24xZoLeipmPAvUaQGLViHRS64fn8YSB9tWbGYjDwX3 5tpqQx1upjUtV3X/TZaq3aIVwY/bnsRCHKSZKSDCgE7r8k4CY8ppafy+Qdiu+vRh/i3M Ot4QZ3sVycuBEVQMVyOf4KfUK0fg6Y0grzomydKA4Iv9hdjFAKn1NSRS+3yuLYHJVnqu h3fg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709640914; x=1710245714; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=D6ktVqDmV7ss5l9SPN0xrD5/Tg3eFMGNcebSziUH+H4=; b=JdKkrI3ZBZPs7StktSoUmEJEpuxXF7G3EjynnBXrtMZtha3mlW4dqT0LDgma55Lf7l DuDAgjWXhv+9ygk8lXM2WgrMAvoU+4985dZOrOU7yJstqWWQtRCehZf5jAnCP1LY20Er 5fi9JQ8cc9+WPR2xhqYfzJmpA4hccLOSUtnziQg6ESStAPVfSyhBgRcaQyPIYZLDuBj1 od8WOVI0PJhuMEIjDCFNfYN1DiaFTLTJVfpbx1kKOVNiro3UDk4OnzVCAk9F6FmT+777 2Z5gLcT5EiYf+PQx2+qseVVQS7LG/czX8lrezQxbwo4YVkTpDZ6RHpU2Cgaqep/0SWT8 9jDA== X-Forwarded-Encrypted: i=1; AJvYcCXRQyfyuHpNSxtJZKdvheHFLpkwc323eQfuHv5MpTv9MM6EyZyFIm+xWYY8SaSfNwBLuUI6xzIyv3iTp/Vv4bS8ES3WsShWwB4RyCku X-Gm-Message-State: AOJu0YyJLn3quzKkcbIUI8WB4ekoRf4/ay/FpMEFAn6p9cdbmgmDnLtT NX2spzowrDkXMIppKZXhUAM/gQws2fAD+ZIeHF3e/w99kmqXWL5tKcXMn+4rA7/KUCqNClPNaFz KUrn/F3/ZGLO249b6DMuTfh2rX8TnJ+Iqmr5t2g== X-Received: by 2002:a25:d883:0:b0:dcc:e9d:4a22 with SMTP id p125-20020a25d883000000b00dcc0e9d4a22mr8993815ybg.12.1709640913987; Tue, 05 Mar 2024 04:15:13 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240229-b4-mmc-hi3798mv200-v7-0-10c03f316285@outlook.com> In-Reply-To: <20240229-b4-mmc-hi3798mv200-v7-0-10c03f316285@outlook.com> From: Ulf Hansson Date: Tue, 5 Mar 2024 13:14:38 +0100 Message-ID: Subject: Re: [PATCH v7 0/5] mmc: add hi3798mv200 specific extensions of DWMMC To: forbidden405@outlook.com Cc: Jaehoon Chung , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Adrian Hunter , Andrew Jeffery , Joel Stanley , Igor Opaniuk , tianshuliang , David Yang , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, openbmc@lists.ozlabs.org, linux-arm-kernel@lists.infradead.org, Paul Menzel , Krzysztof Kozlowski Content-Type: text/plain; charset="UTF-8" On Thu, 29 Feb 2024 at 02:36, Yang Xiwen via B4 Relay wrote: > > it's modified from hi3798cv200 driver, but quite a lot of code gets > rewritten because of the hardware differences. Actually cv200 DWMMC core > is called HIMCIV200 while mv200 DWMMC core is called HIMCIV300 in > downstream. > > Signed-off-by: Yang Xiwen The series, applied for next, thanks! Note that, I took the liberty of updating/clarifying the commit message of patch1, please let me know if there is anything you don't like with that. Kind regards Uffe > --- > Changes in v7: > - driver: simplify tuning logic (Ulf Hansson) > - bindings: fix patch order (Ulf Hansson) > - Link to v6: https://lore.kernel.org/r/20240221-b4-mmc-hi3798mv200-v6-0-bc41bf6a9769@outlook.com > > Changes in v6: > - apply the comments to the first patch, add their trailers > - Link to v5: https://lore.kernel.org/r/20240220-b4-mmc-hi3798mv200-v5-0-f506c55f8e43@outlook.com > > Changes in v5: > - pick the dependant patch: https://lore.kernel.org/all/20240215-mmc_phase-v1-1-f27644ee13e4@outlook.com/ > to fix the bot build error. > - edit the semantic meaning of hisilicon,sap-dll-reg property (Rob Herring) > The suggestion is from the CRG driver side: > https://lore.kernel.org/all/20240218205741.GA1561527-robh@kernel.org/ > - Link to v4: https://lore.kernel.org/r/20240217-b4-mmc-hi3798mv200-v4-0-0fdd9bd48532@outlook.com > > Changes in v4: > - rename dw_mmc-hi3798 back to hi3798cv200 - Suggested by Krzysztof Kozlowski. > - add r-bs to patch 1 and 2 - Reviewed by Krzysztof Kozlowski. > - Link to v3: https://lore.kernel.org/r/20240217-b4-mmc-hi3798mv200-v3-0-f15464176947@outlook.com > > Changes in v3: > - dw_mmc-hi3798: fix bot error (Rob Herring) > - Link to v2: https://lore.kernel.org/r/20240216-b4-mmc-hi3798mv200-v2-0-010d63e6a1d5@outlook.com > > Changes in v2: > - dw_mmc-hi3798mv200: use dev_err_probe() helper - Suggested by Krzysztof Kozlowski. > - dw_mmc-hi3798mv200: add missing err=0; > - dw_mmc-hi3798c(m)v200: remove unused MODULE_ALIAS() - Suggested by Krzysztof Kozlowski. > - binding: rename the binding, a lot of tweaks suggested by Krzysztof Kozlowski. > - Link to v1: https://lore.kernel.org/r/20240216-b4-mmc-hi3798mv200-v1-0-7d46db845ae6@outlook.com > > --- > Yang Xiwen (5): > mmc: host: mmc_of_parse_clk_phase(): Pass struct device * instead of mmc_host * > mmc: dw_mmc-hi3798cv200: remove MODULE_ALIAS() > dt-bindings: mmc: dw-mshc-hi3798cv200: convert to YAML > dt-bindings: mmc: hisilicon,hi3798cv200-dw-mshc: add Hi3798MV200 binding > mmc: dw_mmc: add support for hi3798mv200 > > .../bindings/mmc/hi3798cv200-dw-mshc.txt | 40 ---- > .../mmc/hisilicon,hi3798cv200-dw-mshc.yaml | 97 ++++++++ > drivers/mmc/core/host.c | 4 +- > drivers/mmc/host/Kconfig | 9 + > drivers/mmc/host/Makefile | 1 + > drivers/mmc/host/dw_mmc-hi3798cv200.c | 1 - > drivers/mmc/host/dw_mmc-hi3798mv200.c | 251 +++++++++++++++++++++ > drivers/mmc/host/sdhci-of-aspeed.c | 2 +- > include/linux/mmc/host.h | 2 +- > 9 files changed, 361 insertions(+), 46 deletions(-) > --- > base-commit: d206a76d7d2726f3b096037f2079ce0bd3ba329b > change-id: 20240121-b4-mmc-hi3798mv200-a5730edf122c > > Best regards, > -- > Yang Xiwen >