Received-SPF: pass (google.com: domain of linux-kernel+bounces-92366-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <cover.1707363758.git.perry.yuan@amd.com> <f6ace4124c45e523e984b4eeab3760b95a70b72d.1707363758.git.perry.yuan@amd.com>
 <ZcRs7Ki8dhxCfCM9@BLR-5CG11610CF.amd.com>
In-Reply-To: <ZcRs7Ki8dhxCfCM9@BLR-5CG11610CF.amd.com>
From: "Rafael J. Wysocki" <rafael@kernel.org>
Date: Tue, 5 Mar 2024 13:25:47 +0100
Message-ID: <CAJZ5v0iqhvi7tkrLw7FnG2PQh8oXbn=XF7meHU06cbTQJ0=Gaw@mail.gmail.com>
Subject: Re: [PATCH v6 1/6] ACPI: CPPC: enable AMD CPPC V2 support for family
 17h processors
To: "Gautham R. Shenoy" <gautham.shenoy@amd.com>, Perry Yuan <perry.yuan@amd.com>
Cc: rafael.j.wysocki@intel.com, Mario.Limonciello@amd.com, 
	viresh.kumar@linaro.org, Ray.Huang@amd.com, Borislav.Petkov@amd.com, 
	Alexander.Deucher@amd.com, Xinmei.Huang@amd.com, Xiaojian.Du@amd.com, 
	Li.Meng@amd.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, Feb 8, 2024 at 6:56=E2=80=AFAM Gautham R. Shenoy <gautham.shenoy@am=
d.com> wrote:
>
> Hello Perry,
>
> On Thu, Feb 08, 2024 at 11:46:28AM +0800, Perry Yuan wrote:
> > As there are some AMD processors which only support CPPC V2 firmware an=
d
> > BIOS implementation, the amd_pstate driver will be failed to load when
> > system booting with below kernel warning message:
> >
> > [    0.477523] amd_pstate: the _CPC object is not present in SBIOS or A=
CPI disabled
> >
> > To make the amd_pstate driver can be loaded on those TR40 processors, i=
t
> > needs to match x86_model from 0x30 to 0x7F for family 17H.
> > With the change, the system can load amd_pstate driver as expected.
> >
> > Reviewed-by: Mario Limonciello <mario.limonciello@amd.com>
> > Reported-by: Gino Badouri <badouri.g@gmail.com>
> > Closes: https://bugzilla.kernel.org/show_bug.cgi?id=3D218171
> > Fixes: fbd74d1689 ("ACPI: CPPC: Fix enabling CPPC on AMD systems with s=
hared memory")
> > Signed-off-by: Perry Yuan <perry.yuan@amd.com>
> > ---
> >  arch/x86/kernel/acpi/cppc.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/x86/kernel/acpi/cppc.c b/arch/x86/kernel/acpi/cppc.c
> > index 8d8752b44f11..ff8f25faca3d 100644
> > --- a/arch/x86/kernel/acpi/cppc.c
> > +++ b/arch/x86/kernel/acpi/cppc.c
> > @@ -20,7 +20,7 @@ bool cpc_supported_by_cpu(void)
> >                   (boot_cpu_data.x86_model >=3D 0x20 && boot_cpu_data.x=
86_model <=3D 0x2f)))
> >                       return true;
> >               else if (boot_cpu_data.x86 =3D=3D 0x17 &&
> > -                      boot_cpu_data.x86_model >=3D 0x70 && boot_cpu_da=
ta.x86_model <=3D 0x7f)
> > +                      boot_cpu_data.x86_model >=3D 0x30 && boot_cpu_da=
ta.x86_model <=3D 0x7f)
>
> This looks ok to me.
> Reviewed-by: Gautham R. Shenoy <gautham.shenoy@amd.com>

Applied as 6.9 material, thanks!

However, I'm not sure what to do with the rest of the series.  It
doesn't appear to be ready yet as they are comments that need
addressing AFAICS.