Received-SPF: pass (google.com: domain of linux-kernel+bounces-92439-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Message-ID: <f54e9c30-b483-4dae-9b22-24feb4fc289e@oracle.com>
Date: Tue, 5 Mar 2024 13:28:52 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE
Content-Language: en-US
To: Jason Yan <yanaijie@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, chenxiang66@hisilicon.com,
        jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com,
        dlemoal@kernel.org, ipylypiv@google.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240305122452.340471-1-john.g.garry@oracle.com>
 <20240305122452.340471-6-john.g.garry@oracle.com>
 <8834df38-413d-855c-433c-653d7023dc8b@huawei.com>
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <8834df38-413d-855c-433c-653d7023dc8b@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 8bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?elJaWkl1TURMS2tJK0p6TXFxc21VdVRwdFNtclBMT1V2SjBKeGNjcVFkRnJp?=
 =?utf-8?B?bThRekRYQ09vM3Y0YXdkck9DZ2lQallNd2k3THJiaEVFaDFsTXQxMWNPTVMx?=
 =?utf-8?B?MndNRjFVOWc4MU0wRU4rbXNxM01aeFExdHg4a3NBT29sM2xSOWRqdGt5aDBO?=
 =?utf-8?B?QkVxYitxNXJSL2VJRWIweTZIdlNETlJNUjUzbWVVTFRiMmEwQ0Q5dmlFQXRP?=
 =?utf-8?B?UG5jZU9URGN3aGJjdUFEWlVHVUhwQUlnbTRPTzFwNi9TTVNwdUlsaVN3Y044?=
 =?utf-8?B?NG9JODBjTkZHMVUrTGhxaERKNEZ2UEUxMENBL0dac0pEOTRhQ3JteEo4Wkp0?=
 =?utf-8?B?RjJ2ZkZwZTREbzRhVTdpY1ZUNWs4U2xaKy92OGhsWHVrVzdyQVVLWSs3VTI3?=
 =?utf-8?B?M2hxS0l6NDc4SDF2bDBFVDdIaU9jd1Q1eWtOb3BMeFBaeGJJN2lCMU51SGRI?=
 =?utf-8?B?UHUyRFFHV2dpZU9yRVViSktjeURvdlRmOUlweVN2OEVKa1dJdUhXVWNYK0Zn?=
 =?utf-8?B?dWlYeHQxMDVsd3NNTm9sZmg4RFo0YzBiT3FEdlRiWEQvS0FZdnBycG80cm14?=
 =?utf-8?B?bUZaYTBrSjEvQ1RWTVU4NlhRMXpBbVN3WWZ0SUtXN3VKdjVseEVrbnpucE9Z?=
 =?utf-8?B?cDRNOHlyendJaUd0dW5mVmZscjVRRS95WUhaMnF4TEpaY3dqU29ubE9uMTk0?=
 =?utf-8?B?RitlbHpINzBsK3pkRGZsYlV1cGhCcU8yaUREMTFpOEpqem4vb21NREFiN0Jp?=
 =?utf-8?B?YnlJalkxaXlwWlpJRkRXRjNLaGZDSXpheWpVbkptOXFxTTR4ZlE0RTFlRlRj?=
 =?utf-8?B?N1FPdkVsTlBNMnB4VUZpTWhQOC9vWnYxUWM5MzYraURwS210QmpvWmZVVTE2?=
 =?utf-8?B?OWpsR0ZOcnJaUkxPU2dPYXZOakdaOE9tNVJCaGVBbEVrMUgwN09jOHIxQlpV?=
 =?utf-8?B?SEJrZ3ltVGdMT3BYOTErRklGbWlqenhKaE9WaGRweGV0K0RtUkJwWVpab0U0?=
 =?utf-8?B?YWxDSlRYUHRCMm52c2JnUTRmZ2NCT0NwMG5yUzI0RkhBMCtjRHJMdWNySzVx?=
 =?utf-8?B?TUVRRWlSWjJVSXNUZkMwOGdZWVRPYmswZkptRjBmNEk5azhFaFdodEpNZlRt?=
 =?utf-8?B?MnZMQmJkck80OHFrY242NjhkV2JKZml2RkIwSjNpeFNmOHFZKys1b3JhRkNX?=
 =?utf-8?B?T3ZWRUliUEZBZXZ5Z3cwWUtaUytoM2d4UWNaR3ZWM0tNZ1JLTVlCbjRqb21S?=
 =?utf-8?B?V0F5dDgraXVFZFVsSlFvK0o5ZXhHT1VtMUVxUG1aL1NPNnpxUmoyQUtuK3dh?=
 =?utf-8?B?MVNEdm9ZbjF6MVAwQVdYenJxNC9XcWdUUFBnWTdLNDlYSnRiczdLeDBDQnVm?=
 =?utf-8?B?VHRxM1RQQmVlcmoxWE9GWXdMOElMUzlHclJmeDdyMWNVa1RzS1NTNklRRFYr?=
 =?utf-8?B?WTh5UmUzU3pObGE3elUvZlluZ3F0eHNHZEJKZ2FjMmVKRG1TWmtlcXd5K2hi?=
 =?utf-8?B?UzZwdWMvbEVGeGx4d0ZsaVlzUnpKUlBqTmVDVHdpcGQyUmNwbTY0OWxaV0JW?=
 =?utf-8?B?WWticXVrcVFlQVYvWHUzUk9YaGk4TjIyekhhcnpWTWVOd2JiRkZMUXRhcGo3?=
 =?utf-8?B?MVczSnZBUUcxU0tVVWJ6YnREaFNxcEh6bG5PQjNkeWV0OTFBZ1R5REs4aDQ1?=
 =?utf-8?B?OWVYT2c3TzN5SW1PaFBkTlRRejRCNWNudXVUYW9JMWR4U25aQWM4bVZvM3Zi?=
 =?utf-8?B?Qk5MWklycFFBTlh5UVByREQvdStHdjFqbFAxdkpxVXZzMm93aDVRenlyRGtE?=
 =?utf-8?B?T0MwMjRRcDBCOTRkUWU0ZG9GVzRLN3k2VUpXK3VCWUdkdDRicFNvOHc4Nm5m?=
 =?utf-8?B?VVRJYm5RWGxlRlE3ZW9yaHUyRHdEazY5Wk9PTjFLK3FlSldWOExuMGEzZDU0?=
 =?utf-8?B?OG9Ibjl4NEZRYUhWdGZ6aGI2bTZDeEk1YTk0ZUlMTFZlODhZUjZERVdhaDVv?=
 =?utf-8?B?OHR5WndVMytQd3BSbmhxbXV1c1V5bXBRbmJ6ZnlJVmRBdFM1dHowNk9IUEhJ?=
 =?utf-8?B?cHpCbUdRRkNMOWNyK0MzM1B4RW9Kcy9jVE1TN2RTZTJlTkRYRWlrRkdGMW0y?=
 =?utf-8?B?UTl0d3BLMXdTYjBEbVJ4K3VOeWlZeGVHNzA1U2lRY1BCUm1FVUxjY1ROMjJ2?=
 =?utf-8?B?dlE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	jsLW/Y7V1kVRix5qBIQyuGPf+uYkE2jvLtRpCH437FMlOwh5kDAEb8tTNfWFmdIE0yAXl6z4yJ0WWzihE/Sd1FvQLSd7TC17Uc3zgNSSLioJqhXbNn6Fm+BIgt3HceN4+0/IQ0Xl9KPaLoao4M7WPTYG/oNK7B0MVNm5Ho6kTQRdNwlZrb0QXTDJ+axdI7Ii/F86cIoe5Iw4FHekrVeryYEIEHezjoaAfEugbYrFoqDYKZVe0gy3NEjBsTtNYHkzWu+QyH930nyyJW2EDHxaw1rNlYHMUqvwFqq59kdScjDEsHLl3+U+yk4f5BSPTZSPosBQKYZCMhfPvaXiXce7R7yYlwOJnkatsOeYvCgrpw9gCMkCiQOwglYkxS9R5zBP36FDtfm2TSXebiH7+cPsOS0woCk1g3hHEtzAcwozWlVhnCFcS56m1Aph36MAGXePZLLmzERdiaPbf1UyQnhXu8eSjfyApXqhWIWDCNM2PNW2ySh1/WvUOncgUgDjj9UpuiMVL2xrtpm8Fv4xY6B++MzuVPJY5VdhlSfa4a+xaspPnHY80Anob3AOwAAMajXGtk/ex7SXuFOrVLbRMFsPSlNuS28f9zidMtxQUrD/cCk=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 709e14e1-5891-4fec-6672-08dc3d1833ae
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 13:28:53.7158
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ukbGiafoPSDU8XZZ6DeYreCSELl3Ml4Fecnz7kpZqksnM/bX40D8NLXNA28NUT1TwrnxoULKfCfN16Q0y0058A==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR10MB7082
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-05_10,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403050109
X-Proofpoint-ORIG-GUID: pPlGkpzCHNOa6mpxq3VRiOs9Mdxl0n8u
X-Proofpoint-GUID: pPlGkpzCHNOa6mpxq3VRiOs9Mdxl0n8u

On 05/03/2024 13:19, Jason Yan wrote:
>> -    .ioctl            = sas_ioctl,
>> -#ifdef CONFIG_COMPAT
>> -    .compat_ioctl        = sas_ioctl,
>> -#endif
>>       .shost_groups        = mvst_host_groups,
>>       .sdev_groups        = mvst_sdev_groups,
>>       .track_queue_depth    = 1,
>>
> 
> Doesn't hvae ->eh_abort_handler too.

Is setting eh_abort_handler actually really ever required for libsas 
drivers? We have sas_eh_abort_handler, so I assume so..

Thanks,
John