Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp409531lqs; Tue, 5 Mar 2024 05:54:05 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXYZeDyzZQumKKqc967d4HFRgqOAPSfP4pJjFGNjHhgVWAO1delZZS7RX7zF0ceNubCTZTtaHfny+GAl4B8H2jXKZsgNRtJX1KjEMfNJA== X-Google-Smtp-Source: AGHT+IEaBdVHKgZl59M3hnLc8w1gapna+NdMtL9ls6F+JHLeb3i4G3eV7bZGMGR5K18mWHVajySt X-Received: by 2002:a05:6a20:158b:b0:1a1:e41:3edb with SMTP id h11-20020a056a20158b00b001a10e413edbmr2560066pzj.11.1709646845332; Tue, 05 Mar 2024 05:54:05 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709646845; cv=pass; d=google.com; s=arc-20160816; b=LtBGQa2MOs8Yks2ZdiALBzm3vR5jP9q9Woyztd7g/UxZEkaYQG4Q9aoJg7OiQWJHOt 1U/8Pl6LWNm9Yubb4KHpFQIe9lGu4DUpdl0BGDFch10SfGepRMsT/N7+CKivU4d4QdIr mIpXCnCiaeeJcJkWqZYnf9zhR7qzRTMCjWD081Rdywm1/psTbIFPWUmPLfMMP+N6D5s4 DdX0LWKTVh3M8I48kCiD05t1eU1aJ9eh+Hij2H9wvoDuxUbpKK3RiFoFAvtgQvIxbqmF OFykMCiLvcnH7rcJ6DKbrBvLaed+PGj474Ndlp7uPhqkf/p8RmRWdhl9IUF6hK7py+m+ 9/nw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=ISFv2f+NaF/v+Q9mbb9hwn6OHUW2XQ1XyibsscFQb0g=; fh=LZDG1kBn1WT94CIPZdTg/RnpT4wYG1PkECt+FmHdbJU=; b=C48iAeey2yujn47gv36u+WDkiqJv9bmGbtvCIWRPEPzWnjADi0YQTeRRXWIacpefgm fOKEMAOHV0twaWhDoQwFcSoDtQvpWAnPr/w2UHOfu95WboP3T+N0qJ1oA63u21F1z59R Q5zsG7WyGoMblryUES/7fa9El9269InSDxQOEDTEj4iMN3EDAU7gzhbW2acVN28o0Dg5 FbAcPP82yqY8LqQZj0CAc21rcDvAPwljBqRwkU0gDMYQxPVMcoAJTFw7+rkBO/82vk/u kD/ADLU1YvISJwa/yEljV21Vzo8eb7VuZJf7+Kg6r9qjmkK64BBPAMODVD+2nUk1DDo/ GxhA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BKM2NUpQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-92472-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92472-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id e21-20020a637455000000b005bd27be66e1si9990158pgn.719.2024.03.05.05.54.05 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 05:54:05 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92472-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=BKM2NUpQ; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-92472-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92472-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 03754284019 for ; Tue, 5 Mar 2024 13:52:51 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5D93A8613A; Tue, 5 Mar 2024 13:52:43 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="BKM2NUpQ" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 84F505102B; Tue, 5 Mar 2024 13:52:42 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709646762; cv=none; b=oL/CyMx1dVbFsPwKSfDS1iG3Bsx+nU5NyyBIr0FsD6/wCWP7+G65iFyS2vkDwZ4MQFKv1/sKxHlqhF8ymspeZfh2dGpa1BTQgsrQ0CgF+1xCgh1Rw73B9A7kaCcnoqQc6Ua8Lj3FmmEgYHZ7bHo4G73bozk/PE9XyBqz4kFglpA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709646762; c=relaxed/simple; bh=b/75Y8D1XYqdu9zUfIy3JxL+23E6PphPsfEVHE/48rQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=ZrX++itCdEZZQFKMADUi8AIPuxzkVZn1aV4Dvm2In6GsYnVG+DK6kfuf68VC1YN4bucX2IytFoqj7NcR3JzuhY6h47LeeyJRuGkNCF8C818U4eeEeGxQ9Hk67wYqcmG97BljtE66/86n7RVhGY9GS3KSjOUt+gJlVlCVi9AdaxM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=BKM2NUpQ; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 36561C43390; Tue, 5 Mar 2024 13:52:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709646762; bh=b/75Y8D1XYqdu9zUfIy3JxL+23E6PphPsfEVHE/48rQ=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=BKM2NUpQgft7AsZWuxoIMvwBDZF1xTbBQOEactvkwuefEM+OwKD3DPTap+WoTWa8B cXzNKMYEMeRrGqtSJSrpA12US4xNQsPmhLoKTmSSR9d/qcyrVOjLIBDUT0oIoD1MaD +0xpsat3ZTKYp1Hea9/53t67yN1/cl+725l5d4GENhJi4XqjF1/yHrXcTQSpneOFxP dhu35qRTMR+INbOyalfx3BSapim4tUggNw1gYYRIa8GZktYuhwSWCQAbgbJBCF5D2x J7Q7FF5wiEuseAavYJ+olkgBbq87qU4VBZAurt93FRw1OtIKxaaoKE5+Yvi0ZjdCak kHTMiI8mQ5Avw== Date: Tue, 5 Mar 2024 13:52:38 +0000 From: Simon Horman To: Breno Leitao Cc: kuba@kernel.org, davem@davemloft.net, pabeni@redhat.com, edumazet@google.com, Sabrina Dubroca , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, dsahern@kernel.org Subject: Re: [PATCH net-next] net: macsec: Leverage core stats allocator Message-ID: <20240305135238.GG2357@kernel.org> References: <20240305113728.1974944-1-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240305113728.1974944-1-leitao@debian.org> On Tue, Mar 05, 2024 at 03:37:27AM -0800, Breno Leitao wrote: > With commit 34d21de99cea9 ("net: Move {l,t,d}stats allocation to core and > convert veth & vrf"), stats allocation could be done on net core > instead of in this driver. > > With this new approach, the driver doesn't have to bother with error > handling (allocation failure checking, making sure free happens in the > right spot, etc). This is core responsibility now. > > Remove the allocation in the macsec driver and leverage the network > core allocation instead. > > Signed-off-by: Breno Leitao Reviewed-by: Simon Horman