Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755379AbYAECfi (ORCPT ); Fri, 4 Jan 2008 21:35:38 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1754678AbYAECfa (ORCPT ); Fri, 4 Jan 2008 21:35:30 -0500 Received: from rhun.apana.org.au ([64.62.148.172]:2834 "EHLO arnor.apana.org.au" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1754624AbYAECf3 (ORCPT ); Fri, 4 Jan 2008 21:35:29 -0500 From: Herbert Xu To: arjan@linux.intel.com (Arjan van de Ven) Subject: Re: [patch 1/3] move WARN_ON() out of line Cc: mpm@selenic.com, linux-kernel@vger.kernel.org, mingo@elte.hu, akpm@linux-foundation.org Organization: Core In-Reply-To: <477D4E50.4020004@linux.intel.com> X-Newsgroups: apana.lists.os.linux.kernel User-Agent: tin/1.7.4-20040225 ("Benbecula") (UNIX) (Linux/2.6.17-rc4 (i686)) Message-Id: Date: Sat, 05 Jan 2008 13:35:12 +1100 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 956 Lines: 24 Arjan van de Ven wrote: > >> While we're here, I'll mention that dump_stack probably ought to take a >> severity level argument. > > 125 files changed, 202 insertions(+), 199 deletions(-) > just to get the api change done. > I can hear akpm cringe from here... You don't have to change all of them at once. Just create a new function that does take a level and make the old dump_stack and WARN_ON call that then slowly convert everything else across if so desired. Cheers, -- Visit Openswan at http://www.openswan.org/ Email: Herbert Xu ~{PmV>HI~} Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/