Received-SPF: pass (google.com: domain of linux-kernel+bounces-92517-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Tue, 5 Mar 2024 10:33:06 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: peterx@redhat.com
Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org,
	Christophe Leroy <christophe.leroy@csgroup.eu>, x86@kernel.org,
	"Kirill A . Shutemov" <kirill@shutemov.name>,
	Yang Shi <shy828301@gmail.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	linuxppc-dev@lists.ozlabs.org, Muchun Song <muchun.song@linux.dev>
Subject: Re: [PATCH v3 10/10] mm/treewide: Align up pXd_leaf() retval across
 archs
Message-ID: <20240305143306.GZ9179@nvidia.com>
References: <20240305043750.93762-1-peterx@redhat.com>
 <20240305043750.93762-11-peterx@redhat.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240305043750.93762-11-peterx@redhat.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?YcphlCYBpgIEgTSfr0jAKllH/O2GE8k32Ni2IItKezEcothMB+WGHJO7U00C?=
 =?us-ascii?Q?yvhU4K/4XhYg9VQuRSlsyJCGDyHyrsdbNUnd8Yb56HdbEjO9i9oRvbmCkG+F?=
 =?us-ascii?Q?3ec/AoAWyss1+X8DkokRE3nm+ZcdguN1PhVWe1xKJ7rHUwYlA6rYiaTDN58V?=
 =?us-ascii?Q?71xicl1u4RY23Eq7tBWzDW8fnorc49Jq8HWRsRvCmHIoJVJ7GsqlqGq0AuoM?=
 =?us-ascii?Q?J2Xup8LnoDRxScsA1I1wwHMk2OZfUiz66OArUwi8SJs7WA7Ve9JcWE7shxCU?=
 =?us-ascii?Q?KpLu2xVWvGO8auYbdVa5DcNGWtX/aU02fcg4T//4Lp4xb7wATqv7J68GmgQ9?=
 =?us-ascii?Q?BrDrnZESS4S5KPj5dw1Nj+oIwO20oom5gS7HMh212TNGMlQqes+QKYkomwd5?=
 =?us-ascii?Q?F/1VMChwW9bg+fsZ9gnSnyaRBHHSmt2Snp+rLp8r0LbLSlfhgE7/IyGffCNS?=
 =?us-ascii?Q?/vFTsLye7aBhJC147wq5DyC19UkMhuZV4OSArpzAb48SnkZZYWZA7DBlZU+Y?=
 =?us-ascii?Q?+nO6lV/RhdBLc2w/d7SUTUPXX6JXT0kOzToA2Gs8U2o1CII6heevn3MYX8Fu?=
 =?us-ascii?Q?odwbqk6XmxSjTb7jWMyWqTH3TLjhuj230UISXWoPwv9I48iPLV7fjJtCWGQV?=
 =?us-ascii?Q?n8Mhk8T7eQ5v6LX5rqjrnDv5EaUZ+ke/08uwQlWR6nOHLo3jCtiiZt/YvOOj?=
 =?us-ascii?Q?G8fHfFbu2UkLQcxJnYYitLri6GIaZDRh5aiPbxdto+s0JoxdVrDEUAeOZFGs?=
 =?us-ascii?Q?JfWc6jvb7A1jUCwj4R31ThpduETTXBHN0NxojHR7bTe/pjoWWot57acBJkbx?=
 =?us-ascii?Q?mCjDvonn/ntimTUhm47SREqO1rRG3uQ++xd97NM6a9PWTpV7sUH9WzIZngKi?=
 =?us-ascii?Q?SdwBJB9yJO0TNIrdjilw+DPBrPr5jmhnOtar+SYTG6+3ZeK2mJ3HUAc05Qd1?=
 =?us-ascii?Q?8pb/A6SDgfe2jKbgqKZYXpMhfOxxggSYECop1T5NWGb2WmLnq0rGDfyyWwHc?=
 =?us-ascii?Q?m8zTSgLTWceCsXBmZhHrrQ5WbgmAOWofHOqAeH1UFQAOrLPXTXDvAQlPFLSm?=
 =?us-ascii?Q?75+N0nG4HiuhPk15m8qUzqAyuQ5ALyfNGTQNmgrUvvRolJaU4qHAJwmiJ94q?=
 =?us-ascii?Q?fzDDCCSMYezruVRypyxCupZE6uLysiE10gwh4UKacoIFxfKgfrQinXu+xhlJ?=
 =?us-ascii?Q?YRfvP12GW7opWUo46CBluoJSvC91WJjDHl6hUNU1xeVnpVGk0LCcLqiIDmYA?=
 =?us-ascii?Q?zNDbe8if5HVXFKWNmrrDS8JTstJJq4aV5aGeZFUgI11lcNtNWAzWb+NdOCg0?=
 =?us-ascii?Q?o6amcrWA4dGZkkkk0CjIJsYYBDJ8Uv+q5Kg4Opuqm9aFPmWN1/a4pXJLiStv?=
 =?us-ascii?Q?EIewJHxih9izwA3amdDvNOMQxuwS1NqxdtVoq917Q4aNWtKGnZFPFmr7dHQH?=
 =?us-ascii?Q?6J+1TWVA+6hbGYCfRYJZvbsoGaBbD0ZgD2w5U9je0XGFIJwuxcDNqXyIlu7F?=
 =?us-ascii?Q?zqgDkG+dLpE6ICRSV9QFFcfIEOjUzFQuyQUKUUQ2a1Xxmqm6zPhX7B4riMSO?=
 =?us-ascii?Q?cAs1s1tfOjaYW/kgbIsu9gHCv1l1rKUTffzwmLaD?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f3bd94cc-2118-4432-f03a-08dc3d212cae
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 14:33:07.4394
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 3OOxcYidUDs9uw4w00blY6qVsoUnXhEcuUWxo04DxJ3oHwLn8qKH2NELIBP4kwaD
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6784

On Tue, Mar 05, 2024 at 12:37:50PM +0800, peterx@redhat.com wrote:
> From: Peter Xu <peterx@redhat.com>
> 
> Even if pXd_leaf() API is defined globally, it's not clear on the retval,
> and there are three types used (bool, int, unsigned log).
> 
> Always return a boolean for pXd_leaf() APIs.
> 
> Suggested-by: Jason Gunthorpe <jgg@nvidia.com>
> Signed-off-by: Peter Xu <peterx@redhat.com>
> ---
>  arch/riscv/include/asm/pgtable-64.h | 2 +-
>  arch/riscv/include/asm/pgtable.h    | 2 +-
>  arch/s390/include/asm/pgtable.h     | 4 ++--
>  arch/sparc/include/asm/pgtable_64.h | 4 ++--
>  arch/x86/include/asm/pgtable.h      | 8 ++++----
>  include/linux/pgtable.h             | 8 ++++----
>  6 files changed, 14 insertions(+), 14 deletions(-)

Reviewed-by: Jason Gunthorpe <jgg@nvidia.com>

Jason