Received-SPF: pass (google.com: domain of linux-kernel+bounces-92572-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Tue, 5 Mar 2024 07:03:49 -0800
From: Jakub Kicinski <kuba@kernel.org>
To: =?UTF-8?B?S8O2cnk=?= Maincent <kory.maincent@bootlin.com>
Cc: Florian Fainelli <florian.fainelli@broadcom.com>, Broadcom internal
 kernel review list <bcm-kernel-feedback-list@broadcom.com>, Andrew Lunn
 <andrew@lunn.ch>, Heiner Kallweit <hkallweit1@gmail.com>, Russell King
 <linux@armlinux.org.uk>, "David S. Miller" <davem@davemloft.net>, Eric
 Dumazet <edumazet@google.com>, Paolo Abeni <pabeni@redhat.com>, Richard
 Cochran <richardcochran@gmail.com>, Radu Pirea
 <radu-nicolae.pirea@oss.nxp.com>, Jay Vosburgh <j.vosburgh@gmail.com>, Andy
 Gospodarek <andy@greyhouse.net>, Nicolas Ferre
 <nicolas.ferre@microchip.com>, Claudiu Beznea <claudiu.beznea@tuxon.dev>,
 Willem de Bruijn <willemdebruijn.kernel@gmail.com>, Jonathan Corbet
 <corbet@lwn.net>, Horatiu Vultur <horatiu.vultur@microchip.com>,
 UNGLinuxDriver@microchip.com, Simon Horman <horms@kernel.org>, Vladimir
 Oltean <vladimir.oltean@nxp.com>, Thomas Petazzoni
 <thomas.petazzoni@bootlin.com>, netdev@vger.kernel.org,
 linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, Maxime Chevallier
 <maxime.chevallier@bootlin.com>, Rahul Rameshbabu <rrameshbabu@nvidia.com>
Subject: Re: [PATCH net-next v9 07/13] ptp: Move from simple ida to xarray
Message-ID: <20240305070349.5d1a8ff0@kernel.org>
In-Reply-To: <20240305100259.006b3137@kmaincent-XPS-13-7390>
References: <20240226-feature_ptp_netnext-v9-0-455611549f21@bootlin.com>
	<20240226-feature_ptp_netnext-v9-7-455611549f21@bootlin.com>
	<20240304184737.30cac57b@kernel.org>
	<20240305100259.006b3137@kmaincent-XPS-13-7390>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

On Tue, 5 Mar 2024 10:02:59 +0100 K=C3=B6ry Maincent wrote:
> On Mon, 4 Mar 2024 18:47:37 -0800
> Jakub Kicinski <kuba@kernel.org> wrote:
>=20
> > On Mon, 26 Feb 2024 14:39:58 +0100 Kory Maincent wrote: =20
> > > +static DEFINE_XARRAY_FLAGS(ptp_clocks_map, XA_FLAGS_LOCK_IRQ |
> > > XA_FLAGS_ALLOC);   =20
> >=20
> > Why _IRQ? anything on the fastpath hopefully has a pointer to the clock
> > already, I'd hope. And we often reserve ID 0 as invalid. =20
>=20
> To keep the same flag as IDA_INIT_FLAGS, I am not expert in xarray so I j=
ust
> keep it without questioning it. Do you think I should remove it?

Yes, I believe those defaults are just "to be safe".

> ID 0 was valid for phc. IMHO makes it invalid is not a good idea, it
> will change the phc id value for current board on the field.

Ah, right, let's keep it then. We'll have to use -1 as invalid.

> > BTW could be a standalone patch, Xarray conversion from IDA is an
> > improvement in itself. =20
>=20
> Indeed. Do you prefer this patch to be standalone?

May be a personal preference but I do feel like sending general
improvements separately from large new features makes the process=20
more smooth.