Received-SPF: pass (google.com: domain of linux-kernel+bounces-92573-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240305095111.777525-1-christian.loehle@arm.com>
In-Reply-To: <20240305095111.777525-1-christian.loehle@arm.com>
From: Vincent Guittot <vincent.guittot@linaro.org>
Date: Tue, 5 Mar 2024 16:05:00 +0100
Message-ID: <CAKfTPtC6D4RTP3T8tqEJKA1drGbAANOaGPKqmELd1G8TLocizg@mail.gmail.com>
Subject: Re: [PATCH] sched/fair: Remove stale FREQUENCY_UTIL comment
To: Christian Loehle <christian.loehle@arm.com>
Cc: linux-kernel@vger.kernel.org, mingo@redhat.com, peterz@infradead.org, 
	dietmar.eggemann@arm.com
Content-Type: text/plain; charset="UTF-8"

On Tue, 5 Mar 2024 at 10:51, Christian Loehle <christian.loehle@arm.com> wrote:
>
> effective_cpu_util() flags were removed, so remove the comment part
> mentioning it.
>
> commit 9c0b4bb7f6303 ("sched/cpufreq: Rework schedutil governor performance estimation")
> reworked effective_cpu_util() removing enum cpu_util_type.
>
> Signed-off-by: Christian Loehle <christian.loehle@arm.com>
> ---
>  kernel/sched/fair.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> index 533547e3c90a..6b0c47d00fd3 100644
> --- a/kernel/sched/fair.c
> +++ b/kernel/sched/fair.c
> @@ -7849,8 +7849,6 @@ eenv_pd_max_util(struct energy_env *eenv, struct cpumask *pd_cpus,
>                  * Performance domain frequency: utilization clamping
>                  * must be considered since it affects the selection
>                  * of the performance domain frequency.
> -                * NOTE: in case RT tasks are running, by default the
> -                * FREQUENCY_UTIL's utilization can be max OPP.

Yes, it's no more accurate.
Should we update the comment instead of deleting it as the effect is
still there ?
 "NOTE: in case RT tasks are running, by default the min utilization
can be max OPP."


>                  */
>                 eff_util = effective_cpu_util(cpu, util, &min, &max);
>
> --
> 2.34.1
>