Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp473791lqs; Tue, 5 Mar 2024 07:23:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWChQzDq+D3BB4+Ln+qBxXoj3jEinoCdsn+rByw7chAg/pyjWFdX/t0Zt5l82mTLpg6vjkkc/xH15tZZ3Rx4QEa2diz6gu77kpTiNhwxQ== X-Google-Smtp-Source: AGHT+IGtdOn5IEVkJUtOrbOTFKmWqdRYvyAZ5S40FKHmRMQNJjYqp6h/+gToU68MiBlQYKtIXM8m X-Received: by 2002:a05:6a20:4c20:b0:1a0:e03f:dee with SMTP id fm32-20020a056a204c2000b001a0e03f0deemr1542822pzb.43.1709652198733; Tue, 05 Mar 2024 07:23:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709652198; cv=pass; d=google.com; s=arc-20160816; b=xhx4rHZiwYMGBEmMIds1oAIKrFbemK/GN0DW4mG1heiS7UXY2VaXc3aFYztA19+vpX Hj93tE6xy+iDwrzmQ0VM8Hx9t/TTpGh4POKfdYKC2SMe7Zfws4ACjnpLfjlqcj9N3IZ5 By4dwtZC2KX20eNTQV5KLsUqjVe2hNSNXZAT6gPJ+O9xIRjJWwK1bXe3BTtUx/McmtZK yze0Bs4mIR4Na/3IH8m+djFA52iI91TJ+YpRZn68qrCLXUMg+3BEC1OXSSam+RR0PwT/ 73t81ZlrCwCcmLN1bLPxHskVOg7hjVOIHTnjOR0854zje4MPT40FN8HURI5oRrGvbCEu tEJQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:list-unsubscribe:list-subscribe:list-id:precedence :references:message-id:subject:cc:to:from:date:dkim-signature; bh=pD0B+EKVk+PFirsjdeUknP2wox19Crpv0lln2UI7XH8=; fh=98Ka0GLTHxHwIrINiOJzuTPQxHtLuf6O/gyFI4fEqgI=; b=lAOIGl/HP34ZP+ym2FHolRq1SuCea8pom5XvO7Z6BkqTq248VvSc5wP1lRH6ICDzta V7vrIAGijioHdFLX6JgRuxRIB1Xn/nZGdu6W2JZHV0qIS3GPo1s5hioQ2uDtPjVwLuaR ZJDZ/46FkKEtvz9+IsE3V5iwDf2goBDAFF69LywAkkSnds9Ybkem6oDoIFHdR3cCevdg dYQl8V8ebnGmctB7L/cHjQ6oGHiKmX89qewb/7wVi2XfL73Krb7rf/Sj3UlZE/vbLGDB C5JMcIVttolpsRLGNIKl+stHuTeSSyc/S0qeTpU9koPEMJcLTNAkTJX+kFWFdb+5AACt K/GA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SI8lMgAi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-92595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92595-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [2604:1380:45e3:2400::1]) by mx.google.com with ESMTPS id w23-20020a634757000000b005e438e99128si10168290pgk.721.2024.03.05.07.23.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:23:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=SI8lMgAi; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-92595-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92595-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 671FC286139 for ; Tue, 5 Mar 2024 15:23:18 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id C60CA127B40; Tue, 5 Mar 2024 15:23:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="SI8lMgAi" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id F06061272B5; Tue, 5 Mar 2024 15:23:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709652186; cv=none; b=Bu0ZsJcPuWoZKfdNnEnR06NaQQJt1AbCY0pH4mwa7ZobwtAy6Zj9MW4aaVMSZCFV3Pv55t6wy+0SDzSYgk9pjN6lgYw4xu1voWOOxBfM8nozRPCc+O41LxhFceq6fY95aMZpf4ZkWTsjOh4taILNl/d2oKCgkuEJnvTUo6MEMtI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709652186; c=relaxed/simple; bh=u/5zzaDrYAhEqBfIpcoPHzssod74ijgVQkh52KemZi0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=hA/CD/+YRHrBwdNM+jDaFxaZN3ujgO5DHy2ni1UU++nhriIHhAfRn7TiMsw/SRyrQA1W3ETZTARN732b/wCQUDl8PwYVty3ydMsUe92oeZBsZ+pHOWX53GV3C/DmHXVbzDJnYQ7dp6qU40JnkepEtiEmzu0Kso/DCAkeTr2MUx4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=SI8lMgAi; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6E819C433F1; Tue, 5 Mar 2024 15:23:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709652185; bh=u/5zzaDrYAhEqBfIpcoPHzssod74ijgVQkh52KemZi0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=SI8lMgAiTBnI9vsotV6qtjcQI1Kwgij530JvdiJ99cTux8H3xYBdo7wbJkpVyqVpS OVFHJ+2uwkQ0Z1z7+GpMSKqQYeIiSE4rn7M55cEqfQXaNCg/burHBTw38XrBX9Kymk FYOMUvFsz7QGgSix7ETQL9q1bOD3ckqrcv0C18yMdZ8NONlkzx6IBDTyA0l16RFDHZ gRMVJBQUCymMCQKqw2NKlNWDMT3OrZaO6bOKepfBby9SKDCptYXl5Xa9GVNQL3s9HZ mUovZ1uAF6LP3NxZ0oWShfAfqaLYvBN9hhVp4R3RNeRDO8wLv6vE10GR6OP7PBSIxJ 2/PrQs3p2nZmw== Date: Tue, 5 Mar 2024 15:23:01 +0000 From: Simon Horman To: Lena Wang =?utf-8?B?KOeOi+WonCk=?= Cc: "kuba@kernel.org" , "linux-kernel@vger.kernel.org" , "dsahern@kernel.org" , "jiri@resnulli.us" , Shiming Cheng =?utf-8?B?KOaIkOivl+aYjik=?= , "pabeni@redhat.com" , "edumazet@google.com" , "netdev@vger.kernel.org" , "davem@davemloft.net" Subject: Re: [PATCH net v4] ipv6: fib6_rules: flush route cache when rule is changed Message-ID: <20240305152301.GN2357@kernel.org> References: <09f2ab1b7946339da5092e10aa216e07c579c60b.camel@mediatek.com> <20240304204511.2026a56b@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: On Tue, Mar 05, 2024 at 01:01:24PM +0000, Lena Wang (王娜) wrote: > On Mon, 2024-03-04 at 20:45 -0800, Jakub Kicinski wrote: > > > > External email : Please do not click links or open attachments until > > you have verified the sender or the content. > > On Fri, 1 Mar 2024 14:39:46 +0000 Lena Wang (王娜) wrote: > > > From: Shiming Cheng > > > > > > When rule policy is changed, ipv6 socket cache is not refreshed. > > > The sock's skb still uses a outdated route cache and was sent to > > > a wrong interface. > > > > > > To avoid this error we should update fib node's version when > > > rule is changed. Then skb's route will be reroute checked as > > > route cache version is already different with fib node version. > > > The route cache is refreshed to match the latest rule. > > > > Doesn't apply, please rebase on top of latest net/main. > Hi Jakub, > I use master branch to make this patch. And it seems same with > main branch of kernel/git/netdev/net.git. > > Could you tell me which branch should be used? > > Thanks > Lena Hi Lena, The primary branch is main these days. If you are using master than it may well be stale. For reference, the current HEAD commit is. 4daa873133d3 ("Merge tag 'mlx5-fixes-2024-03-01' of git://git.kernel.org/pub/scm/linux/kernel/git/saeed/linux")