Received-SPF: pass (google.com: domain of linux-kernel+bounces-92597-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 5 Mar 2024 16:24:27 +0100
From: Luca Ceresoli <luca.ceresoli@bootlin.com>
To: Markus Elfring <Markus.Elfring@web.de>, Dan Carpenter
 <dan.carpenter@linaro.org>
Cc: linux-staging@lists.linux.dev, linux-tegra@vger.kernel.org,
 linux-media@vger.kernel.org, kernel-janitors@vger.kernel.org, Greg
 Kroah-Hartman <gregkh@linuxfoundation.org>, Jonathan Hunter
 <jonathanh@nvidia.com>, Mauro Carvalho Chehab <mchehab@kernel.org>,
 Sowjanya Komatineni <skomatineni@nvidia.com>, Thierry Reding
 <thierry.reding@gmail.com>, LKML <linux-kernel@vger.kernel.org>
Subject: Re: staging: media: tegra-video: Use common error handling code in
 tegra_vi_graph_parse_one()
Message-ID: <20240305162427.49a9f013@booty>
In-Reply-To: <f451ffba-db26-4a3b-a4b3-186c31f2ad64@web.de>
References: <dbebaea7-289c-47d9-ba06-cd58a10ea662@web.de>
	<20240301183936.505fcc72@booty>
	<9f1b617f-06cb-4b22-a050-325424720c57@moroto.mountain>
	<f451ffba-db26-4a3b-a4b3-186c31f2ad64@web.de>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello Dan, Markus,

On Sat, 2 Mar 2024 11:40:26 +0100
Markus Elfring <Markus.Elfring@web.de> wrote:

> >>> Add a jump target so that a bit of exception handling can be better r=
eused
> >>> at the end of this function implementation. =20
> =E2=80=A6
> >> Reviewed-by: Luca Ceresoli <luca.ceresoli@bootlin.com> =20
> >
> > These patches make the code worse. =20

This is of course a legitimate opinion. However Markus' patch
implements what is recommended by the documentation and is in common
use in the kernel code. A quick search found 73 occurrences in v6.8-rc7:

$ expr $(pcregrep -r -M ':\n\tfwnode_handle_put'  drivers | wc -l) / 2
73
$

300+ are found for of_node_put().

> > If we're in the middle of a loop,
> > then we should clean up the partial loop before doing the goto.
> > Otherwise it creates a mess when we add a new allocation function after
> > the end of the loop. =20
>=20
> How does such a feedback fit to another known information source?
>=20
> Section =E2=80=9C7) Centralized exiting of functions=E2=80=9D
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/D=
ocumentation/process/coding-style.rst?h=3Dv6.8-rc6#n526
>
> > Someone is going to add a _scoped() loop which uses cleanup.h magic to
> > call _put automatically.  This is a good option. =20
>=20
> I became also curious how scope-based resource management will influence
> Linux coding styles further.
> Will various collateral evolution become more interesting?

After some research I think I found what Dan means:

https://lore.kernel.org/all/20240225142714.286440-3-jic23@kernel.org/

After reading the above thread, I agree using *_scoped() macros will
be a good improvement. It is not yet in mainline as of v6.8-rc7, but
it is in linux-next. So I think despite being valid this patch might
still be discarded because a better solution should be available in a
few weeks.

Luca

--=20
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com