Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp485757lqs; Tue, 5 Mar 2024 07:39:25 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUidukP8ZUsusctFwDO8GreYXzWtzi8/sfrewjGqfQ32NICyQLxyF3uE6FDf7mYpUT+6PT2ycsNAf36x3qnT7yjjhZZRqibT/AbHCKx8g== X-Google-Smtp-Source: AGHT+IEtJlNqCtAP2mvQkDjaTCAMNesFnVh1AIJJ5CSqIPyRJ/5CsLOFvFfNTkydVSXmdIY08cxg X-Received: by 2002:a05:620a:a08:b0:788:1380:f52c with SMTP id i8-20020a05620a0a0800b007881380f52cmr2374730qka.52.1709653165255; Tue, 05 Mar 2024 07:39:25 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709653165; cv=pass; d=google.com; s=arc-20160816; b=dJjCiPJa0K3vwCFh+RZ5H8OwavcpBT05tvchiEpndraPUWINdpgcCLYnYg7rxbh0wt EA7Z8uvvAN8DUNJvwKXMahcGwM3/zz+2Sv1UOcDM+onn6WMl2Lijcy0fwYC/EkUzEpsW 3iyHXlDTOgewEsW+y4rCDq1xVkqL6DOO+DgQ3aYRI5C/qeoOy/ZHIS8PyZF7BbfMRJb5 FIHUC0SAU6hYq3XL8nec8LohPfODF9uiEOVUwyuJ6ZYLhigQigLyDLEZ8Q3FQ4CJU7JI Uu3NSiRPObVWf8T5ZjIQDaZZFDBa/NGSvyHPaHig3Q7VbNuF5EffgjoIK605maIAF+I0 rigg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=kAX0rygU6XqtlwvXO3Q/zZyIB1SQ28F8BVMoeJE19XI=; fh=88GyAPauS80E7VpBbF956jO5KMt/fOzipNT9SvfnZDI=; b=it5l6+zF2X32FkD4UrcBkS3krDx2P8/uF7a/DRhJkOx+490+kqdqoI7ToAV/IaowXX PMohzpD/FQx7gR8+Dzo948UUV3E+aFr/502VkQrEOU1LBuvMSXkbylRO0Jw9dZRNO8rP /X9FmUad/Y+mBi93RMFM2s4Sbe82HOv8BfpBTM5/H/wuaMFpQznlSNm68HcO4l5jhhRQ D2UgV2IgnRbhL3gywHLxfEzJy2pUt2YinB5U7QqivuNuIvPgUgpnh62Gq74JvQ9KrRmB dJKDL3uUxDwwHUHuB33fbmnFXpt/vmx3J423/+K39tvm5nzB5bJehlERWpgBy3/3QMc1 CfrQ==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gnumonks.org); spf=pass (google.com: domain of linux-kernel+bounces-92620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92620-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id f28-20020a05620a12fc00b007882c103ef7si4097573qkl.180.2024.03.05.07.39.24 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 07:39:25 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gnumonks.org); spf=pass (google.com: domain of linux-kernel+bounces-92620-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92620-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id BAACC1C23019 for ; Tue, 5 Mar 2024 15:39:24 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id D332A128369; Tue, 5 Mar 2024 15:39:10 +0000 (UTC) Received: from ganesha.gnumonks.org (ganesha.gnumonks.org [213.95.27.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 170B7127B58; Tue, 5 Mar 2024 15:39:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.27.120 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709653150; cv=none; b=R3MiR/xUDxKpHbrxebgNkkSJb3bAmzm3GDP068vl4O3+Cdr5VBS+KWM2OhZGBgFtp6txIlS6C9hrVQM0Ojs8NvlK4/F3dM2PCV6PVLq+MQJ4UElAo/Cfbh7qMm6bgEX0osFfETh3km2tumuzh3MxrAr3t/28zS71EwBmLVno1tg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709653150; c=relaxed/simple; bh=BaWF9e3OkLvVaDKSKCD2UZE8oWvNbIrWZQvNULYC7tU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Dh1n8iqyTUkQl+0CdTsnbnubdtoD1GikLohl25vbP8XcnbVZ+GJ4xySllUyobih5WslDxW0h03Ar1veoNeq6PvEwoYEzDG9zlXaUB3vz9XyXUj7o9+n2dNquRtkGlll2koOYSVQeN/taKEIqZMbLjq+Bvi5SdmhWFOkVzP+3zuQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org; spf=pass smtp.mailfrom=gnumonks.org; arc=none smtp.client-ip=213.95.27.120 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=netfilter.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gnumonks.org Received: from [78.30.33.11] (port=47632 helo=gnumonks.org) by ganesha.gnumonks.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1rhWsg-00E3ER-VP; Tue, 05 Mar 2024 16:39:04 +0100 Date: Tue, 5 Mar 2024 16:39:02 +0100 From: Pablo Neira Ayuso To: Breno Leitao Cc: Harald Welte , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, horms@kernel.org, dsahern@kernel.org, "open list:GTP (GPRS Tunneling Protocol)" Subject: Re: [PATCH net-next 2/3] net: gtp: Remove generic .ndo_get_stats64 Message-ID: References: <20240305121524.2254533-1-leitao@debian.org> <20240305121524.2254533-2-leitao@debian.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20240305121524.2254533-2-leitao@debian.org> X-Spam-Score: -1.9 (-) On Tue, Mar 05, 2024 at 04:15:22AM -0800, Breno Leitao wrote: > Commit 3e2f544dd8a33 ("net: get stats64 if device if driver is > configured") moved the callback to dev_get_tstats64() to net core, so, > unless the driver is doing some custom stats collection, it does not > need to set .ndo_get_stats64. > > Since this driver is now relying in NETDEV_PCPU_STAT_TSTATS, then, it > doesn't need to set the dev_get_tstats64() generic .ndo_get_stats64 > function pointer. > > Signed-off-by: Breno Leitao Acked-by: Pablo Neira Ayuso