Received-SPF: pass (google.com: domain of linux-kernel+bounces-92610-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <afab3c4a-05b1-4da5-9646-34fbf988072c@oracle.com>
Date: Tue, 5 Mar 2024 15:26:57 +0000
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH 5/6] scsi: mvsas: Use LIBSAS_SHT_BASE
To: Jason Yan <yanaijie@huawei.com>, jejb@linux.ibm.com,
        martin.petersen@oracle.com, chenxiang66@hisilicon.com,
        jinpu.wang@cloud.ionos.com, artur.paszkiewicz@intel.com,
        dlemoal@kernel.org, ipylypiv@google.com
Cc: linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240305122452.340471-1-john.g.garry@oracle.com>
 <20240305122452.340471-6-john.g.garry@oracle.com>
 <8834df38-413d-855c-433c-653d7023dc8b@huawei.com>
 <f54e9c30-b483-4dae-9b22-24feb4fc289e@oracle.com>
 <deae273c-7789-e8da-1256-777d01a4ab9f@huawei.com>
Content-Language: en-US
From: John Garry <john.g.garry@oracle.com>
Organization: Oracle Corporation
In-Reply-To: <deae273c-7789-e8da-1256-777d01a4ab9f@huawei.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?ektGS3V0WWNsVlZyNW1QNENSZGQvTUsyLzhnalRzeENDOW9YU0xyL1ArMkFz?=
 =?utf-8?B?Zkhmcm9RL1JROVRiUmcycUhSMExKTG9nUHZVejZZWW5TeE9BTlY4K1U0Z1hu?=
 =?utf-8?B?Qld6UDhwVkVrQ0lEMHk3bmRwRjVFRXZUN09FUGs3ajl6OTZpZnVKTWJCWGds?=
 =?utf-8?B?VWozNGdNUlg3THhEUVlDa2VTSkdSZHloZEVzTVBBbGR5RjdSNHdIYmd4S0h2?=
 =?utf-8?B?WHJjN29DSCszMnB3MmhVRXQwaFBTZnVRUmlFUnZHdVhwNkpBWmU4UytEd01Z?=
 =?utf-8?B?OHduZnRDQ2liZVA1eUNnQkxyOW1DcG56UDN0QVBwb0Fzc3RuZWdHNWR6WXFa?=
 =?utf-8?B?U3g2cFZ0Y3UwdUE0bGp2UVdWVVBRQzE2K3JQdEtaMytTL1VPRWNsNFRSVE82?=
 =?utf-8?B?aHFRUlYrZmk3QUpuMFF1eDhSdFFoOFBuV0tvbmNKMXEyOFhyQ1JsREpBTm1X?=
 =?utf-8?B?bzMrVmdYaHhiM3FVRVc0MVdzOFRqUThYYlBzVzk3U0pJQlhIeHlTanJKU0xl?=
 =?utf-8?B?YVNGOEh3Y0wyMkNvNnUyWWJwK0lDQlpWYW1kaGlqN25naHJra05OaXpuWitM?=
 =?utf-8?B?aFJoVkx5MTZmMzZ1VnRUK2tjSXV2S0t2VVhBZzlja29KbWxxdUFYTG9VTDQ1?=
 =?utf-8?B?MGIzV1FpaTl6cis2Tkd4alBCS1RmekZLVnlEL3Z2UU84T05MYWllb1MwT3NQ?=
 =?utf-8?B?aXdicTdRRk5VNU1PdURzQ2tBUk9FTmo4dzZWU3ZDMFdIV3ZubVJJb2J0SWNF?=
 =?utf-8?B?VXErQWV0ZE9Qd3c3QmVqOEp5U3dOR2R0dWF0TklPNzRpZzUwL2xqbks2a0xH?=
 =?utf-8?B?eG1uOUtzazExeXMxc0FBWUIxdUtqeVhmcHdWOXVZTVpQQ08rK3dqaWdpUlBq?=
 =?utf-8?B?WHllZEpEOFM5cFd6cGg5NmdaNVdCdDk1dlhWVUVGVE5XYkJ6M2JpeG1pVHFK?=
 =?utf-8?B?TE05SnArNTZTZnlwZEliTjNUU2sxaW5JanVMeGVoZG41NFdTSENMamlJN0pt?=
 =?utf-8?B?THBJMkxONWxIVmdWbk1UcEEySmtDWTVET21iTlVrRlcyMU5NYUowVnVkNnBn?=
 =?utf-8?B?aFRVRkpNaSs5RThDY1pBc1Viblc0cVpNTFZIQ2tZSEdWWGdqZ0NOSnd1M2FG?=
 =?utf-8?B?MmhPOTY4VnFqTXJnbHhBUGhYcmVzM2JZM3JnZ1BpSGFhNVBBN1RxUVVzY0pa?=
 =?utf-8?B?RkhqV252WDduVzcwcFg1M004RFpuSndlS0t6T082cGlYUGdsSVgvYTRmN3Uw?=
 =?utf-8?B?MmQ2VmM5QnVFVmx6eFA2Z1FwV2F1RERpOThuRk9BK2FndERVbmpxKy9KTDd6?=
 =?utf-8?B?dmUwUHNsY00vdmhnVkFuUzJwNFlwU2tDUTNYOURvRjVrRWRvc1U5elFIZVM1?=
 =?utf-8?B?YjNpUXNKQXFmYkdkSXk5V0dyb1ZmeTN6U295Z3VFb0lMaXJYQ21RcnlVTjRz?=
 =?utf-8?B?YXA4OTc4M1FOdlNiOXVDYWRhcVFxTU84TExIbDFDMDdmMktPMlRmaDFQVFpi?=
 =?utf-8?B?RWVNUnA5aWxjMzArNnVhM1ZWMGpLblJzSGZTOUNrdFFTWFA1Nk50dGZIaHB5?=
 =?utf-8?B?VGRjZUlRY25acjNZdlovbXYrbGlyam1nLzg5dUdNZDNjYmg4dXg3elRjWTBD?=
 =?utf-8?B?ZEU0MlJJbmkvMG5INEdYaDB2Mk4zRE1EVWxQWW5GZWZlTXJad1dRY1RKRE5W?=
 =?utf-8?B?NUZEUFIxQkh3THRYOG05bmJsamdtNDNNS0NLS3l0KysreWpKcGZEWEk1V1FX?=
 =?utf-8?B?Q0N3eE50SFBTbHVFeWRrNE1GZ3A4Ym5WbGMycXdoaDJ0T3FRb1lqbTVmcm9s?=
 =?utf-8?B?OC92NXFjeGxKaDhlU0hzTTJDRG5XSmU1cGJuZjl3ekxtK2ptQXNTUjF4bmpW?=
 =?utf-8?B?RlZ5amR4cVJEWVMzMjUwZWNQRnBLSlBKUm9lUlNuS2VpeU5mYkpLNmFOVmZn?=
 =?utf-8?B?K1lUYmdCT1J0YldxVVVWbHJydnlqOUJtdjFUSFVaSlh2UXpRU2wzZDQ5ejNR?=
 =?utf-8?B?c0ZMUkpkZDNDUkFHL0N1V0ZsM3BHVmg3Y0tQd2FNTHlBUk9kcnoyNEs3VzJ0?=
 =?utf-8?B?U0V6YXlJTTBXU1VXbXFEZUhwZWtvZmxaMHJzLzFSZThLY3NCdWVZZmgrYitz?=
 =?utf-8?B?UnhrMGw0dEw1ZEVtb2tjbXo4V0ZyR05ieVRRaWRtd3VIRTlBYS9qclVuaTBK?=
 =?utf-8?B?Ymc9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	3gTLscGqBzOToY0G7cSfleeaENIzwLgURulch0EAo/WuhqQakCbd8qOO5MXU7rp02o9jqaMoQC00Anf+SelR/HJYW8tRAy8+6+fJWQezvjMTcYGqnfAZ6pq2uOtqAgW5MZ0PdtNgO30qwexvhjy5RToNjNakux4HdU/l/QYLfOp0V6OioZDcADQ3+Vg0/iprkXsHpT81w4IL9UNcHLs7T51tcIZ6abtHLjVhT/d6ELQbf7VwHkIzNNKqr+dQFiAqyzD1olgTuKtyZotNiMTCwEsCEVLeRXaPhLfvP/1xDQYsWkj2Xe4Kywit80gmr2lpINetbHB9yc6RrH9DLaeXNEZCRSbJzPTSGMlyZ/e8K9VON1rVktaTgtSv+mgmhBXzythnUE6hxYLBJ3Xcb47H5cXLop6VJ+RkzDx/oVdhfmASP4pR53Y32ySKsFg89cbIWW5RpnT2eBgMGMEjKIenxsSvWKLERTngpxO1qJQC3UpGGFIet6U+mQgV9DLbdUtqIUfuTBnhfjVjj/ddwRVrnmy3NOP3MWNbj3A9544RrnfTWQWqey8EVcMu3xXAtV8EPv8EEI02Z2R46Z9qfjn5bZZLcyNhPO3rm4Vxvskmzkc=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: b1fe2b5b-c20f-45a0-6434-08dc3d28b418
X-MS-Exchange-CrossTenant-AuthSource: DM6PR10MB4313.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 15:27:01.1183
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: LoI8mlm1RqHBcpJRnml8GF748ycdFX5DCxCh/wsW8VnYQAr1eN8yp+orfVQZLAM2v2gslAMKDTgTGXf1XiIdiw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: BLAPR10MB5044
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-03-05_12,2024-03-05_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=972
 suspectscore=0 adultscore=0 bulkscore=0 malwarescore=0 mlxscore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2403050123
X-Proofpoint-GUID: VsfWMkCyaJJkkwIQ_7MTBA8QgUr9D0Vp
X-Proofpoint-ORIG-GUID: VsfWMkCyaJJkkwIQ_7MTBA8QgUr9D0Vp

On 05/03/2024 13:47, Jason Yan wrote:
>>>
>>> Doesn't hvae ->eh_abort_handler too.
>>
>> Is setting eh_abort_handler actually really ever required for libsas 
>> drivers? We have sas_eh_abort_handler, so I assume so..
> 
> For now among libsas drivers only isci has eh_abort_handler. But 
> LIBSAS_SHT_BASE is setting it by default. I think it's better to keep 
> the same as before for other four drivers.

Sure, but I do wonder why it is required for isci, if at all - I'll check.

The motivation to not require it is a smaller and consistent API used by 
all the libsas drivers.

Thanks,
John