Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp517724lqs; Tue, 5 Mar 2024 08:22:30 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXzjMCybcc3jy1CYmXfSlseXY2LbEoa0hkXJFh8i1+4pEMfhRkR+xCfd7bgdhx/N69ZFkqnehwvciTsJw4SJJVrTXw0XDEm1KOfqcxIRQ== X-Google-Smtp-Source: AGHT+IHl7npprXYmpmoVuyBxplPfxuXksDLug7LOyOluKtyxSak9YzSEsSoTNcv8EJ/ABFbfLOw9 X-Received: by 2002:a2e:3a17:0:b0:2d2:3c88:cd57 with SMTP id h23-20020a2e3a17000000b002d23c88cd57mr1711797lja.32.1709655749769; Tue, 05 Mar 2024 08:22:29 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709655749; cv=pass; d=google.com; s=arc-20160816; b=H2zazue3iriLfA3lKXbqnLX2ZM43dPWLH95xDui1TuTgQRG1bixuwDXYA2IjYQEOK/ HVy3LNfNK+9ON/wNWdGndamTPVJVXR0Z/Rpv0KqUUA9d8wkSUoKR6h6rQdA7nO4OKHNk dzH2e9iBuUFNTvybGKygpjM4MOYnho2ooH081eC7lpdzoNlsZSAstM2PEJqIe1NqaW7f EV3GeuVvdxaTGkx8eQCd8tTYySUz/6CubGKLuEMbG7+pui1DeNRZsYjdHsfP/7imiPs9 oCZJ6gXOzxpZOPNUc+Of83p3yrcIRtDiV3u5ptot+Uq54+a1OFgEbmL03vSMIwGBffsM UQtA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:autocrypt:from:references:cc :to:content-language:subject:user-agent:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:date:message-id :dkim-signature; bh=ZWNE66GKQK8QghoB2p30bxOx+JatGY+bo4576V1VdwM=; fh=aTn4YzfmJFRfsDJnZsWfDZYlellm/k1ii+gko5zxxbk=; b=b2MxOgH5uEy2qjmyA/sEvFDAlYWCqNCb8YOcemCCD91NwfKqKK9BDN3DIrx7oqNJ8l SZbp9588JkHN2YnSjT+HS/gJFlkM/jBkFdFWwN59dCejP6kxfpIhu7vW2DQqjfBOuPx2 J/RvMs39IjkMw/MKxjwJtwl0BdP0GuoQNDhbAA2JKQINa2oshPfbPuBnF0hQyu58gFNZ iP5CcDqXkoYsP1ikV5hmDn9+mwlOob0CGuwA9uQrOX3qgZ2BIxtmoIljtfjpqUtuxSrK aDRsOcpI/arc1GMQuJKWsiLFj207hBO91b8BYRJYm7A38T9oZW4oIcaI1LL96Bvn3XfE GJTA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y8BkPL6G; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-92670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92670-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id r20-20020a50aad4000000b00565bdc5bdc7si4767884edc.200.2024.03.05.08.22.29 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 08:22:29 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@intel.com header.s=Intel header.b=Y8BkPL6G; arc=pass (i=1 spf=pass spfdomain=intel.com dkim=pass dkdomain=intel.com dmarc=pass fromdomain=intel.com); spf=pass (google.com: domain of linux-kernel+bounces-92670-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92670-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id C53671F2138C for ; Tue, 5 Mar 2024 16:21:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id E7F63128805; Tue, 5 Mar 2024 16:21:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="Y8BkPL6G" Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3FE5128824 for ; Tue, 5 Mar 2024 16:21:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.16 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709655698; cv=none; b=FTKxn+SbNVPi/Io2onFM2oFwEnJ1XTmkGOQNLBtNxIgAcgMFX/jxoheHqYNepBc8wtXANeMcuNpiVKaRy00GKEsbUx6Ob7OkuK92KgG5oh8rnL6WqkhQvdcPdnQ+TdZOUZT3pO1jdEC5hEnW8+xQJLEeLuWyKFdTg2gHhaZXlqk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709655698; c=relaxed/simple; bh=3sM/hDXUkFkmLR5h1bxbxTNiZ0cXYZTzkJ/LYUAF0fA=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=OHyYLmaMY8mcc2Hq2wXZsAAwsaCYY4v0KECPHQG7LKh0ClX4OQUNv7pArOKCNlHqPNlmNGPih24FDMx8MncB5ij+nVSAqfVqH0dN6oglIQCwTR5FgorxBVo6rgWuWt3Re3wOw+QvEQLlr7POo//Lz1A7GbMO90Ruok3Ah37K/A4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=Y8BkPL6G; arc=none smtp.client-ip=198.175.65.16 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1709655694; x=1741191694; h=message-id:date:mime-version:subject:to:cc:references: from:in-reply-to:content-transfer-encoding; bh=3sM/hDXUkFkmLR5h1bxbxTNiZ0cXYZTzkJ/LYUAF0fA=; b=Y8BkPL6GPTNx8nsKe3p++d9C46RvUhMaXCA5u1YAxXocQj4kiUcrfZty GKxFedQwS5XyzKP6GGgZhkJrPU0e9FZf1lb6UUEP8cVNTuCErWz+BAeAG KIJ/elH9eRFLo7lBkhyawqhegERYF96ynWX7KhFIIQBNylEo8+H0tXOVu Wrmnfg4OFTjvhNt9rrxBZvoD0vLZ8Q1ybovXiM6bKU70NLrgoHg2Nnp0D 83ooI8z4sOGvoyRnLcG/buRrirOA8vqsUnTXDwrqjdmMNz+Q1Fzxa2nS4 7RIodFPgwwwnym+G34DeHcYAmBoehyOd2euHLOSw39u40hsrW7lk/Byf6 A==; X-IronPort-AV: E=McAfee;i="6600,9927,11003"; a="4343720" X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="4343720" Received: from orviesa010.jf.intel.com ([10.64.159.150]) by orvoesa108.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 08:21:33 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.06,205,1705392000"; d="scan'208";a="9391029" Received: from mecastro-mobl1.amr.corp.intel.com (HELO [10.212.136.86]) ([10.212.136.86]) by orviesa010-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Mar 2024 08:21:33 -0800 Message-ID: <14750023-e5fb-45f7-9c28-9510ce5a5994@intel.com> Date: Tue, 5 Mar 2024 08:21:32 -0800 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 1/1] x86/rtc: Remove unused intel-mid.h Content-Language: en-US To: Andy Shevchenko , =?UTF-8?Q?Mateusz_Jo=C5=84czyk?= , Mario Limonciello , linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , x86@kernel.org, "H. Peter Anvin" References: <20240305161024.1364098-1-andriy.shevchenko@linux.intel.com> From: Dave Hansen Autocrypt: addr=dave.hansen@intel.com; keydata= xsFNBE6HMP0BEADIMA3XYkQfF3dwHlj58Yjsc4E5y5G67cfbt8dvaUq2fx1lR0K9h1bOI6fC oAiUXvGAOxPDsB/P6UEOISPpLl5IuYsSwAeZGkdQ5g6m1xq7AlDJQZddhr/1DC/nMVa/2BoY 2UnKuZuSBu7lgOE193+7Uks3416N2hTkyKUSNkduyoZ9F5twiBhxPJwPtn/wnch6n5RsoXsb ygOEDxLEsSk/7eyFycjE+btUtAWZtx+HseyaGfqkZK0Z9bT1lsaHecmB203xShwCPT49Blxz VOab8668QpaEOdLGhtvrVYVK7x4skyT3nGWcgDCl5/Vp3TWA4K+IofwvXzX2ON/Mj7aQwf5W iC+3nWC7q0uxKwwsddJ0Nu+dpA/UORQWa1NiAftEoSpk5+nUUi0WE+5DRm0H+TXKBWMGNCFn c6+EKg5zQaa8KqymHcOrSXNPmzJuXvDQ8uj2J8XuzCZfK4uy1+YdIr0yyEMI7mdh4KX50LO1 pmowEqDh7dLShTOif/7UtQYrzYq9cPnjU2ZW4qd5Qz2joSGTG9eCXLz5PRe5SqHxv6ljk8mb ApNuY7bOXO/A7T2j5RwXIlcmssqIjBcxsRRoIbpCwWWGjkYjzYCjgsNFL6rt4OL11OUF37wL QcTl7fbCGv53KfKPdYD5hcbguLKi/aCccJK18ZwNjFhqr4MliQARAQABzUVEYXZpZCBDaHJp c3RvcGhlciBIYW5zZW4gKEludGVsIFdvcmsgQWRkcmVzcykgPGRhdmUuaGFuc2VuQGludGVs LmNvbT7CwXgEEwECACIFAlQ+9J0CGwMGCwkIBwMCBhUIAgkKCwQWAgMBAh4BAheAAAoJEGg1 lTBwyZKwLZUP/0dnbhDc229u2u6WtK1s1cSd9WsflGXGagkR6liJ4um3XCfYWDHvIdkHYC1t MNcVHFBwmQkawxsYvgO8kXT3SaFZe4ISfB4K4CL2qp4JO+nJdlFUbZI7cz/Td9z8nHjMcWYF IQuTsWOLs/LBMTs+ANumibtw6UkiGVD3dfHJAOPNApjVr+M0P/lVmTeP8w0uVcd2syiaU5jB aht9CYATn+ytFGWZnBEEQFnqcibIaOrmoBLu2b3fKJEd8Jp7NHDSIdrvrMjYynmc6sZKUqH2 I1qOevaa8jUg7wlLJAWGfIqnu85kkqrVOkbNbk4TPub7VOqA6qG5GCNEIv6ZY7HLYd/vAkVY E8Plzq/NwLAuOWxvGrOl7OPuwVeR4hBDfcrNb990MFPpjGgACzAZyjdmYoMu8j3/MAEW4P0z F5+EYJAOZ+z212y1pchNNauehORXgjrNKsZwxwKpPY9qb84E3O9KYpwfATsqOoQ6tTgr+1BR CCwP712H+E9U5HJ0iibN/CDZFVPL1bRerHziuwuQuvE0qWg0+0SChFe9oq0KAwEkVs6ZDMB2 P16MieEEQ6StQRlvy2YBv80L1TMl3T90Bo1UUn6ARXEpcbFE0/aORH/jEXcRteb+vuik5UGY 5TsyLYdPur3TXm7XDBdmmyQVJjnJKYK9AQxj95KlXLVO38lczsFNBFRjzmoBEACyAxbvUEhd GDGNg0JhDdezyTdN8C9BFsdxyTLnSH31NRiyp1QtuxvcqGZjb2trDVuCbIzRrgMZLVgo3upr MIOx1CXEgmn23Zhh0EpdVHM8IKx9Z7V0r+rrpRWFE8/wQZngKYVi49PGoZj50ZEifEJ5qn/H Nsp2+Y+bTUjDdgWMATg9DiFMyv8fvoqgNsNyrrZTnSgoLzdxr89FGHZCoSoAK8gfgFHuO54B lI8QOfPDG9WDPJ66HCodjTlBEr/Cwq6GruxS5i2Y33YVqxvFvDa1tUtl+iJ2SWKS9kCai2DR 3BwVONJEYSDQaven/EHMlY1q8Vln3lGPsS11vSUK3QcNJjmrgYxH5KsVsf6PNRj9mp8Z1kIG qjRx08+nnyStWC0gZH6NrYyS9rpqH3j+hA2WcI7De51L4Rv9pFwzp161mvtc6eC/GxaiUGuH BNAVP0PY0fqvIC68p3rLIAW3f97uv4ce2RSQ7LbsPsimOeCo/5vgS6YQsj83E+AipPr09Caj 0hloj+hFoqiticNpmsxdWKoOsV0PftcQvBCCYuhKbZV9s5hjt9qn8CE86A5g5KqDf83Fxqm/ vXKgHNFHE5zgXGZnrmaf6resQzbvJHO0Fb0CcIohzrpPaL3YepcLDoCCgElGMGQjdCcSQ+Ci FCRl0Bvyj1YZUql+ZkptgGjikQARAQABwsFfBBgBAgAJBQJUY85qAhsMAAoJEGg1lTBwyZKw l4IQAIKHs/9po4spZDFyfDjunimEhVHqlUt7ggR1Hsl/tkvTSze8pI1P6dGp2XW6AnH1iayn yRcoyT0ZJ+Zmm4xAH1zqKjWplzqdb/dO28qk0bPso8+1oPO8oDhLm1+tY+cOvufXkBTm+whm +AyNTjaCRt6aSMnA/QHVGSJ8grrTJCoACVNhnXg/R0g90g8iV8Q+IBZyDkG0tBThaDdw1B2l asInUTeb9EiVfL/Zjdg5VWiF9LL7iS+9hTeVdR09vThQ/DhVbCNxVk+DtyBHsjOKifrVsYep WpRGBIAu3bK8eXtyvrw1igWTNs2wazJ71+0z2jMzbclKAyRHKU9JdN6Hkkgr2nPb561yjcB8 sIq1pFXKyO+nKy6SZYxOvHxCcjk2fkw6UmPU6/j/nQlj2lfOAgNVKuDLothIxzi8pndB8Jju KktE5HJqUUMXePkAYIxEQ0mMc8Po7tuXdejgPMwgP7x65xtfEqI0RuzbUioFltsp1jUaRwQZ MTsCeQDdjpgHsj+P2ZDeEKCbma4m6Ez/YWs4+zDm1X8uZDkZcfQlD9NldbKDJEXLIjYWo1PH hYepSffIWPyvBMBTW2W5FRjJ4vLRrJSUoEfJuPQ3vW9Y73foyo/qFoURHO48AinGPZ7PC7TF vUaNOTjKedrqHkaOcqB185ahG2had0xnFsDPlx5y In-Reply-To: <20240305161024.1364098-1-andriy.shevchenko@linux.intel.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/5/24 08:10, Andy Shevchenko wrote: > intel-mid.h is providing some core parts of the South Complex PM, > which are usually are not used by individual drivers. In particular, > this driver doesn't use it, so simply remove the unused header. Indeed. intel-mid.h provides a pretty small amount of stuff and it's included in quite a few random-looking spots. There's also gunk that's only compiled in if CONFIG_X86_INTEL_MID=y so if anyone _did_ somehow use any of those functions in generic code, they'd probably be creating compile problems. Any chance you'd like to look a _bit_ more widely and just clean up all of the unnecessary intel-mid.h #includes that are scattered around?