Received-SPF: pass (google.com: domain of linux-kernel+bounces-92761-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Tue, 5 Mar 2024 09:28:22 -0800
From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Adam Ford <aford173@gmail.com>
Cc: linux-input@vger.kernel.org, aford@beaconembedded.com,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Input: ili210x:  Allow IRQ to share GPIO
Message-ID: <ZedWNlNaJQEWdA9a@google.com>
References: <20240228114142.43803-1-aford173@gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240228114142.43803-1-aford173@gmail.com>

Hi Adam,

On Wed, Feb 28, 2024 at 05:41:42AM -0600, Adam Ford wrote:
> The IRQ registration currently assumes that the GPIO is
> dedicated to it, but that may not necessarily be the case.
> If the board has another device sharing the IRQ, it won't be
> registered and the touch detect fails.

I do not believe the driver is prepared to handle shared interrupts.
First of all, it disables interrupts in the firmware update path, which
will interfere with operation of other device using the same line.

You also need to make sure the driver properly recognizes condition when
interrupt is raised by another device and Ilitek controller does not
have any data to transfer/return. In this case we need to make sure we
do not log any errors, not release any active contacts, etc.

Thanks.

-- 
Dmitry