Received-SPF: pass (google.com: domain of linux-kernel+bounces-92776-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <0f572801-8dcb-4124-94fa-cb219f60730d@amd.com>
Date: Tue, 5 Mar 2024 12:38:25 -0500
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] drm/amdkfd: make kfd_class constant
Content-Language: en-US
To: "Ricardo B. Marliere" <ricardo@marliere.net>,
 Alex Deucher <alexander.deucher@amd.com>,
 =?UTF-8?Q?Christian_K=C3=B6nig?= <christian.koenig@amd.com>,
 David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Cc: amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
 linux-kernel@vger.kernel.org, Greg Kroah-Hartman <gregkh@linuxfoundation.org>
References: <20240305-class_cleanup-drm-amd-v1-1-ea99b37f26c7@marliere.net>
From: Felix Kuehling <felix.kuehling@amd.com>
In-Reply-To: <20240305-class_cleanup-drm-amd-v1-1-ea99b37f26c7@marliere.net>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?YWN2ZHYwMzg5Y3UvR1pXc3Z0cDNMcHI4N0VLbExmY0hzT1U3eGR1Nytqb2Rj?=
 =?utf-8?B?OXpBa3FrZGxISlpwRUhOTDM5QVFKK2cxUHpkK2pwNnliMTREbWF2c1JDNGFq?=
 =?utf-8?B?WVpkR2dtZjNWRkh0emFVVmJlOEFzODZwQzJZRUwzaWlSSUJsYVB4ODd2WEVI?=
 =?utf-8?B?VVJoRUZYOWwxVkl5VEFvbXBIZDlRakJJM3lZb05DNHBROXBsYWRhNEthZk41?=
 =?utf-8?B?bmpMdGFETTc0SW91N0FLRUVSeEkvTUdGVVJ1SWF0TWs5OTcrTmdsVXJWM2Rz?=
 =?utf-8?B?SHZXeE9aeE83ODFiZEtlMW5Eb1pWVlIwaGhwWUczcTJMYzArNVVCZGp6UUNi?=
 =?utf-8?B?ajd5ZEU1NHRKYVAxWE12L3M0bmlXbzV4dmV3N01DWUdoNUlDY0hVMGF2MTJj?=
 =?utf-8?B?NDRkbStmeG9xSURsQUFzenZMVmF4K01sV3BVdkU1bmZHZFppVk9pVjZ4MmNX?=
 =?utf-8?B?MXdPUi93dkJUL1E3cmUzY1JGRXhRVndLdVptR21zZ2JrUmFEdEIxaWh0dHNF?=
 =?utf-8?B?ZXVkd3g5djd0QUFZWTViajYxY1M5Wm93UEJManBQS0JPQnRDU1Z1a2gwNTVC?=
 =?utf-8?B?a1I3bDRkR1dkK0podkRDbERqR2lEUVJPTWFWMW0wSEhRL21OODRJMmtjN2hu?=
 =?utf-8?B?L2RjaVQxV3R4OEF0SEp3ZmZqQ0ZTNzlXRWF5bUdlRHd4RnptYis1UU52Q21x?=
 =?utf-8?B?bWlyaTFDV3l6WWZhN1duZkloSjBweVRyR2I3elJDVUZrRWhEYklIN0VNbVMw?=
 =?utf-8?B?VHI1SjZ5V3psNHRHVmIzaElkUU5iUS93RXhad3RoQ3dSRmE2MzJrcUJ6cmNO?=
 =?utf-8?B?b0EvajQydE4wcDJKb2kzazk4RWQydkxZNWJ5bXZ4NDBIWXcyekRHU0JGb2t4?=
 =?utf-8?B?US94MlNqaGs5aEdUaS9OMFNUdkNlTDQ5VzBnZUhyL0xydWVxeXU3WFVXN0I3?=
 =?utf-8?B?djlRRSsxbDNDVkJhQThNV0RLZE5ubldUTldNRTJoQmRvRjl3L2xCM2VmUXo0?=
 =?utf-8?B?cGNxeWZrN1BzQThQWlU4SVZHU2RIbGpTdnFZd3hQcDR3WVZONTBEdzFXU1g3?=
 =?utf-8?B?MERkY1RLNUMza1RmYkRKWjBtRGV4czJlK0RXQXl1S1FzbElYaGhwZXN6K2I1?=
 =?utf-8?B?UUV5WGdQLzIvNGhlSmFzY1EwTFBTNHpMSk1TYVhUbEtiaGUyZDlRMUxtdWsr?=
 =?utf-8?B?MzZNU0NJTXFlK0dWVk9GbGJwTFNKVUQwV29acERONDdZelJhdUpQa3VUd3g2?=
 =?utf-8?B?aW5vTnJVZ2FPZjNTWDJXanhNUUMxYkQvWnQvcW9xYm5ZNERYK2N5WWZjRGl2?=
 =?utf-8?B?cDdMS3pCcy9objVJdDVuWWRuNVdIRWdxZmNqNmozcHZma0NMZDF3MTRYa1kz?=
 =?utf-8?B?TU9EWGFYNFhXbDM2RE5VMi9DZENFVVE3L2c2MGxwWE82Q2N6cXR2UFJLU3J0?=
 =?utf-8?B?TXZ4bkRzNlJjR0FzK2NSL2xGcUh3clRHRGx2akxuTk5yUkdSWmZhMklMZmJC?=
 =?utf-8?B?S1AyRWlvc2k4UkFYdG9pbW1zRjhka3pnMzNVSjVUSkNzT0hLT05paFdDUlRK?=
 =?utf-8?B?YzBDcW12WFp0RVBsZ0lpa2JMdW8rNzZIaE5DMG1HWExoaXoreDJGcGxnNnBr?=
 =?utf-8?B?SSs3YzZKdWNuRXZ2TXZwN3FMSmFnSEhhSnRIVEpvTEY4OFl5dE9DcnIyY3Vp?=
 =?utf-8?B?SmdWMlJ1YVRXTlQxQlZMS1FJd3llVTRkMy9nUWFYTGdhZ3pLZmZ2Sjhzd0NT?=
 =?utf-8?B?aXkvVmpQcDNVZ1lGZCt3UE1kUUVrTGtyZ3Bac25XYnNDMnZOR2EwMHBHUVF5?=
 =?utf-8?B?aEdTWFRyYXhoK1NldjVXTW5UWjRROEFJODZ0djVXZlNTWDlHU085L1FGUjJa?=
 =?utf-8?B?c21KNWVhWmExNWs1d1NmSHZSMDhwRFdub1crMGlicVlaMi9tS2gvSGRvMVov?=
 =?utf-8?B?ZDRQTEtBVElIL05wQnlVOHVaVzh0eTNJd256Tk5mcGYzZk9JckZ0VENFc3Zm?=
 =?utf-8?B?emFaMWF6SlZmS2wzb25kd0dGNEhzSkVQejFMMk9LL3RKa2ZKNFJDN3I2Tmx2?=
 =?utf-8?B?TUNQMDdwR0lTZDhQMU1tNCtGeUI1MW4yR3pHaGdFS3NTSlBjZTJnK0QzMWFq?=
 =?utf-8?Q?xRm8lALu1yHPhJEeZh6TEX3NV?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 4529f1d5-682b-45fa-e621-08dc3d3b117b
X-MS-Exchange-CrossTenant-AuthSource: BN9PR12MB5115.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 17:38:28.6805
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 6fLv9O7H0woLRkGLNLxTCG50QN8MfTJ7Se/BgS5L+MveJMOM/Yvl7ms2DKAfZXXGsobrvaZ2EDwWYlmOpIMzeg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR12MB4343

On 2024-03-05 7:15, Ricardo B. Marliere wrote:
> Since commit 43a7206b0963 ("driver core: class: make class_register() take
> a const *"), the driver core allows for struct class to be in read-only
> memory, so move the kfd_class structure to be declared at build time
> placing it into read-only memory, instead of having to be dynamically
> allocated at boot time.
>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Suggested-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Ricardo B. Marliere <ricardo@marliere.net>

The patch looks good to me. Do you want me to apply this to Alex's 
amd-staging-drm-next?

Reviewed-by: Felix Kuehling <felix.kuehling@amd.com>


> ---
>   drivers/gpu/drm/amd/amdkfd/kfd_chardev.c | 21 +++++++++++----------
>   1 file changed, 11 insertions(+), 10 deletions(-)
>
> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> index f030cafc5a0a..dfa8c69532d4 100644
> --- a/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_chardev.c
> @@ -63,8 +63,10 @@ static const struct file_operations kfd_fops = {
>   };
>   
>   static int kfd_char_dev_major = -1;
> -static struct class *kfd_class;
>   struct device *kfd_device;
> +static const struct class kfd_class = {
> +	.name = kfd_dev_name,
> +};
>   
>   static inline struct kfd_process_device *kfd_lock_pdd_by_id(struct kfd_process *p, __u32 gpu_id)
>   {
> @@ -94,14 +96,13 @@ int kfd_chardev_init(void)
>   	if (err < 0)
>   		goto err_register_chrdev;
>   
> -	kfd_class = class_create(kfd_dev_name);
> -	err = PTR_ERR(kfd_class);
> -	if (IS_ERR(kfd_class))
> +	err = class_register(&kfd_class);
> +	if (err)
>   		goto err_class_create;
>   
> -	kfd_device = device_create(kfd_class, NULL,
> -					MKDEV(kfd_char_dev_major, 0),
> -					NULL, kfd_dev_name);
> +	kfd_device = device_create(&kfd_class, NULL,
> +				   MKDEV(kfd_char_dev_major, 0),
> +				   NULL, kfd_dev_name);
>   	err = PTR_ERR(kfd_device);
>   	if (IS_ERR(kfd_device))
>   		goto err_device_create;
> @@ -109,7 +110,7 @@ int kfd_chardev_init(void)
>   	return 0;
>   
>   err_device_create:
> -	class_destroy(kfd_class);
> +	class_unregister(&kfd_class);
>   err_class_create:
>   	unregister_chrdev(kfd_char_dev_major, kfd_dev_name);
>   err_register_chrdev:
> @@ -118,8 +119,8 @@ int kfd_chardev_init(void)
>   
>   void kfd_chardev_exit(void)
>   {
> -	device_destroy(kfd_class, MKDEV(kfd_char_dev_major, 0));
> -	class_destroy(kfd_class);
> +	device_destroy(&kfd_class, MKDEV(kfd_char_dev_major, 0));
> +	class_unregister(&kfd_class);
>   	unregister_chrdev(kfd_char_dev_major, kfd_dev_name);
>   	kfd_device = NULL;
>   }
>
> ---
> base-commit: 8bc75586ea01f1c645063d3472c115ecab03e76c
> change-id: 20240305-class_cleanup-drm-amd-bdc7255b7540
>
> Best regards,