Received-SPF: pass (google.com: domain of linux-kernel+bounces-92736-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 5 Mar 2024 18:05:58 +0100
From: Jonathan Bergh <bergh.jonathan@gmail.com>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev
Subject: Re: [PATCH 2/2] staging: vme_user: Add a newline after variable
 declarations
Message-ID: <ZedQ9kyNwY+j7Umr@HP-ENVY-Notebook>
References: <20240303100547.153636-1-bergh.jonathan@gmail.com>
 <20240303100547.153636-2-bergh.jonathan@gmail.com>
 <2024030549-sanding-finisher-dc6a@gregkh>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <2024030549-sanding-finisher-dc6a@gregkh>

On Tue, Mar 05, 2024 at 02:13:23PM +0000, Greg KH wrote:
> On Sun, Mar 03, 2024 at 11:05:47AM +0100, Jonathan Bergh wrote:
> > This patch makes the following change:
> >  * Adds a newline after the variable declarations as per checkpatch's
> >    warning
> > 
> > Signed-off-by: Jonathan Bergh <bergh.jonathan@gmail.com>
> > ---
> >  drivers/staging/vme_user/vme_tsi148.h | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/drivers/staging/vme_user/vme_tsi148.h b/drivers/staging/vme_user/vme_tsi148.h
> > index 2a92497c5570..a1b8288b101a 100644
> > --- a/drivers/staging/vme_user/vme_tsi148.h
> > +++ b/drivers/staging/vme_user/vme_tsi148.h
> > @@ -34,6 +34,7 @@ struct tsi148_driver {
> >  	void __iomem *base;	/* Base Address of device registers */
> >  	wait_queue_head_t dma_queue[2];
> >  	wait_queue_head_t iack_queue;
> > +
> >  	void (*lm_callback[4])(void *);	/* Called in interrupt handler */
> >  	void *lm_data[4];
> >  	void *crcsr_kernel;
> 
> Please always look at the change to see if checkpatch is correct or not
> (hint, for this one, it is not.)  Also see the archives for many people
> who have done the same thing in the past :)

Got it, thanks for that. 

> 
> thanks,
> 
> greg k-h