Received-SPF: pass (google.com: domain of linux-kernel+bounces-92804-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <399555e8-d8fa-46b7-8b15-3d3a4a30809b@quicinc.com>
Date: Tue, 5 Mar 2024 23:33:54 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [RFC 3/3] arm64: dts: qcom: sa8775p-ride: Enable support for
 firmware managed resources
Content-Language: en-US
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>,
        <andersson@kernel.org>, <konrad.dybcio@linaro.org>, <vkoul@kernel.org>,
        <kishon@kernel.org>, <robh@kernel.org>,
        <krzysztof.kozlowski+dt@linaro.org>, <conor+dt@kernel.org>,
        <gregkh@linuxfoundation.org>, <quic_wcheng@quicinc.com>,
        <Thinh.Nguyen@synopsys.com>, <p.zabel@pengutronix.de>,
        <linux-arm-msm@vger.kernel.org>, <linux-phy@lists.infradead.org>,
        <linux-kernel@vger.kernel.org>, <linux-usb@vger.kernel.org>,
        <quic_psodagud@quicinc.com>, <quic_nkela@quicinc.com>,
        <manivannan.sadhasivam@linaro.org>, <ulf.hansson@linaro.org>,
        <sudeep.holla@arm.com>, <quic_shazhuss@quicinc.com>
References: <1709657858-8563-1-git-send-email-quic_sriramd@quicinc.com>
 <1709657858-8563-4-git-send-email-quic_sriramd@quicinc.com>
 <b9142874-0afb-40a6-9008-b33bd8f56840@linaro.org>
From: Sriram Dash <quic_sriramd@quicinc.com>
In-Reply-To: <b9142874-0afb-40a6-9008-b33bd8f56840@linaro.org>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit

On 3/5/2024 10:38 PM, Krzysztof Kozlowski wrote:
> On 05/03/2024 17:57, Sriram Dash wrote:
>> Establish the channel and domain mapping for the power domains to connect
>> with firmware, enabling the firmware to handle the assigned resources.
>> Since these delegated resources will remain invisible to the operating
>> system, ensure that any references to them are removed.
>>
>> Signed-off-by: Sriram Dash <quic_sriramd@quicinc.com>
>> ---
>>   arch/arm64/boot/dts/qcom/sa8775p-ride.dts | 96 +++++++++++++++++++++++++------
>>   1 file changed, 77 insertions(+), 19 deletions(-)
> 
> Do not mix DTS patches with submissions to netdev or USB.
> 
> Please put it inside your internal guides, so you will not be repeating
> this over and over.
> 

Sure. Will take care. Thanks.

>>
>> diff --git a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>> index 26ad05b..b6c9cac 100644
>> --- a/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>> +++ b/arch/arm64/boot/dts/qcom/sa8775p-ride.dts
>> @@ -764,8 +764,18 @@
>>   };
>>   
>>   &usb_0 {
>> -	pinctrl-names = "default";
>> -	pinctrl-0 = <&usb0_en_state>;
>> +	/delete-property/ clocks;
>> +	/delete-property/ clock-names;
>> +	/delete-property/ assigned-clocks;
>> +	/delete-property/ assigned-clock-rates;
>> +	/delete-property/ required-opps;
>> +	/delete-property/ resets;
>> +	/delete-property/ interconnects;
>> +	/delete-property/ interconnect-names;
>> +
>> +	power-domains = <TODO>, <TODO>;
> 
> This wasn't even tested.
> 

This is tested with the specific power domains in place
of <TODO>. SCMI interface is used for the power domains.

> Best regards,
> Krzysztof
>