Received-SPF: pass (google.com: domain of linux-kernel+bounces-92855-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Tue, 05 Mar 2024 19:53:52 +0100
Message-Id: <CZM1LPDLQXLP.VVOVCCQPGBOL@gimli.ms.mff.cuni.cz>
Cc: "Rob Herring" <robh+dt@kernel.org>, "Krzysztof Kozlowski"
 <krzysztof.kozlowski+dt@linaro.org>, "Conor Dooley" <conor+dt@kernel.org>,
 "Dmitry Torokhov" <dmitry.torokhov@gmail.com>, "Liam Girdwood"
 <lgirdwood@gmail.com>, "Mark Brown" <broonie@kernel.org>,
 <devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
 <linux-input@vger.kernel.org>, =?utf-8?q?Duje_Mihanovi=C4=87?=
 <duje.mihanovic@skole.hr>, <~postmarketos/upstreaming@lists.sr.ht>,
 <phone-devel@vger.kernel.org>
Subject: Re: [RFC PATCH v3 2/5] mfd: add driver for Marvell 88PM886 PMIC
To: "Lee Jones" <lee@kernel.org>
From: "Karel Balej" <karelb@gimli.ms.mff.cuni.cz>
References: <20240303101506.4187-1-karelb@gimli.ms.mff.cuni.cz>
 <20240303101506.4187-3-karelb@gimli.ms.mff.cuni.cz>
 <20240305114418.GB86322@google.com>
In-Reply-To: <20240305114418.GB86322@google.com>

Lee Jones, 2024-03-05T11:44:18+00:00:
> > +static struct mfd_cell pm886_devs[] =3D {
> > +	{
> > +		.name =3D "88pm886-onkey",
> > +		.num_resources =3D ARRAY_SIZE(pm886_onkey_resources),
> > +		.resources =3D pm886_onkey_resources,
> > +	},
> > +	{
> > +		.name =3D "88pm886-regulator",
> > +		.id =3D PM886_REGULATOR_ID_LDO2,
>
> Why doesn't PLATFORM_DEVID_AUTO work for this device?

Because I am using the IDs in the regulator driver to determine which
regulator data to use/which regulator to register.

> > +static int pm886_initialize_subregmaps(struct pm886_chip *chip)
> > +{
> > +	struct device *dev =3D &chip->client->dev;
> > +	struct i2c_client *page;
> > +	struct regmap *regmap;
> > +	int err;
> > +
> > +	/* regulators page */
> > +	page =3D devm_i2c_new_dummy_device(dev, chip->client->adapter,
> > +				chip->client->addr + PM886_PAGE_OFFSET_REGULATORS);
> > +	if (IS_ERR(page)) {
> > +		err =3D PTR_ERR(page);
> > +		dev_err(dev, "Failed to initialize regulators client: %d\n", err);
> > +		return err;
> > +	}
> > +	regmap =3D devm_regmap_init_i2c(page, &pm886_i2c_regmap);
> > +	if (IS_ERR(regmap)) {
> > +		err =3D PTR_ERR(regmap);
> > +		dev_err(dev, "Failed to initialize regulators regmap: %d\n", err);
> > +		return err;
> > +	}
> > +	chip->regmaps[PM886_REGMAP_REGULATORS] =3D regmap;
>
> Except for the regulator driver, where else is the regulators regmap used=
?

Nowhere, at least as of now. So you are saying that I should initialize
the regmap in the regulator driver?

Thank you,
K. B.