Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp647650lqs; Tue, 5 Mar 2024 12:03:00 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCVtl0jcYtgS7h0jw1wxwJLLN0ZfEMGgb5fiJ1+1sc8wb/iHkbp7Pzuodz3RLES6AvWHwi2rAorJOKLf4TJ1PC5Ndb+6M7OBYHrBSUwBbw== X-Google-Smtp-Source: AGHT+IHLskmQWVPBz/2IonPyTqLnlDCCelTvwlDcOz69Ahe6d9LxbXbzqfA9DLRlDe/UX4NyAWsA X-Received: by 2002:ac8:5881:0:b0:42e:ba41:3426 with SMTP id t1-20020ac85881000000b0042eba413426mr3236326qta.55.1709668979894; Tue, 05 Mar 2024 12:02:59 -0800 (PST) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id t17-20020ac85891000000b0042ef23d0412si5494842qta.365.2024.03.05.12.02.59 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 12:02:59 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-92922-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=fail header.i=@kernel.org header.s=k20201202 header.b=Xc5tbXzh; arc=fail (signature failed); spf=pass (google.com: domain of linux-kernel+bounces-92922-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-92922-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 42EF61C27DA3 for ; Tue, 5 Mar 2024 20:01:10 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 72F9F12A173; Tue, 5 Mar 2024 20:00:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Xc5tbXzh" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8F9591272CC; Tue, 5 Mar 2024 20:00:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709668833; cv=none; b=kH1G1CNh1xEDq1Uc7Iy6FCJdfu1GQ6VANCpIPq3FnQnGYoNR/ojVqSXsQgdZTKdLFdNFSlQRqi607ZMNBwVTHDf48ePHeV9akuarcSoJguTRZCc4njAiIdPpPLBvLRiKPAfxXxw1NHXkN7Chl2X/DNrDl3ZIlcFRnwXSVhwsp+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709668833; c=relaxed/simple; bh=9xBvEf4prS3iut14em+VSKNMOHTjGO6VQ6nZWv1dzq8=; h=Content-Type:MIME-Version:Subject:From:Message-Id:Date:References: In-Reply-To:To:Cc; b=JHgNcVgAateU6NhNQiutmfxipOjg1Kv+3Vw7PghvwXGSxyWPlCPJGcAHoOPgZFlzPiEbMc4Q6AD8fgYmrOPppuHlmhhSX4qiF3q38Q95lWozCA71tBAUOifEajUTantiW4RXfY79GqJmBGT4XOAPke0qirA4ISYXUmQnffZnmnk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Xc5tbXzh; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPS id 135D2C433C7; Tue, 5 Mar 2024 20:00:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709668833; bh=9xBvEf4prS3iut14em+VSKNMOHTjGO6VQ6nZWv1dzq8=; h=Subject:From:Date:References:In-Reply-To:To:Cc:From; b=Xc5tbXzhOvIdwKDJGbcuseVY0UFx2FRbeuxTR9M2TeYJmbH+qw2KSQuGp3BklOm7l SKtLUoNAgDxcX7JDD0WMyyFpc3+2iCRtVQ+GGICrfocySJkOD+EokME1xP09rCaQ3E 5D7mPWU6DKY2Cxmz9NyEhD8EaPxjHG7iMTkqYwdG93d+/z63j767EcW8D/ewFa8UzM wkVVKdD/0/f5VczSZF09yoq3YOhofmz0/jDhkLcMwiioi3gQgM0HoOk4tW1Jz1/NlR FkhhjuDzz1+3DuQtE/Xcr4QAuG7Nd12DS1+/JKZKatSWNU9INFe14ZkXRD6HIqMfSu 4a5OVovToZ0AQ== Received: from aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (localhost.localdomain [127.0.0.1]) by aws-us-west-2-korg-oddjob-1.ci.codeaurora.org (Postfix) with ESMTP id EB81AD88F81; Tue, 5 Mar 2024 20:00:32 +0000 (UTC) Content-Type: text/plain; charset="utf-8" Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Subject: Re: [PATCH] ptp: fc3: Convert to platform remove callback returning void From: patchwork-bot+netdevbpf@kernel.org Message-Id: <170966883295.18762.14661053302967043118.git-patchwork-notify@kernel.org> Date: Tue, 05 Mar 2024 20:00:32 +0000 References: <20240304091325.717546-2-u.kleine-koenig@pengutronix.de> In-Reply-To: <20240304091325.717546-2-u.kleine-koenig@pengutronix.de> To: =?utf-8?q?Uwe_Kleine-K=C3=B6nig_=3Cu=2Ekleine-koenig=40pengutronix=2Ede=3E?=@codeaurora.org Cc: richardcochran@gmail.com, min.li.xe@renesas.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Hello: This patch was applied to netdev/net-next.git (main) by Jakub Kicinski : On Mon, 4 Mar 2024 10:13:25 +0100 you wrote: > The .remove() callback for a platform driver returns an int which makes > many driver authors wrongly assume it's possible to do error handling by > returning an error code. However the value returned is ignored (apart > from emitting a warning) and this typically results in resource leaks. > > To improve here there is a quest to make the remove callback return > void. In the first step of this quest all drivers are converted to > .remove_new(), which already returns void. Eventually after all drivers > are converted, .remove_new() will be renamed to .remove(). > > [...] Here is the summary with links: - ptp: fc3: Convert to platform remove callback returning void https://git.kernel.org/netdev/net-next/c/60d06425e045 You are awesome, thank you! -- Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html