Received-SPF: pass (google.com: domain of linux-kernel+bounces-92937-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Tue, 5 Mar 2024 20:10:08 +0000
From: Conor Dooley <conor@kernel.org>
To: =?iso-8859-1?Q?J=E9r=E9mie?= Dautheribes <jeremie.dautheribes@bootlin.com>
Cc: "David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@google.com>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>, Andrew Davis <afd@ti.com>,
	Andrew Lunn <andrew@lunn.ch>, netdev@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	Yen-Mei Goh <yen-mei.goh@keysight.com>,
	=?iso-8859-1?Q?Miqu=E8l?= Raynal <miquel.raynal@bootlin.com>
Subject: Re: [PATCH RESEND net-next] dt-bindings: net: dp83822: change
 ti,rmii-mode description
Message-ID: <20240305-jawless-lingo-7a4261a2ba89@spud>
References: <20240305141309.127669-1-jeremie.dautheribes@bootlin.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="GEeM/2SHVlkuMks1"
Content-Disposition: inline
In-Reply-To: <20240305141309.127669-1-jeremie.dautheribes@bootlin.com>


--GEeM/2SHVlkuMks1
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 05, 2024 at 03:13:09PM +0100, J=E9r=E9mie Dautheribes wrote:
> Drop reference to the 25MHz clock as it has nothing to do with connecting
> the PHY and the MAC.
> Add info about the reference clock direction between the PHY and the MAC
> as it depends on the selected rmii mode.
>=20
> Suggested-by: Andrew Lunn <andrew@lunn.ch>
> Signed-off-by: J=E9r=E9mie Dautheribes <jeremie.dautheribes@bootlin.com>

This feels like it should have a Fixes: tag.
Otherwise
Acked-by: Conor Dooley <conor.dooley@microchip.com>

Cheerrs,
Conor.

> ---
> This patch follows on from my previous patch series [1] which has already=
 been=20
> merged into the net-next tree and which added the "ti,rmii-mode" property.
> As suggested by Andrew Lunn, this patch updates the description of this=
=20
> property to make it more consistent with the master/slave relationship it=
=20
> conveys.
>=20
> [1] https://lore.kernel.org/all/20240222103117.526955-1-jeremie.dautherib=
es@bootlin.com/
>=20
> Resending because I previously forgot to include the "net-next" entry in=
=20
> the email subject.
>=20
>  Documentation/devicetree/bindings/net/ti,dp83822.yaml | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>=20
> diff --git a/Documentation/devicetree/bindings/net/ti,dp83822.yaml b/Docu=
mentation/devicetree/bindings/net/ti,dp83822.yaml
> index 8f23254c0458..784866ea392b 100644
> --- a/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> +++ b/Documentation/devicetree/bindings/net/ti,dp83822.yaml
> @@ -84,10 +84,10 @@ properties:
>      description: |
>         If present, select the RMII operation mode. Two modes are
>         available:
> -         - RMII master, where the PHY operates from a 25MHz clock refere=
nce,
> -         provided by a crystal or a CMOS-level oscillator
> -         - RMII slave, where the PHY operates from a 50MHz clock referen=
ce,
> -         provided by a CMOS-level oscillator
> +         - RMII master, where the PHY outputs a 50MHz reference clock wh=
ich can
> +         be connected to the MAC.
> +         - RMII slave, where the PHY expects a 50MHz reference clock inp=
ut
> +         shared with the MAC.
>         The RMII operation mode can also be configured by its straps.
>         If the strap pin is not set correctly or not set at all, then thi=
s can be
>         used to configure it.
> --=20
> 2.34.1
>=20
>=20

--GEeM/2SHVlkuMks1
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZed8IAAKCRB4tDGHoIJi
0n1lAQC/lciR2GVw8GYCLkEiSQmmwwa+9Kmk4x3SGxsDXf90pgEAmN5UV+eCjr+5
3rhpbgfvWocWrxJve288DQcOaYDSKgY=
=4+n1
-----END PGP SIGNATURE-----

--GEeM/2SHVlkuMks1--