Received-SPF: pass (google.com: domain of linux-kernel+bounces-92972-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: David Thompson <davthompson@nvidia.com>
To: Jakub Kicinski <kuba@kernel.org>
CC: "davem@davemloft.net" <davem@davemloft.net>, "edumazet@google.com"
	<edumazet@google.com>, "pabeni@redhat.com" <pabeni@redhat.com>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Asmaa Mnebhi
	<asmaa@nvidia.com>
Subject: RE: [PATCH net-next v1] mlxbf_gige: add support to display pause
 frame counters
Thread-Topic: [PATCH net-next v1] mlxbf_gige: add support to display pause
 frame counters
Thread-Index: AQHabxB4RB2Az1LWjUel7zzqlypQjLEpeXOAgAAiepA=
Date: Tue, 5 Mar 2024 20:40:11 +0000
Message-ID:
 <DM6PR12MB553455E2ABC9C8FFE2D324B1C7222@DM6PR12MB5534.namprd12.prod.outlook.com>
References: <20240305151851.533-1-davthompson@nvidia.com>
 <20240305103443.70e1f619@kernel.org>
In-Reply-To: <20240305103443.70e1f619@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?SOYEP7cp0cT/v2YsvKB8+Yk/WLRV7ZomeW+3lb9QQjg5I2gTOiS3MbEaCaDv?=
 =?us-ascii?Q?za7Wdy3RDoJcD4MtDzld6J0sAcawvt18NGD1wQxo4Lipg9t8I5mLWAopLiM0?=
 =?us-ascii?Q?5boRSRhDW9xgNo1+J/11BsGLwdFbchpaL23v2URvk+ALh757laCGZ66Vxfth?=
 =?us-ascii?Q?UZRX5Ib3DppwvAmuVinCFATInlV+UX7I9VYV1ew7+roIJREDhyqILDCG6UW5?=
 =?us-ascii?Q?shHDVkBMJhIJYCF5xLJ8w8tg00qAFXsFg5CQKyT5qcXrLHZooS9SnWd66GOr?=
 =?us-ascii?Q?xetNzmwb+/+sHiPROu9ULLLajEQO8G/XGJECKbrL8t63d9ftmUbqeIDa8uYC?=
 =?us-ascii?Q?L+m7EJAmNmirLGPWE0fdUgs8jFFGlVF1CvuKcP+Lz0uaNSQ/miUxAah+uDKr?=
 =?us-ascii?Q?LajaqITcp9GRl1/y2sfTf+eUBCQyNFQxy3TRjsvTBPJnotRyJWM3EiGv88dw?=
 =?us-ascii?Q?AiAsptATgWUhhe78CouUlsCbZYQFdLzGJeTejdHANir+dOMnAQLFgqQW9BRl?=
 =?us-ascii?Q?XVJp8MEEJ0t1PdGFPehpqc5c1LeJA3lMfyJUBzoxAh92R5fIdfV2kJJetpJv?=
 =?us-ascii?Q?56Ty8ygrjJGg+CimkKSOVYKROXYK/jArgls8KDRmz+oVt9GAOj9/4JO5Ya6w?=
 =?us-ascii?Q?lqm2VyNJwbz5EZwddgnjALsOoJjk3R8ME2D6SGSZXbBSTw0fTPGGF+G+jCaq?=
 =?us-ascii?Q?4nF3/ZpHZ3PMCRPal2ZgULmlbNkl7fvGtUyfN0eLtNAGWB/qCahVZooYTDxV?=
 =?us-ascii?Q?uTF4qfsKwBElbVrXHdBZHwHipuimnxijNS30OTLOc3kNn/5bR4LxdX3mBN9w?=
 =?us-ascii?Q?yYNZ0VpFmdYxPgA1GTOdst/hd4fQRF2CVwl3TIzdYG9xdwIPhcG82SBWvE9T?=
 =?us-ascii?Q?kA9YZldpRotyH4z1cexelAVVyLwTjoQ843kA6FX1olH69LcFjRT4hHVOcwG4?=
 =?us-ascii?Q?RA6Yur46GYG62Cxr7uvJ0BG9UCZNT2j2k2tgWvFq+ydqGKaDnpk5TX2OuJIf?=
 =?us-ascii?Q?T7Jjpg0nHL1Uxxutt4pTuIsZY7+8FRbJKe9bOcTqhXQYAHjml+VBXq6TWLE8?=
 =?us-ascii?Q?oJGChP0IEetfE1COxrVwAsNVBO4b/jyV44KuoWAQeEnZPx26cywevMSNWcm5?=
 =?us-ascii?Q?fIHCbU+ckT1ujK7K2DvJhhAuYFxhEW9bDntic0gqrJlrPoAqVs2Ag6l7e0RV?=
 =?us-ascii?Q?VKI3W8DHt05vOiOLqtR2vTB+7WGpOZNzQ7RWRh3ScgBKCUknFq3dCs1LiUfl?=
 =?us-ascii?Q?JpfbO2NGifvbzwmUNh18x4e/JuLW2xeEQAcxRaDEpeOQoRhf6d8ATSG89rEy?=
 =?us-ascii?Q?aCqfjAUMvShFlyXE7lB9tDLcY19lzD0KX8jSAd40R9zjVZow9W/3GXLrb/mQ?=
 =?us-ascii?Q?kftp8b32oLH9124gUOFhUdDIgHuC1Gtg8mcjFOZGPzANAeF72sYzJXf5Scu3?=
 =?us-ascii?Q?AraNYIRorej7E/7OYr6o15ByI/ANmveUqbOYG9cVcGwjYudCHc5yP/MT5QLT?=
 =?us-ascii?Q?xclozhYra5uVkDv5U3Ipma8yGJzm4XdgVn4Z4FMs1+PNMrWw7g2mZtPpKkfY?=
 =?us-ascii?Q?aZOeyMTw0dvJnQBiad2YiWaqSN/Q9y0StRlm/mlzW0w3DEKxUpA0XdXDVBtF?=
 =?us-ascii?Q?BmSJzqEVYLihEPH/xezp9wyTKlUMnqOpY1dqwAslDnaX?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-kernel@vger.kernel.org
List-Id: <linux-kernel.vger.kernel.org>
List-Subscribe: <mailto:linux-kernel+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-kernel+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB5534.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: f6f73830-dc20-4a24-ad79-08dc3d547474
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Mar 2024 20:40:12.0060
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: BDGzi5Z9wlrY8jiqHliBmVManFkAJmz3eHfgxO8DFPaPcmZXMoWYXowdV38sirz9kuC7OgRIcnau1ZZc1vKcQQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH8PR12MB7301

> -----Original Message-----
> From: Jakub Kicinski <kuba@kernel.org>
> Sent: Tuesday, March 5, 2024 1:35 PM
> To: David Thompson <davthompson@nvidia.com>
> Cc: davem@davemloft.net; edumazet@google.com; pabeni@redhat.com;
> netdev@vger.kernel.org; linux-kernel@vger.kernel.org; Asmaa Mnebhi
> <asmaa@nvidia.com>
> Subject: Re: [PATCH net-next v1] mlxbf_gige: add support to display pause=
 frame
> counters
>=20
> On Tue, 5 Mar 2024 10:18:51 -0500 David Thompson wrote:
> > +	/* Read LLU counters only if they are enabled */
> > +	if (mlxbf_gige_llu_counters_enabled(priv)) {
> > +		data_lo =3D readl(priv->llu_base +
> MLXBF_GIGE_TX_PAUSE_CNT_LO);
> > +		data_hi =3D readl(priv->llu_base +
> MLXBF_GIGE_TX_PAUSE_CNT_HI);
> > +		pause_stats->tx_pause_frames =3D (data_hi << 32) | data_lo;
> > +
> > +		data_lo =3D readl(priv->llu_base +
> MLXBF_GIGE_RX_PAUSE_CNT_LO);
> > +		data_hi =3D readl(priv->llu_base +
> MLXBF_GIGE_RX_PAUSE_CNT_HI);
> > +		pause_stats->rx_pause_frames =3D (data_hi << 32) | data_lo;
> > +	} else {
> > +		pause_stats->tx_pause_frames =3D 0;
> > +		pause_stats->rx_pause_frames =3D 0;
>=20
> Counters are not enabled, meaning we don't know how many frames were sent=
?
> Or pause frames are not enabled, therefore we know it's 0?
>=20
> If the latter we should add a comment clarifying that, if the former:
>=20
>  * @get_pause_stats: Report pause frame statistics. Drivers must not zero
>  *	statistics which they don't report. The stats structure is initialized
>  *	to ETHTOOL_STAT_NOT_SET indicating driver does not report statistics.
> --
> pw-bot: cr

Hi Jakub, thank you for your comments.

In this case it's the former, so pause frames are enabled we just don't kno=
w how
many are sent or received.  I will update the driver patch accordingly and =
send v2.

Regards, Dave