Received-SPF: pass (google.com: domain of linux-kernel+bounces-93020-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <75adc31d-6632-4ea1-8191-dad1659e7b33@intel.com>
Date: Wed, 6 Mar 2024 10:35:43 +1300
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v19 008/130] x86/tdx: Warning with 32bit build
 shift-count-overflow
Content-Language: en-US
To: Isaku Yamahata <isaku.yamahata@linux.intel.com>, "Kirill A. Shutemov"
	<kirill.shutemov@linux.intel.com>
CC: <isaku.yamahata@intel.com>, <kvm@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <isaku.yamahata@gmail.com>, Paolo Bonzini
	<pbonzini@redhat.com>, <erdemaktas@google.com>, Sean Christopherson
	<seanjc@google.com>, Sagi Shahar <sagis@google.com>, <chen.bo@intel.com>,
	<hang.yuan@intel.com>, <tina.zhang@intel.com>
References: <cover.1708933498.git.isaku.yamahata@intel.com>
 <a50918ba3415be4186a91161fe3bbd839153d8b2.1708933498.git.isaku.yamahata@intel.com>
 <2f6897c0-1b57-45b3-a1f1-9862b0e4c884@intel.com>
 <jvyz3nuz225ry6ss6hs42jyuvrytsnsi2l74cwibtt5sedaimb@v2vilg4mbhws>
 <20240305081219.GC10568@ls.amr.corp.intel.com>
From: "Huang, Kai" <kai.huang@intel.com>
In-Reply-To: <20240305081219.GC10568@ls.amr.corp.intel.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VHhMaVAyYyttV3lwZjJtNnI1cFRuRHFrdlAxYkVHME1iNVNnd3lMNlAvTUpM?=
 =?utf-8?B?TGNZSlo0Z0hkWDhHL1Qwa3BBNjVCMTZhRGs4N2V5UTlnT0F2MGs4aUZpcFBD?=
 =?utf-8?B?dkczM2RSenFkQjV6Z2ZkSnQ4VWs1V1FuSXo3Q1ptR0FTbGpqUThrTmE0SzdE?=
 =?utf-8?B?NGEzbGtVakxCQWNaa1hwd0dXMkRPOEFyQzBGa0VwdU1NdkxtVGVvZ3pqR1hE?=
 =?utf-8?B?NStzMUlIb0cvNkxKVVlKMDJMcUR1YU9CMy9WT0F2TzBOWWI2Y0xlK0pHMWlj?=
 =?utf-8?B?a2JSbytRa1lmaXdqR21nNllLaFZNSC9IdWtQNkFrelhiZmt6aXVvTXNmYm1i?=
 =?utf-8?B?RDBVV1hWaFNmODk2ekxWSDBYK0ZnczZib3RyREtiUS9XeHRscy9ubGlTNVUz?=
 =?utf-8?B?S2V1dXN1VHc5dCtKRlNIWnVWdmpyMXp3OUkrMWZTdjhWNVVyWkhOY0N3RGxt?=
 =?utf-8?B?eXRRSTIwZXB2SjNxdzZzQk9Vbm9GcGNINjZKeXRlaUd0RDNxNEFnODBSVFI0?=
 =?utf-8?B?MXZjMG1kOUZpRlk5QUxpYnJQV2ttamIxa0NOSnNGWE1Jc3BjSy9ORTlFKzhm?=
 =?utf-8?B?MG9tenRlZDR2S0ZNNGdMeWdlZU10RDlqbFZMYWYySHNmQUxocGN6THd6ck13?=
 =?utf-8?B?Rktabk56eW5QanhVMXRIdmdodUxqaUtoeUt1Y2R1T04vSnpnWExmTVZzRXoy?=
 =?utf-8?B?RHpkWmpuWE4wOXNUTFRtVTF6bUp5VnFyR0ZzNmtRaFZReG12N0RWb1NRN0Nq?=
 =?utf-8?B?L0V3WWZOVWtqR2FBQm9WNWdlbmdxU3VTUWgvSXN2WUZwNjZuMGxYVWwwaEVU?=
 =?utf-8?B?c2JONlBtTWVUOWNVbkluaFlVc0lrT3Q0WlcwcFcyeEpVUnJGS0Erem9yeTZH?=
 =?utf-8?B?Sk9FNXVOM3B1WXhLUCtLT083MUxMR3Q4K3gzcThhdXdzTUwvODJTcUtMVTdL?=
 =?utf-8?B?QW55Vld5Y1U5dE9SMStMVk9kb0FNOW1SSmRGOHVJT1VVMjFjVmZuZmF6RWhY?=
 =?utf-8?B?Z2h4QzNwQTl0V3Jtc1FzVEdSNHNFK3hvcmpKaUtYckFkaEhZcWlWU0ZpMEtL?=
 =?utf-8?B?NVF5Wmc0T0J6Y3lwWDU5Wmdxd2FvdmtVbmxtcGpwcVJMa202eFp1TlgvQ01a?=
 =?utf-8?B?QnBJa1dBcm0vZVBzaE83Um5jS1J0YVpSK3F3MnBzQTFKUFdieHNlbnlmcHV1?=
 =?utf-8?B?UEl2QU1KMzlVc0pVRWkwYTdoUUd0azlvajRqaGgvTmNiQkVLYjRhd1Q1QVNU?=
 =?utf-8?B?QzdiOEhTMzdjMjJhVUdwWUM1Ynk2VmdsZ3lEU3M0SFJ4VEFtd2NqUjFHMEpu?=
 =?utf-8?B?QWdiSGpZS1dUVi84Q0xWc1ZWcUlsekc1RCs0N1BpWnNuODJXZGRyVkVhYk9J?=
 =?utf-8?B?eHY2dEhJVmhDYlRjMDhsT2ZjMUV0WHB6UGxOZ1doMnhNQ0JVck02bm9uSkRz?=
 =?utf-8?B?UU5JTHdNVjFpL0lsSE5OQ1J4bjd6VFVkOFlVbTM1dVdjZGEvaHZ2ZGMrWStk?=
 =?utf-8?B?NnVORi9DOVhtN0YvU1k1TUdpZUVZN0hIWGs1ajdaNXdSZy9QaHlBajJZTkx3?=
 =?utf-8?B?SUE4N2w2dUtrb2FvUGhvUkRXWjE3UnBvdjJoNEphaXh4cE83VHZKbTB0dTZy?=
 =?utf-8?B?OHYxVjhmbllDOWNVVEhyUlZndEYyWVMxUjMzZk5lbGJ5Z1QvcEdkdDFtbUlT?=
 =?utf-8?B?RHZleXljS0NKb2RZVDRKRzNrdk4xZXRNaXBSeERkWkRhOVlQNFBPS2hGZXBT?=
 =?utf-8?B?cHZtdjc1SEx2aGxaZmtySzh3aDJtVmhjeFQ4em1FR1gvRldvVGtZNDErdCtZ?=
 =?utf-8?B?dXhMMjNmbE9pdnd3ckdkZGJzYmMvMzZLVjgzZ1c5RmJlMTZFT3A1VG9mVVJr?=
 =?utf-8?B?dlp0aGQ3UGFsYWhyMFJ1Smk0Qml0clh0WmR3cGpXdldxTFhBazVTaHZ6ZDQz?=
 =?utf-8?B?dFBaSGczMXJ3UUFuSjc1UFNCZzhpNzltaGxYNXllNVZ2YW1uOGJVa0U1U0p1?=
 =?utf-8?B?eWJxRDRFYlF4bWN2V0JLaTFIbjJkMDNTT0YwQks1RWp4Z2ZHRUtRajAvdWx4?=
 =?utf-8?B?eXEwc3diNTFaMkc5QkRmazhsNVFmYVhrM0dWR0kremkxR3hmRUZPbTI2NUNY?=
 =?utf-8?Q?NdGaKJr/pOw90Ecj87xhPh1Os?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 68c7e238-f215-4686-0483-08dc3d5c3b79
X-MS-Exchange-CrossTenant-AuthSource: BL1PR11MB5978.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Mar 2024 21:35:52.5466
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: qwtxV7L5MDfsAn/C6aFYqUuGu1X6Zjthx0eYykp5qPqdJzG8TOry7Lhl0NFRcfjGbzNv+DOtibgy/eFRSdxbuw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7572
X-OriginatorOrg: intel.com


On 5/03/2024 9:12 pm, Isaku Yamahata wrote:
> On Fri, Mar 01, 2024 at 01:36:43PM +0200,
> "Kirill A. Shutemov" <kirill.shutemov@linux.intel.com> wrote:
> 
>> On Thu, Feb 29, 2024 at 11:49:13AM +1300, Huang, Kai wrote:
>>>
>>>
>>> On 26/02/2024 9:25 pm, isaku.yamahata@intel.com wrote:
>>>> From: Isaku Yamahata <isaku.yamahata@intel.com>
>>>>
>>>> This patch fixes the following warnings.
>>>>
>>>>      In file included from arch/x86/kernel/asm-offsets.c:22:
>>>>      arch/x86/include/asm/tdx.h:92:87: warning: shift count >= width of type [-Wshift-count-overflow]
>>>>      arch/x86/include/asm/tdx.h:20:21: note: expanded from macro 'TDX_ERROR'
>>>>      #define TDX_ERROR                       _BITUL(63)
>>>>
>>>>                                              ^~~~~~~~~~
>>>>
>>
>> I think you trim the warning message. I don't see the actual user of the
>> define. Define itself will not generate the warning. You need to actually
>> use it outside of preprocessor. I don't understand who would use it in
>> 32-bit code. Maybe fixing it this way masking other issue.
>>
>> That said, I don't object the change itself. We just need to understand
>> the context more.
> 
> v18 used it as stub function. v19 dropped it as the stub was not needed.

Sorry I literally don't understand what you are talking about here.

Please just clarify (at least):

  - Does this problem exist in upstream code?
  - If it does, what is the root cause, and how to reproduce?