Received-SPF: pass (google.com: domain of linux-kernel+bounces-93057-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
MIME-Version: 1.0
References: <20240305143859.2449147-1-andre.przywara@arm.com>
In-Reply-To: <20240305143859.2449147-1-andre.przywara@arm.com>
From: Linus Walleij <linus.walleij@linaro.org>
Date: Tue, 5 Mar 2024 23:30:02 +0100
Message-ID: <CACRpkdYnFrB87T9Pq_kFDL_x399haA1n2hxPN0aSYO=KQSQQ6g@mail.gmail.com>
Subject: Re: [PATCH] pinctrl: pinmux: Suppress error message for -EPROBE_DEFER
To: Andre Przywara <andre.przywara@arm.com>
Cc: linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org, 
	linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 5, 2024 at 3:39=E2=80=AFPM Andre Przywara <andre.przywara@arm.c=
om> wrote:

> EPROBE_DEFER error returns are not really critical, since they cancel
> the probe process, but the kernel will return later and retry.
> However, depending on the probe order, this might issue quite some
> verbatim and scary, though pointless messages:
>
> [    2.388731] 300b000.pinctrl: pin-224 (5000000.serial) status -517
> [    2.397321] 300b000.pinctrl: could not request pin 224 (PH0) from grou=
p PH0  on device 300b000.pinctrl
>
> Replace dev_err() with dev_err_probe(), which not only drops the
> priority of the message from error to debug, but also puts some text
> into debugfs' devices_deferred file, for later reference.
>
> Signed-off-by: Andre Przywara <andre.przywara@arm.com>

That does cut a lot of noise.

Patch applied!

Yours,
Linus Walleij