Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp721644lqs; Tue, 5 Mar 2024 14:42:40 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCW5XTO+oM+irVRvyKhR2qJ1kGcwdmJ6X9vg0FtGlqAKRBD9f0XEp+MG2FEH/xfvE+Sabw1tB57afus1ZBNjIvrdeHs/AcEqjaVVEPRmvw== X-Google-Smtp-Source: AGHT+IGY96Z0CvUvKoQAJb4sPSbRXWdQfS4vjZO/TYdGveu8eBwd6nMsSXj1KmXa7wYpMsu4+Btd X-Received: by 2002:a05:6214:2ccf:b0:690:8fa4:fadd with SMTP id lf15-20020a0562142ccf00b006908fa4faddmr2129025qvb.20.1709678560008; Tue, 05 Mar 2024 14:42:40 -0800 (PST) Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [147.75.199.223]) by mx.google.com with ESMTPS id u11-20020ad45aab000000b006903c84408fsi13467786qvg.448.2024.03.05.14.42.39 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 14:42:39 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223; Authentication-Results: mx.google.com; dkim=neutral (body hash did not verify) header.i=@linaro.org header.s=google header.b=Uz30EHnX; arc=fail (body hash mismatch); spf=pass (google.com: domain of linux-kernel+bounces-93062-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93062-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id B616F1C24DDB for ; Tue, 5 Mar 2024 22:42:39 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 3432D12BEAA; Tue, 5 Mar 2024 22:42:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Uz30EHnX" Received: from mail-yb1-f172.google.com (mail-yb1-f172.google.com [209.85.219.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E18551DFC6 for ; Tue, 5 Mar 2024 22:42:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.219.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709678547; cv=none; b=TxBPvod0JTfWnfw/i67eSDXp9C+3pJUuqW74pBM+EbCZ/vKRbBefD+Ie41ziJoAvIS75yXR8OffmxaHKbnVgQ6K68qDYaTPmgx4P95oIUUsVYBUFyyl/klQ7XdfY54+ILG4XT7A6P1VqmcRG5UfHa10heP63Frziay0JxQ+BJKg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709678547; c=relaxed/simple; bh=Kla2R5bcfkPkylWdIGVABjeBtsnshT/GLsxGridt7Qg=; h=MIME-Version:References:In-Reply-To:From:Date:Message-ID:Subject: To:Cc:Content-Type; b=SaQRJVqTCtXz8sKKTbyeOmaiMSQ5capVoWWVdp70X6AevAOU9enSWycr8kXJ6JL67LFr+F7IPhkxcVa656IUiXTZtJ00rNNTc/yO+4LMO/Uu/+H4bltNd5kp5dcx3SMq5T6+jkUJIjgGcKmXzEQZUfOKkMvptJwMnxazBrJYNpo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Uz30EHnX; arc=none smtp.client-ip=209.85.219.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Received: by mail-yb1-f172.google.com with SMTP id 3f1490d57ef6-d9b9adaf291so5676244276.1 for ; Tue, 05 Mar 2024 14:42:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1709678545; x=1710283345; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=Kla2R5bcfkPkylWdIGVABjeBtsnshT/GLsxGridt7Qg=; b=Uz30EHnXgL4NUZASHqK/PqkK5NhT//dXPGTvlHs7BxPo7ZOaCovK3EzbxEDFbuZJjm S5ty8ErsqAnztmN482V87In5Erc6Hw+UalRdKuoI9Kg92qUzSsnCgPIU28qsBiPl2++a SG1Dtcjzk6ZGRdPauq1AziXSfAUHaIX9/Q3508lPGUEp66+RS0uzLYkUzqmDMQV8QN7Q BjK95qtF1S6phqRoqx6qbmldzN8/MVxnCbmm838W+xPKh/gwkIKWRY3/l/HprpGQ1SFa PbAkqzarbWLbSG9JPkjiGe+ovVPCYP8fPYaE4vDYqbqE4sRJ8DyEt4WEIT07NOmrUz0C nW9A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1709678545; x=1710283345; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Kla2R5bcfkPkylWdIGVABjeBtsnshT/GLsxGridt7Qg=; b=V3IuEsnTgQ4F/XFm7/s+MNWEKBZ5EXlpMn8xjtBC2j7t+WG8fz58LztnixVqsHehpw NCTZt+wN//9VLZFNypKEa+BbaTORhr9/h9q9WpWDPxHLX1e2nwPiaXF0yEBNysUm4EVt kmBegp+NzTHNoB3Z9ZRAIoH11R/P40a/mehCreAEM+E+tTQDfhCX9sjDlMQqtCoS/ERs HWwAGvzT1+t+K+Wg7+wDci+WVV3II0gV1X2MWuCPV8C1nNBZHJ7u94t7wPi8no7GLQqr 3pkmSH2DrK2krWkTfWrwZYJXJvVWQB46FI+SxWA3RhfK6autMTHBvNtd6G9k90e/eZjm EjzQ== X-Forwarded-Encrypted: i=1; AJvYcCVMO9kfiUCdvgM55DIT7qli62WW49fB0ITvt/oW3T6IghiIbEz+9MipzWDm/Glh01R7emO3x0rpRIINs05NXktGYxTpxjqqeLLCKk4V X-Gm-Message-State: AOJu0Yz0KKcwmTuqdiD/MxzrC2k20Fv1SjmNiCq729W1I2KtgAHAM0Z5 o/FiWZHg6dgVpoSeL9ozoIRWAFU2gEj6xJOr8PXHQFADNBUw4ECEuf8rPJeJ59vjKqW3IyQFx/1 oSYtSjiybJAdl8NZrQZQHnOkH/33SDerSP0AX3Q== X-Received: by 2002:a25:9845:0:b0:dcd:df0:e672 with SMTP id k5-20020a259845000000b00dcd0df0e672mr9528207ybo.47.1709678544834; Tue, 05 Mar 2024 14:42:24 -0800 (PST) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 References: <20240301221641.159542-1-paweldembicki@gmail.com> <20240301221641.159542-7-paweldembicki@gmail.com> In-Reply-To: <20240301221641.159542-7-paweldembicki@gmail.com> From: Linus Walleij Date: Tue, 5 Mar 2024 23:42:14 +0100 Message-ID: Subject: Re: [PATCH net-next v6 06/16] net: dsa: vsc73xx: add port_stp_state_set function To: Pawel Dembicki Cc: netdev@vger.kernel.org, Simon Horman , Andrew Lunn , Florian Fainelli , Vladimir Oltean , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Claudiu Manoil , Alexandre Belloni , UNGLinuxDriver@microchip.com, Russell King , linux-kernel@vger.kernel.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Mar 1, 2024 at 11:17=E2=80=AFPM Pawel Dembicki wrote: > This isn't a fully functional implementation of 802.1D, but > port_stp_state_set is required for a future tag8021q operations. > > This implementation handles properly all states, but vsc73xx doesn't > forward STP packets. > > Signed-off-by: Pawel Dembicki This looks like the best effort to me. Reviewed-by: Linus Walleij Yours, Linus Walleij