Received-SPF: pass (google.com: domain of linux-kernel+bounces-92805-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Feedback-ID: iac594737:Fastmail
Date: Tue, 5 Mar 2024 13:03:40 -0500
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: usbip doesn't work with userspace code that accesses USB devices
Message-ID: <Zedeo6_4ZwuHiT3T@itl-email>
References: <ZeYov0k8njwcZzGX@itl-email>
 <2024030406-kilogram-raving-33c5@gregkh>
 <ZeZPLX6z5pyn2Eh_@mail-itl>
 <ZeZetkR-i1bCDr9v@mail-itl>
 <a95c7e71-a720-49ba-b503-6f20a86be38e@rowland.harvard.edu>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="WuauqmvHY1lzItxJ"
Content-Disposition: inline
In-Reply-To: <a95c7e71-a720-49ba-b503-6f20a86be38e@rowland.harvard.edu>


--WuauqmvHY1lzItxJ
Content-Type: text/plain; protected-headers=v1; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Date: Tue, 5 Mar 2024 13:03:40 -0500
From: Demi Marie Obenour <demi@invisiblethingslab.com>
To: Alan Stern <stern@rowland.harvard.edu>,
	Marek =?utf-8?Q?Marczykowski-G=C3=B3recki?= <marmarek@invisiblethingslab.com>
Cc: Greg KH <gregkh@linuxfoundation.org>, linux-usb@vger.kernel.org,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: usbip doesn't work with userspace code that accesses USB devices

On Mon, Mar 04, 2024 at 10:19:24PM -0500, Alan Stern wrote:
> On Tue, Mar 05, 2024 at 12:52:22AM +0100, Marek Marczykowski-G=C3=B3recki=
 wrote:
> > On Mon, Mar 04, 2024 at 11:46:04PM +0100, Marek Marczykowski-G=C3=B3rec=
ki wrote:
> > > Terminology:
> > > 1. sys-usb - a VM where USB controller (a PCI device) lives; here
> > > usbip-host is attached to the device
> > > 2. testvm - target VM where usbip is connected; here vhci-hcd is used
> > > 3. qvm-usb - tool that connects the above two (equivalent of
> > > userspace part of standard usbip)
> > >=20
> > > Specific steps:
> > > 1. Connect android phone - at this point it's only in sys-usb
> > > 2. Switch its mode to file transfer - observe reconnect in sys-usb
> > > 3. Use qvm-usb to attach it to the testvm
> > > 4. Call jmtpfs -d /mnt in testvm
> >=20
> > Or maybe reset or something is involved here too?
> >=20
> > After using qvm-usb to attach _and detach_ the device, it stays bound to
> > usbip-host driver (that's intentional). But then, even after re-binding
> > back to the "usb" driver, jmtpfs called in sys-usb directly fails the
> > same way, including failure to reset.
> >=20
> > In fact, even without usbip involved at all, jmtpfs directly in sys-usb
> > works only once. The second attempt (without either physically reconnec=
ting
> > the phone, or changing its more to "no data transfer" and back to "file
> > transfer") fails the same way. After terminating the first instance, I
> > see just this logged:
> >=20
> >     [921332.525210] usb 2-1: reset high-speed USB device number 22 usin=
g xhci_hcd
>=20
> If something doesn't work when usbip isn't involved, you definitely=20
> shouldn't expect it to work when usbip _is_ involved.

With usbip, jmtpfs fails the _first_ time, instead of only the _second_
time.  This might be related: maybe the attachment of usbip acts like
the first attach?
--=20
Sincerely,
Demi Marie Obenour (she/her/hers)
Invisible Things Lab

--WuauqmvHY1lzItxJ
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAEBCgAdFiEEdodNnxM2uiJZBxxxsoi1X/+cIsEFAmXnXqIACgkQsoi1X/+c
IsEpUBAA127He3YTnKqeYWZB6BxzbpxCSINki6Do6SVOuC/ndGalKTj0bbDdwvDp
jNjDudUSCdqqF8J30g9Ey4IEMtmbncLW0MJrOq9lErLdvu7W39w8DWANwdhtex43
IeayIECk6A9IV8M0aJOp6RDXHyxDBDMqkCfLPYQZkczIxAHd5Wvg2Nav0w4C2QBp
lwNWrQ2OaieLgYkYCwsziUu6JF94KyvvEguQqRlR3uSEdvb/JSbeVKladc3FZZ6s
uFM1qdILr21unwQ8OC/CxfN4e8ZIcoOfRfBddPJPl7EsaPG+rI4ydgCEmCXxEUXS
b+80iYTpCcCq+8FIcLjuFT4isaxxy5rllF+Jc21eMXTVXqOWvcjd9lY2wPwbp2mp
Za1QbjyXyI/csuEUIOeBWRl4TXZYPQCBGebyHAxjw/JEicmdcc+YiLI4+lsFUDJ9
rjkAF8nMcqrQtVD+bXUnGaURmd2nHvxNdWRX5BAV2+DX4GMSSl+0ihh/Gx+fDGpZ
bmdRraVID6vtqM0GfzfS5b+rAMBRrhItbgH+UobxoGfhf22yBmUfIXR1kUx/YYia
FZ9x6svH37F/6czpwpdKJFQHrrPO7wQYNsEhQMMJHEaqSvC6fhBK2mCxKtyIodmA
b4ugE/zCnk+LLlloDMui4jlmYhOycnhccuyr0daRquzduKKo+bc=
=x6n7
-----END PGP SIGNATURE-----

--WuauqmvHY1lzItxJ--