Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp760489lqs; Tue, 5 Mar 2024 16:12:13 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVNkm2JYjapjFX89vWMqKCbJclQM3ApBJoAFTsKiM8kqsnsqgEcu9tHY29LT/odFyf65/gprPd5+cOQpU1Lj/0mkoT4CGxw9XT/6sYV7w== X-Google-Smtp-Source: AGHT+IFlAH07A3w9DXN4mDVrFx8K1EAFRAXdefRI2i1EmlkfHsZIJXH8v3zPAEnE5vw0HMAhGSGu X-Received: by 2002:ac8:5854:0:b0:42e:dcf1:355a with SMTP id h20-20020ac85854000000b0042edcf1355amr4150915qth.32.1709683932936; Tue, 05 Mar 2024 16:12:12 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709683932; cv=pass; d=google.com; s=arc-20160816; b=gzCpOpPwM4k5250xofj5eW1vOEQ/h6WuCOqnEwTCk7JRf4WnFYazElIN+Ln1Q90jLh uPOBahSljDlkRHQXCIBpNXEJnJpMfGDk9FP/IwC/jJSQa5GoxdVUUcgU9j+/pgY6ji76 FGP1SYVVB7klwu/R4uQJpr3sFM5Eab0Y9l7yRh8UzB+phhX1x4+j3+pCLZnGALnl+xPa 50eB0cqiLvRrKJkMfk5/4JXInzzlX22RGwdSI5TRp6pnfI0vYzGAJ5HgbDlPzf/u69kQ 59Hal8ajUIlU3ueq/HiPoXWH5fc4sc4bNztkNHjvey4zT6kIQr4dthOSG+3Ty5+aQNB0 Jqqw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :date:subject:cc:to:from:dkim-signature; bh=E5AUx7yIzfKd4QjuMWluENnnnPZkBpDZmSme9BhaoSY=; fh=q57guTEQuQjr4wZ8UPMYcYs16UB2YUlwHD3uz+JphnY=; b=EatkgttPldi7BVnG88loCKeq/HTPDnpW4i0F1MpjDUrwll/4ooGRw1N/cU2lr8Zi4x ndF66stEDTA5YzVo+eTCqxutv6d3LRg7Yyqy9S9eBNeOfAGcCm8PTJlPveRdhAdIbh0Z QpQjoIsMPjuGXX0X1qLe2oylSFu8jT5dWKXej+zeUy0xy2D3pevebw5/ljMIv2nkkUaQ HoRHDZ7HnppSLx+FYKjFspB5OLrHshmyzBe2vyOO56PFfbOQWslSqDozEwNXyeiKqgWC g1ETCjeVOiO2bmkXxR3XKS0nVvRUyKtt6Ct8YQZKkkWE5w4qGT0E+yLAnDHcx/9ZlmqN 171w==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gx8aCkbs; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-93149-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93149-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id s13-20020a05622a178d00b0042f07a00d04si1588146qtk.574.2024.03.05.16.12.12 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 16:12:12 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93149-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=gx8aCkbs; arc=pass (i=1 spf=pass spfdomain=redhat.com dkim=pass dkdomain=redhat.com dmarc=pass fromdomain=redhat.com); spf=pass (google.com: domain of linux-kernel+bounces-93149-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93149-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 1BD151C26E86 for ; Wed, 6 Mar 2024 00:11:32 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id A1CAA1F93E; Wed, 6 Mar 2024 00:07:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="gx8aCkbs" Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 527381DFF4 for ; Wed, 6 Mar 2024 00:07:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709683657; cv=none; b=EBo2qW+86l5M9yqTotoA+GKrU0eVdjLnR4tIl9KGdccZ0DC3107H+cm1Qhdf7mkmWrggzprM3VpyRUd4oclRt9e+eysri+bH+l6p0VR/PRRQUH6pR0pVEjL8SxxftZsada6voX9L09vAT0LgoaDZj8r8j0JBCFvyxjxuHsa9bv8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709683657; c=relaxed/simple; bh=ljMsL1C2LYCeeJeMBEdzm9LuanQgXWoC+/BDvOiBmDY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=pQvHJzUnyvjb1ILH7cpL8usOFyzVHwKRUdtQdxNJWjMkcRM6vB+z0JAMSKU1vluYFULMNMH/m83YfxDztLua/ZJ6Y7S97Y3Huev/6IYWKfPKd13hMK2lXZ/xlI7GaoMvjms2gozw2SR52z9PLLzKXNwocT48WqY56JzS3pAcPoI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=gx8aCkbs; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1709683655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=E5AUx7yIzfKd4QjuMWluENnnnPZkBpDZmSme9BhaoSY=; b=gx8aCkbsb2gQNruYV8OzEuQPOlX5wBM/cRtt3+8HWbI+W5l7U0Of3AyK56YOxQmVz/2xn9 FlY6aKOn6d14k0QZk0zUn8JCGCTGG7mn1bebQdr1oxuHgsDaYNeYyrf6LmB5ZAQixal2Wj RtJLLaCBi/tenyUpBW9cr/NO1U9mfg0= Received: from mimecast-mx02.redhat.com (mx-ext.redhat.com [66.187.233.73]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-490-dZlkstzvOjiNgugmgby_Qw-1; Tue, 05 Mar 2024 19:07:31 -0500 X-MC-Unique: dZlkstzvOjiNgugmgby_Qw-1 Received: from smtp.corp.redhat.com (int-mx09.intmail.prod.int.rdu2.redhat.com [10.11.54.9]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 4F5381C02D2E; Wed, 6 Mar 2024 00:07:31 +0000 (UTC) Received: from warthog.procyon.org.com (unknown [10.42.28.114]) by smtp.corp.redhat.com (Postfix) with ESMTP id 063DC492BCB; Wed, 6 Mar 2024 00:07:29 +0000 (UTC) From: David Howells To: netdev@vger.kernel.org Cc: David Howells , Marc Dionne , Simon Horman , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , linux-afs@lists.infradead.org, linux-kernel@vger.kernel.org Subject: [PATCH net-next v3 15/21] rxrpc: Parse received packets before dealing with timeouts Date: Wed, 6 Mar 2024 00:06:45 +0000 Message-ID: <20240306000655.1100294-16-dhowells@redhat.com> In-Reply-To: <20240306000655.1100294-1-dhowells@redhat.com> References: <20240306000655.1100294-1-dhowells@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Scanned-By: MIMEDefang 3.4.1 on 10.11.54.9 Parse the received packets before going and processing timeouts as the timeouts may be reset by the reception of a packet. Signed-off-by: David Howells cc: Marc Dionne cc: "David S. Miller" cc: Eric Dumazet cc: Jakub Kicinski cc: Paolo Abeni cc: linux-afs@lists.infradead.org cc: netdev@vger.kernel.org --- net/rxrpc/call_event.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/net/rxrpc/call_event.c b/net/rxrpc/call_event.c index e19ea54dce54..58826710322d 100644 --- a/net/rxrpc/call_event.c +++ b/net/rxrpc/call_event.c @@ -358,6 +358,9 @@ bool rxrpc_input_call_event(struct rxrpc_call *call, struct sk_buff *skb) if (skb && skb->mark == RXRPC_SKB_MARK_ERROR) goto out; + if (skb) + rxrpc_input_call_packet(call, skb); + /* If we see our async-event poke, check for timeout trippage. */ now = jiffies; t = call->expect_rx_by; @@ -417,9 +420,6 @@ bool rxrpc_input_call_event(struct rxrpc_call *call, struct sk_buff *skb) resend = true; } - if (skb) - rxrpc_input_call_packet(call, skb); - rxrpc_transmit_some_data(call); if (skb) {