Received-SPF: pass (google.com: domain of linux-kernel+bounces-93165-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Wed, 6 Mar 2024 01:25:21 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc: Hans de Goede <hdegoede@redhat.com>, 
	Konrad Dybcio <konradybcio@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/4] power: supply: mm8013: fix "not charging"
 detection
Message-ID: <og6dmqpwamie7juq6octbqvgpez3bbgpubl3jf6ofdlavt6xkg@sib6nskfq3og>
References: <20240303-power_supply-charge_behaviour_prop-v2-0-8ebb0a7c2409@weissschuh.net>
 <20240303-power_supply-charge_behaviour_prop-v2-1-8ebb0a7c2409@weissschuh.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="qsdnwnhcbz2doksc"
Content-Disposition: inline
In-Reply-To: <20240303-power_supply-charge_behaviour_prop-v2-1-8ebb0a7c2409@weissschuh.net>


--qsdnwnhcbz2doksc
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Mar 03, 2024 at 04:31:13PM +0100, Thomas Wei=C3=9Fschuh wrote:
> The charge_behaviours property is meant as a control-knob that can be
> changed by the user.
>=20
> Page 23 of [0] which documents the flag CHG_INH as follows:
>=20
>   CHG_INH : Charge Inhibit      When the current is more than or equal to=
 charge
>                                 threshold current,
>                                 charge inhibit temperature (upper/lower l=
imit) =EF=BC=9A1
>                                 charge permission temperature or the curr=
ent is
>                                 less than charge threshold current =EF=BC=
=9A0
>=20
> So this is pure read-only information which is better represented as
> POWER_SUPPLY_STATUS_NOT_CHARGING.
>=20
> [0] https://product.minebeamitsumi.com/en/product/category/ics/battery/fu=
el_gauge/parts/download/__icsFiles/afieldfile/2023/07/12/1_download_01_12.p=
df
>=20
> Signed-off-by: Thomas Wei=C3=9Fschuh <linux@weissschuh.net>
> ---

I queued this with=20

Fixes: e39257cde7e8 ("power: supply: mm8013: Add more properties")

-- Sebastian

>  drivers/power/supply/mm8013.c | 13 ++-----------
>  1 file changed, 2 insertions(+), 11 deletions(-)
>=20
> diff --git a/drivers/power/supply/mm8013.c b/drivers/power/supply/mm8013.c
> index caa272b03564..20c1651ca38e 100644
> --- a/drivers/power/supply/mm8013.c
> +++ b/drivers/power/supply/mm8013.c
> @@ -71,7 +71,6 @@ static int mm8013_checkdevice(struct mm8013_chip *chip)
> =20
>  static enum power_supply_property mm8013_battery_props[] =3D {
>  	POWER_SUPPLY_PROP_CAPACITY,
> -	POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR,
>  	POWER_SUPPLY_PROP_CHARGE_FULL,
>  	POWER_SUPPLY_PROP_CHARGE_FULL_DESIGN,
>  	POWER_SUPPLY_PROP_CHARGE_NOW,
> @@ -103,16 +102,6 @@ static int mm8013_get_property(struct power_supply *=
psy,
> =20
>  		val->intval =3D regval;
>  		break;
> -	case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR:
> -		ret =3D regmap_read(chip->regmap, REG_FLAGS, &regval);
> -		if (ret < 0)
> -			return ret;
> -
> -		if (regval & MM8013_FLAG_CHG_INH)
> -			val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_INHIBIT_CHARGE;
> -		else
> -			val->intval =3D POWER_SUPPLY_CHARGE_BEHAVIOUR_AUTO;
> -		break;
>  	case POWER_SUPPLY_PROP_CHARGE_FULL:
>  		ret =3D regmap_read(chip->regmap, REG_FULL_CHARGE_CAPACITY, &regval);
>  		if (ret < 0)
> @@ -187,6 +176,8 @@ static int mm8013_get_property(struct power_supply *p=
sy,
> =20
>  		if (regval & MM8013_FLAG_DSG)
>  			val->intval =3D POWER_SUPPLY_STATUS_DISCHARGING;
> +		else if (regval & MM8013_FLAG_CHG_INH)
> +			val->intval =3D POWER_SUPPLY_STATUS_NOT_CHARGING;
>  		else if (regval & MM8013_FLAG_CHG)
>  			val->intval =3D POWER_SUPPLY_STATUS_CHARGING;
>  		else if (regval & MM8013_FLAG_FC)
>=20
> --=20
> 2.44.0
>=20

--qsdnwnhcbz2doksc
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmXnt+kACgkQ2O7X88g7
+pp5Wg//Zlo02j7Z3Jt6p3qgKIpPjwQbDWV6Lg6fmuMFww2JLhis8ArRdRxiyG7y
r5wdi+T5ssmjyOKNBo9II3QGV8aNYy2Z/xpm3o+uGn4hSx9+jNNfx4MDwe8eLetk
EVee+oLA8JzaM6MJbgFaSgcudaFon2bVrb0VZaGjA34q0QNtEeYWyYQs8b8uz/bY
2Cv5iNs9t6Wg0WhBQUodE+T2ba/bdHE2DExwGPRwciNRhUeuaOGMVzuraGurkYLY
4rxqH6AFRfeM1qRx092+79dXHHnE2unwUnb3IdU7c5AEMumhWSg8vefyCBy4sdzP
YZdO223oVQtXwYwA79nCAhPDoSpdFJITt/7EMFOmP0xAe1MmFPZhkoY3b85b3xqG
x/yrYSMb965RAZPcNsdqXQDV1t7fw5SRc7aNDTYu9qyOCdicrVUIQ6ZbcesHoWr+
LOsO54MTPDEPirrx2PSafsHh8xr9jedEU/WAmUXBTDAKuCaeZ02z4iUiIOmJe6RD
A3j3K6Kt9ZITqzpVz1JhEnCERUpC+lhne0nm2muS17yqVvdMx58En+JjjCmrweIz
pKj7Wzat8WX4NVaOzTFk9pcYCLNJax41QUi8+TZ6fxXCCsSiWWzkKxmrkVD58cpT
EtgOl3VugtZlu+dkNdJBGSsCifVKuXOAKuCm7zbeTJnLjc916Aw=
=w7dw
-----END PGP SIGNATURE-----

--qsdnwnhcbz2doksc--