Received-SPF: pass (google.com: domain of linux-kernel+bounces-93173-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Wed, 6 Mar 2024 01:39:34 +0100
From: Sebastian Reichel <sebastian.reichel@collabora.com>
To: Thomas =?utf-8?Q?Wei=C3=9Fschuh?= <linux@weissschuh.net>
Cc: Hans de Goede <hdegoede@redhat.com>, 
	Konrad Dybcio <konradybcio@kernel.org>, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 4/4] power: supply: test-power: implement
 charge_behaviour property
Message-ID: <v5cblrwp3ubum3cciiwqazeivkwws2phkocxsdwa7v3hpwxuf4@bea76hsomovd>
References: <20240303-power_supply-charge_behaviour_prop-v2-0-8ebb0a7c2409@weissschuh.net>
 <20240303-power_supply-charge_behaviour_prop-v2-4-8ebb0a7c2409@weissschuh.net>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="bdnqhngrcjnbq5uu"
Content-Disposition: inline
In-Reply-To: <20240303-power_supply-charge_behaviour_prop-v2-4-8ebb0a7c2409@weissschuh.net>


--bdnqhngrcjnbq5uu
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi,

On Sun, Mar 03, 2024 at 04:31:16PM +0100, Thomas Wei=DFschuh wrote:
> To validate the special formatting of the "charge_behaviour" sysfs
> property add it to the example driver.
>=20
> Signed-off-by: Thomas Wei=DFschuh <linux@weissschuh.net>
> ---

Thanks for your patch.

>  drivers/power/supply/test_power.c | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)
>=20

[...]

> +static int test_power_set_battery_property(struct power_supply *psy,
> +					   enum power_supply_property psp,
> +					   const union power_supply_propval *val)
> +{
> +	switch (psp) {
> +	case POWER_SUPPLY_PROP_CHARGE_BEHAVIOUR:
> +		battery_charge_behaviour =3D val->intval;
> +		break;

This should check if user supplied val->intval is valid, otherwise
LGTM.

-- Sebastian

--bdnqhngrcjnbq5uu
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEE72YNB0Y/i3JqeVQT2O7X88g7+poFAmXnuz0ACgkQ2O7X88g7
+prxlw/+MZ7eBwygN9cFXZWBZu9B0eFeUfDek+fFVvWShalFLghtMR2ltdjagntC
hZv5MCqSKPkONEsZ9H9R9K0H0vlArdN1UL5/R9yll9vE6ym+Vohu0VocoxxjQFMy
W+ecSgV3mdeBe/OMIlgW9IKndo+VUQW4jDwLhTvj4FlNRaqEEQqa4uX+UlCACq3k
UFSriJqcAkGwHyXtS7/dLRfDSK8nebUgerf6puohc0MIYYCNrqJsEVNb1UMPBdy4
mTEjE/VIpU8VmbK31AfFvlcIEsTZcOJG/YcgN2Yje6GSleEYl/bAXdRQk30XQiTm
zUFNcfv5vK4bxmCuBOSFi+8PlW24A5e/oPTKDHWe01SWaYJFj6iUOi+Pnm4DOsAA
P7Ktr26rHFvq796UrAbEPyJL22+m17uS/mKrUKuoQTD9P1eNHE7RnRbBuq+SffzI
wyG7BdFWFFH0fPlK5oL3yKn7tPF4J5DF00ro6PjHkkiMQpVPCV7HU9g6Awjy2MuG
JHxA488cO4D9O3/NORGI5OtRi/rmAKXio4Cw4G2h6CBzuJnXWb0aHrmyk0VyTNwB
gfBRMm6xmNYhpmJK3/XbbWvglgRelD/t3BV0US2mmHRntZbAFCZaiW/wxK0F0mMo
F8qnlHjdNsjmBnlxjYMNPG3DfB39HZqxoRDfb/MgcmlgRmrWzso=
=D3ng
-----END PGP SIGNATURE-----

--bdnqhngrcjnbq5uu--