Received: by 2002:a89:2c3:0:b0:1ed:23cc:44d1 with SMTP id d3csp772907lqs; Tue, 5 Mar 2024 16:44:57 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUXpSHOzTQVoRCfkKSgAyA4B7WqoQJ5OAYm49DilLcJFQPTTZerW6zrqP0b4Ys99we2KmGZs0lcMI6s6XfKivIFW8vlaWcidf/oG1DWtw== X-Google-Smtp-Source: AGHT+IEW1x2/i0XeM/p3u8OYyTVrjBscIwa0OEM6AAPVXKDgteQhxNQHka+EGCSkCCKLvXq4I1ey X-Received: by 2002:a05:6a20:e09:b0:1a1:445b:ba2e with SMTP id ej9-20020a056a200e0900b001a1445bba2emr2668312pzb.45.1709685897384; Tue, 05 Mar 2024 16:44:57 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709685897; cv=pass; d=google.com; s=arc-20160816; b=G7uL/iTcFPRwv02d1HAmyI5hZr0EdLKfEWnxqP5D2Ut9JxuK0I4HcB4fEiS49KDHj6 NYRebLzTwRv9U1aRB84OfyXR5KBuHWqW0HSHVogaOqEnsxfsWkqfMb8ZgBkcUcb28BBL T4ycyj9dEVXHIIxDAMm5LLNEmfcbbcrtjcM00LFeqw+CuRuLEJefRpw2z0+NH/LwptZa ugzsCeZdAaKAXSnglcOtHmQxwGVtmUMQOT2q/QEy48d5iXuhT2KVGbbHZaWeD4GkwOUA +BJDinP6OXoPipQBEOYc2Uon+56iKZRRUJ/EnMemsJ2pb+RPRMaS+8knQGXn35NcBc64 zfhw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:subject :references:in-reply-to:cc:to:from; bh=8f3UmXTfWeOYjvWER4iqXbxsCzesm4jdjM5GnO64t6o=; fh=v59GBqjZ89t5psXRk/YOBn75JjeG+MCnHAzYP5wCz18=; b=T/Kj6yRR8Ru0xqJHKdE6fED22BQhow8rwQOzRGBdcV1rbYI/KQZCia3uYY9epemZ1N ATq7eHIzzRI3DfdDjxoPY1+2wYpLIKR/Z6oEeL9BpKq+U7b79ckNEq6vkZ0IkzbEPvf6 UaPeglRbgxT0Wic2DjLcl3g6Dy9nPZhYueIXuscjq8D6w2z8DbHcYkMlc/Ga17ozFl+s rd4/hdamZrQh1SKM/2QyztWTI+eWo0C5RRVkt4kPFstJIsdBtjLrAOdH/zJD0sStVHgt 9wmwLULrT1wjd5lP46Kz7uIhuLO7/yZyWPIvqj9pE+JfygVTVhLuNg1WuUvqqbY0lFwJ 7aPA==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-93163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [2604:1380:40f1:3f00::1]) by mx.google.com with ESMTPS id t3-20020a17090340c300b001d768fd5927si10718118pld.314.2024.03.05.16.44.56 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 05 Mar 2024 16:44:57 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-93163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-kernel+bounces-93163-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-93163-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=collabora.com Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id A7813B2486D for ; Wed, 6 Mar 2024 00:24:41 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 65A81D52E; Wed, 6 Mar 2024 00:24:30 +0000 (UTC) Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D99134C8F; Wed, 6 Mar 2024 00:24:29 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709684669; cv=none; b=madoYIjwM5Ns513n9u9exq4B5qF2SupC0Rv6p1oD/5EbRNCzOR0vSn478OwvN8GOiZeMnrdpXgZBb5JhTP7b/rGgwmLOpZKylWX5/yubzV5RldDZVxtMKg3SrmTJCxmuf2PQKT5hU4CojOGFTEXzE58HkRRG4JQwTyouDrkhkYk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709684669; c=relaxed/simple; bh=oYvNC2/mFtZnu/1sU9+I8+QsRe1+61Q3hKfBaUiqz8U=; h=From:To:Cc:In-Reply-To:References:Subject:Message-Id:Date: MIME-Version:Content-Type; b=dLQwHCAixodNvy5E0k4tJP0pDH6VZcjXo7D5cdtFixvdQWNh23miyGrpsQEZYjqouvTIRMlJPAhwb7C23jrqo7N5tosyLKIs+bToLhBo48fIm/HYuKWZgsIH6n4rDL0hwuqk9zkiUzmQdtmmSrqWnPuC0NEL573RqEUnBV3GnSA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2B29EC433F1; Wed, 6 Mar 2024 00:24:29 +0000 (UTC) Received: by mercury (Postfix, from userid 1000) id 3DF9F1060B14; Wed, 6 Mar 2024 01:24:26 +0100 (CET) From: Sebastian Reichel To: Sebastian Reichel , "Ricardo B. Marliere" Cc: linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, kernel test robot In-Reply-To: <20240303-class_cleanup-power-v2-1-e248b7128519@marliere.net> References: <20240303-class_cleanup-power-v2-1-e248b7128519@marliere.net> Subject: Re: [PATCH v2] power: supply: move power_supply_attr_groups definition back to sysfs Message-Id: <170968466622.645753.4432514364980212313.b4-ty@collabora.com> Date: Wed, 06 Mar 2024 01:24:26 +0100 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Mailer: b4 0.13.0 On Sun, 03 Mar 2024 13:30:50 -0300, Ricardo B. Marliere wrote: > As reported by the kernel test robot, 'power_supply_attr_group' is defined > but not used when CONFIG_SYSFS is not set. Sebastian suggested that the > correct fix implemented by this patch, instead of my attempt in commit > ea4367c40c79 ("power: supply: core: move power_supply_attr_group into #ifdef > block"), is to define power_supply_attr_groups in power_supply_sysfs.c and > expose it in the power_supply.h header. For the case where CONFIG_SYSFS=n, > define it as NULL. > > [...] Applied, thanks! [1/1] power: supply: move power_supply_attr_groups definition back to sysfs commit: f107e6b82392a4d64507e219c57235d3fe09e9d7 Best regards, -- Sebastian Reichel