Received-SPF: pass (google.com: domain of linux-kernel+bounces-93207-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 6 Mar 2024 09:20:35 +0800
From: Yan Zhao <yan.y.zhao@intel.com>
To: Sagi Shahar <sagis@google.com>
CC: <linux-kselftest@vger.kernel.org>, Ackerley Tng <ackerleytng@google.com>,
	Ryan Afranji <afranji@google.com>, Erdem Aktas <erdemaktas@google.com>, Isaku
 Yamahata <isaku.yamahata@intel.com>, Sean Christopherson <seanjc@google.com>,
	Paolo Bonzini <pbonzini@redhat.com>, Shuah Khan <shuah@kernel.org>, Peter
 Gonda <pgonda@google.com>, Haibo Xu <haibo1.xu@intel.com>, Chao Peng
	<chao.p.peng@linux.intel.com>, "Vishal Annapurve" <vannapurve@google.com>,
	Roger Wang <runanwang@google.com>, "Vipin Sharma" <vipinsh@google.com>,
	<jmattson@google.com>, <dmatlack@google.com>, <linux-kernel@vger.kernel.org>,
	<kvm@vger.kernel.org>, <linux-mm@kvack.org>
Subject: Re: [RFC PATCH v5 23/29] KVM: selftests: TDX: Add shared memory test
Message-ID: <ZefE4wq1C2nA/Saq@yzhao56-desk.sh.intel.com>
Reply-To: Yan Zhao <yan.y.zhao@intel.com>
References: <20231212204647.2170650-1-sagis@google.com>
 <20231212204647.2170650-24-sagis@google.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20231212204647.2170650-24-sagis@google.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?wg7SyciJV1CfWidUgeE6ZhL3CM5/s0PK43VSBBqExA/PHQ9qxPp67npKp3Au?=
 =?us-ascii?Q?9ars2moMhkVWoo8x7k9xhvkcHTE67gsSTTJlq8C4YcP6QtPPRv0xnyAzV5fR?=
 =?us-ascii?Q?TjCaerFffGcU5V/J8Q6g+wI+Tas4gEemOnFM0iaBze5LDvAyg0jUy9bxekAF?=
 =?us-ascii?Q?/sI7nYw8eRIPNjBknaOGB8XC95KAs3OtXDwYXKYJVggQ3WLCIBGsoZFLlfMb?=
 =?us-ascii?Q?mn/zqgyCp+8x+aCfqbYPjAov4NSMpjnAzOxYcejBpXOdXVFPrqXdvRQKqiJX?=
 =?us-ascii?Q?JGlJ2PkHyKrJKijOw2yOJBb1GvUao/+tfFPKQs9zhiBr7XgkfrSM27+p1w0l?=
 =?us-ascii?Q?xdU3K5CASfWdN1cnnvPvIv0GRaMEtLOlV6NJWWPXz/2j7v9zJ4gMNtJ9npQd?=
 =?us-ascii?Q?SglUZkP2W+fFSC0HSN4suaEoBGsCJE4SX8bsIcp+SFkJOoa5/lTRxKc7fCdH?=
 =?us-ascii?Q?sqTRhFobF5VZm59AmmyTemdtV3P9mSGhN9LE5OoffBITqTg6J0ygn472XSoM?=
 =?us-ascii?Q?BVklmj/x2gwcGhCw1uxXNzbBtUjLaaVyOgvzYjG+FbQE+2NzQCx5zZHgrOZP?=
 =?us-ascii?Q?d+9HeKDreLZX4oM6TW5E/uPIs3FdUMLAOjHme0UyBpXkVlEAsvANV+deFSjQ?=
 =?us-ascii?Q?/jAfcrockvq0COZZ5tGPSnt/8i1QrtTglilMefxQuZ/xrT1vsyxr8OR9+yKo?=
 =?us-ascii?Q?5QZKEFy66CKtu2EDsoTW4XSAvOub4kBobgjuruyHywiwq8uOqxRR7Su2ximY?=
 =?us-ascii?Q?nwsZ0apTZoVp5jIWhrMet03GGHS9lXY+LRDIxtE/jUGzejViz4nOhzlO6NJq?=
 =?us-ascii?Q?VJICyEqyEewRbAdsL5zHSASwky2SAqnQH2UjhtTrG50FiG1F8AOO0QequB1l?=
 =?us-ascii?Q?uR8hVU3wP3XlRW84Og0rIRH8PtaOVW/C8xc4tSWnQpM4/v0vENqK/8oOSqDU?=
 =?us-ascii?Q?9vN/Gm62Sl9NG5ciFvkW3BsiZrV9USNAbYXyDuOFRMw1ZKkHbUfEpH7Nv+Bs?=
 =?us-ascii?Q?e62+3O3dLebTITefL2ySFQosl4CaonTVedrqYO0pMqr3cFURIlg6/b7hV6Yn?=
 =?us-ascii?Q?5kPWrrImZw+cOQC4hUhVUSbUpLUoJtvFe9jXMFuL4eknELr8Tzjmt0hL/o57?=
 =?us-ascii?Q?zGNGqDlo7iM5UcGg1gQxfjEbSAhTs07Td9IYNQrJ3k4DdAZLCl8SrnJqD/z8?=
 =?us-ascii?Q?ZEDIlo0cL+duQNQjMj+TO0ib0Yre1yzA7fCd4GN1CPwiXOruws0YIovx4CJ8?=
 =?us-ascii?Q?Dq428ntIVbBRSwCgikS0ckjNBkHGL2o4A5GneHSMoBrAHWaZTH/lthynBRPs?=
 =?us-ascii?Q?eiPGYLWQ67/PfEx2ErUZ9DP2rbqv73g2gBQKQLsIH9cEP+XM5QIObnr2BwqF?=
 =?us-ascii?Q?c/BL9Dyb7T8R8ODNUqIZ6y3z40w1CpNG4VhG2L7ER+fr38RHYFTIaeEVZ3PK?=
 =?us-ascii?Q?GnLVveZ2YoBLmR0qFk3tH4HRb6vwjLxKfkpI6d9f9ohrKWMa4cdfpDx4nSix?=
 =?us-ascii?Q?8DI398sZI1s5RWtxHnecmj3w4Dzky0vYeSaBqfMZTT2sMqCpS6+y22WfzOt0?=
 =?us-ascii?Q?uTRU+UgOFqgEvkD+YBB+US9FHVb695IuFhIq02uW?=
X-MS-Exchange-CrossTenant-Network-Message-Id: a11b06dc-7aa6-4e07-c0b2-08dc3d7fcde9
X-MS-Exchange-CrossTenant-AuthSource: DS7PR11MB5966.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 01:50:30.5990
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BQoebdl4u3yhIci4VSY7VDjwnicVVHOCelLgAb175yNeJNV+/+7B6cIuzb2oCNoTArjwOC2J6zNHjlBYeSJoxw==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB8322
X-OriginatorOrg: intel.com

> +int verify_shared_mem(void)
> +{
> +	struct kvm_vm *vm;
> +	struct kvm_vcpu *vcpu;
> +
> +	vm_vaddr_t test_mem_private_gva;
> +	uint32_t *test_mem_hva;
> +
> +	vm = td_create();
> +	td_initialize(vm, VM_MEM_SRC_ANONYMOUS, 0);
> +	vcpu = td_vcpu_add(vm, 0, guest_shared_mem);
> +
> +	/*
> +	 * Set up shared memory page for testing by first allocating as private
> +	 * and then mapping the same GPA again as shared. This way, the TD does
> +	 * not have to remap its page tables at runtime.
> +	 */
> +	test_mem_private_gva = vm_vaddr_alloc(vm, vm->page_size,
> +					      TDX_SHARED_MEM_TEST_PRIVATE_GVA);
> +	TEST_ASSERT_EQ(test_mem_private_gva, TDX_SHARED_MEM_TEST_PRIVATE_GVA);
> +
> +	test_mem_hva = addr_gva2hva(vm, test_mem_private_gva);
> +	TEST_ASSERT(test_mem_hva != NULL,
> +		    "Guest address not found in guest memory regions\n");
> +
> +	test_mem_private_gpa = addr_gva2gpa(vm, test_mem_private_gva);
> +	virt_pg_map_shared(vm, TDX_SHARED_MEM_TEST_SHARED_GVA,
> +			   test_mem_private_gpa);
> +
> +	test_mem_shared_gpa = test_mem_private_gpa | BIT_ULL(vm->pa_bits - 1);
Why not use vm->arch.s_bit?

> +	sync_global_to_guest(vm, test_mem_private_gpa);
test_mem_private_gpa is not used in guest. No need to sync.

> +	sync_global_to_guest(vm, test_mem_shared_gpa);
> +
> +	td_finalize(vm);
> +
> +	printf("Verifying shared memory accesses for TDX\n");
> +
> +	/* Begin guest execution; guest writes to shared memory. */
> +	printf("\t ... Starting guest execution\n");
> +
> +	/* Handle map gpa as shared */
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_CHECK_GUEST_FAILURE(vcpu);
> +
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_ASSERT_IO(vcpu, TDX_SHARED_MEM_TEST_INFO_PORT, 4,
> +			   TDG_VP_VMCALL_INSTRUCTION_IO_WRITE);
> +	TEST_ASSERT_EQ(*test_mem_hva, TDX_SHARED_MEM_TEST_GUEST_WRITE_VALUE);
> +
> +	*test_mem_hva = TDX_SHARED_MEM_TEST_HOST_WRITE_VALUE;
> +	td_vcpu_run(vcpu);
> +	TDX_TEST_ASSERT_IO(vcpu, TDX_SHARED_MEM_TEST_INFO_PORT, 4,
> +			   TDG_VP_VMCALL_INSTRUCTION_IO_WRITE);
> +	TEST_ASSERT_EQ(
> +		*(uint32_t *)((void *)vcpu->run + vcpu->run->io.data_offset),
> +		TDX_SHARED_MEM_TEST_HOST_WRITE_VALUE);
> +
> +	printf("\t ... PASSED\n");
> +
> +	kvm_vm_free(vm);
> +
> +	return 0;
> +}