Received-SPF: pass (google.com: domain of linux-kernel+bounces-93261-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 6 Mar 2024 14:04:27 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Lee Jones <lee@kernel.org>
Cc: Duje =?UTF-8?B?TWloYW5vdmnEhw==?= <duje.mihanovic@skole.hr>, Linux
 Kernel Mailing List <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the backlight tree
Message-ID: <20240306140427.4cb24a5e@canb.auug.org.au>
In-Reply-To: <20240306095539.0da4e342@canb.auug.org.au>
References: <20240226132828.7524baec@canb.auug.org.au>
	<20240305111634.57e84398@canb.auug.org.au>
	<20240305091737.GB5206@google.com>
	<20240306095539.0da4e342@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/GOAK+gnWa=diFn7z7lIQnuw";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/GOAK+gnWa=diFn7z7lIQnuw
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi Lee,

On Wed, 6 Mar 2024 09:55:39 +1100 Stephen Rothwell <sfr@canb.auug.org.au> w=
rote:
>
> On Tue, 5 Mar 2024 09:17:37 +0000 Lee Jones <lee@kernel.org> wrote:
> > On Tue, 05 Mar 2024, Stephen Rothwell wrote: =20
> > > On Mon, 26 Feb 2024 13:28:28 +1100 Stephen Rothwell <sfr@canb.auug.or=
g.au> wrote:   =20
> > > >
> > > > After merging the backlight tree, today's linux-next build (x86_64
> > > > allmodconfig) failed like this:
> > > >=20
> > > > drivers/video/backlight/ktd2801-backlight.c:8:10: fatal error: linu=
x/leds-expresswire.h: No such file or directory
> > > >     8 | #include <linux/leds-expresswire.h>
> > > >       |          ^~~~~~~~~~~~~~~~~~~~~~~~~~
> > > >=20
> > > > Caused by commit
> > > >=20
> > > >   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
> > > >=20
> > > > I have used the backlight tree from next-20240223 for today.   =20
> > >=20
> > > I am still getting this failure.   =20
> >=20
> > I just pushed a bunch of patches. =20
>=20
> I saw only 3 new ones (forgot to push?) none of which addressed this
> problem.
>=20
> > Please let me know if this is still an issue tomorrow. =20
>=20
> The problem is that after Feb 23, you rebased your tree and dropped commit
>=20
>   25ae5f5f4168 ("leds: Introduce ExpressWire library")
>=20
> which (added the leds-expresswire.h header), but kept commit
>=20
>   48749e2f14e3 ("backlight: Add Kinetic KTD2801 backlight support")
>=20
> which uses it.

Now I see what happened.  I have 2 trees from you, the backlight tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/backlight.git#for-backli=
ght-next)
and the leds-lj tree
(git://git.kernel.org/pub/scm/linux/kernel/git/lee/leds.git#for-leds-next)
and the former implicitly depends on the latter (and I merge the
backlight tree first).  You should make that dependency explicit by
merging (part of) the latter into the former (or something).

--=20
Cheers,
Stephen Rothwell

--Sig_/GOAK+gnWa=diFn7z7lIQnuw
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXn3TsACgkQAVBC80lX
0GzRbAf/VnPnRbwDaIyeXQcpSxo0mfy1eM/FQqsOSCrvZU+frg6aVH97QX2b17hy
VyKXb6clQHhrFmPnqv5AgrH9KkY39/TliPmYrv0dH3ihV2e3tL8GgYA8KngtqDVv
e6WJUlRlwZlfVklxXVA5c+8qFsntcVHrRn1idjmNMNwPP0DeOpxJNpBaskPGshu8
ausC8VpV+qq01D1wCzokw+OrRDvOH1nIpgYe5lksZ/A61E8b9VEKSjj/Q56eh2xX
jssDLDyg4eHEqSsEoMA1AeTcdOsqonp2cOPv/XLWONHMw+dpDR8Y9BSSWStnsSqF
VBdo6SfJy4VbCbUpQ+G13iPu413asg==
=BL6z
-----END PGP SIGNATURE-----

--Sig_/GOAK+gnWa=diFn7z7lIQnuw--