Date: Sat, 5 Jan 2008 18:24:49 +0300
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: David Miller <davem@davemloft.net>
Cc: lizf@cn.fujitsu.com, akpm@linux-foundation.org,
       linux-kernel@vger.kernel.org
Subject: Re: [PATCH 5/5] CONNECTOR: return proper error code in cn_call_callback()
Message-ID: <20080105152449.GA12982@2ka.mipt.ru>
References: <477DC9C1.2000209@cn.fujitsu.com> <20080104.015125.103222890.davem@davemloft.net>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20080104.015125.103222890.davem@davemloft.net>
User-Agent: Mutt/1.5.9i
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 986
Lines: 29

Hi.

Sorry for long reply.

On Fri, Jan 04, 2008 at 01:51:25AM -0800, David Miller (davem@davemloft.net) wrote:
> > Error code should be set to EINVAL instead of ENODEV if !queue_work().
> > There's another call of queue_work() which may set err to EINVAL.
> > 
> > Signed-off-by: Li Zefan <lizf@cn.fujitsu.com>
> 
> This one is a bug fix so I'll apply it to net-2.6 and push
> to Linus.
> 
> The rest are cleanups which I'll queue up for 2.6.25

Although I'm not sure changing error from nodev to inval is a bug fix :),
I have no problem with pushing it first.
Loop above will break out after first matched id, so it will never call
the path, which can change error, again.

Thanks a lot for patches and quick merge!

-- 
	Evgeniy Polyakov
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/