Received-SPF: pass (google.com: domain of linux-kernel+bounces-93333-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Wed, 6 Mar 2024 15:58:30 +1100
From: Stephen Rothwell <sfr@canb.auug.org.au>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Christian Brauner <brauner@kernel.org>, Tong Tiangen
 <tongtiangen@huawei.com>, Linux Kernel Mailing List
 <linux-kernel@vger.kernel.org>, Linux Next Mailing List
 <linux-next@vger.kernel.org>
Subject: Re: linux-next: build warning after merge of the vfs-brauner tree
Message-ID: <20240306155830.78bd7895@canb.auug.org.au>
In-Reply-To: <20240306153703.499661d2@canb.auug.org.au>
References: <20240306105150.06a456da@canb.auug.org.au>
	<CAHk-=whdTCEDaUPTMHUQXPQHuM8dhBi8yWbNAL11yE_ODqR_uA@mail.gmail.com>
	<20240306153703.499661d2@canb.auug.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; boundary="Sig_/Z7LM7vHarhCNmirND9+5NCJ";
 protocol="application/pgp-signature"; micalg=pgp-sha256

--Sig_/Z7LM7vHarhCNmirND9+5NCJ
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: quoted-printable

Hi all,

On Wed, 6 Mar 2024 15:37:03 +1100 Stephen Rothwell <sfr@canb.auug.org.au> w=
rote:
>
> On Tue, 5 Mar 2024 18:48:30 -0800 Linus Torvalds <torvalds@linux-foundati=
on.org> wrote:
> >
> > On Tue, 5 Mar 2024 at 15:51, Stephen Rothwell <sfr@canb.auug.org.au> wr=
ote: =20
> > >
> > > fs/coredump.c: In function 'dump_user_range':
> > > fs/coredump.c:923:40: warning: left-hand operand of comma expression =
has no effect [-Wunused-value]
> > >   923 | #define dump_page_copy(src, dst) ((dst), (src))
> > >       |                                        ^
> > > fs/coredump.c:948:58: note: in expansion of macro 'dump_page_copy'
> > >   948 |                         int stop =3D !dump_emit_page(cprm, du=
mp_page_copy(page, dump_page));
> > >       |                                                          ^~~~=
~~~~~~~~~~
> > >
> > > Introduced by commit
> > >
> > >   4630f2caafcd ("coredump: get machine check errors early rather than=
 during iov_iter")   =20
> >=20
> > Bah. If comes from that
> >=20
> >   #define dump_page_copy(src,dst) ((dst),(src))
> >=20
> > and I did it that way because I wanted to avoid *another* warning,
> > namely the "dst not used" thing.
> >=20
> > But it would have probably been better to either make it an inline
> > function, or maybe an explicit cast, eg
> >=20
> >   #define dump_page_copy(src,dst) ((void)(dst),(src))
> >=20
> > or whatever. =20
>=20
> This became a build failure for my i386 defconfig build, so I did this:
>=20
> From: Stephen Rothwell <sfr@canb.auug.org.au>
> Date: Wed, 6 Mar 2024 15:28:12 +1100
> Subject: [PATCH] fix up for "coredump: get machine check errors early rat=
her
>  than during iov_iter"
>=20
> Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
> ---
>  fs/coredump.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
>=20
> diff --git a/fs/coredump.c b/fs/coredump.c
> index ea155ffee14c..5353b7ac67f2 100644
> --- a/fs/coredump.c
> +++ b/fs/coredump.c
> @@ -920,7 +920,10 @@ static struct page *dump_page_copy(struct page *src,=
 struct page *dst)
> =20
>  #define dump_page_alloc() ((struct page *)8) // Not NULL
>  #define dump_page_free(x) do { } while (0)
> -#define dump_page_copy(src, dst) ((dst), (src))
> +static struct page *dump_page_copy(struct page *src, struct page *dst)
> +{
> +        return NULL;
> +}
> =20
>  #endif

On second thoughts I made it return "src" instead of "NULL";

--=20
Cheers,
Stephen Rothwell

--Sig_/Z7LM7vHarhCNmirND9+5NCJ
Content-Type: application/pgp-signature
Content-Description: OpenPGP digital signature

-----BEGIN PGP SIGNATURE-----

iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmXn9/YACgkQAVBC80lX
0Gx/6gf+O7V6/wSdScZBIivSYD+Tzu6hgfZJ9BVhcjZLOkVFXsaw5y/uIeeVijLR
Ow0i2z1j/adrryXeTPXTqiqqqBIW0jPKY7DV9NBdpdpWCoQ29hG9+smsjGVRwqdh
r4qQoCxm4XTgvBfJDkgIJh8vDA+FBwZ1B7m4THLli4wuy4QKzqGpHMijtIynmqpe
KRDivVglIyZqhGDV2ev3DxKHUonDBdOulKYCELE9gdsclTj0nwAt9agE5evnm/ds
7sLabpyiuk/IYDcnGPQLca8uDMl9qymac65HtSmSC3Y5jMhnRbK4dEqfS2sr822S
q4dOfWlhsjaJ69VfR0BcqwFPIg4Axg==
=54Ps
-----END PGP SIGNATURE-----

--Sig_/Z7LM7vHarhCNmirND9+5NCJ--