Received-SPF: pass (google.com: domain of linux-kernel+bounces-93337-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <839a74c1-6e08-441b-a6e3-9923dfc3f303@amd.com>
Date: Wed, 6 Mar 2024 10:39:59 +0530
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 0/4] platform/x86/amd/pmf: Fix policy binary handling
Content-Language: en-US
To: Armin Wolf <W_Armin@gmx.de>
Cc: hdegoede@redhat.com, ilpo.jarvinen@linux.intel.com,
 platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20240304205005.10078-1-W_Armin@gmx.de>
From: Shyam Sundar S K <Shyam-sundar.S-k@amd.com>
In-Reply-To: <20240304205005.10078-1-W_Armin@gmx.de>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?RVNNcnVseWQxbUhvVyt4QTRzZ2JhN3Arc2NvWVFmTENLalphQWlBTjBzc1ZV?=
 =?utf-8?B?V3dBQ01ZM2ZjK1VEUEw0TkdEZUEvdDljeTluaURySThjcEtxZHlNSVk0V21v?=
 =?utf-8?B?SDNMSWdTUE5sL2ZURHlpNHVCMHRTcTQvcFBqMmtvaklDYktudHQ1K1UrNGhN?=
 =?utf-8?B?KzI5d29SVGZISlppUGl0WmFSaDl2WWxWZlhDRGpBL0xvdzlrZnB5cWdhdGs4?=
 =?utf-8?B?UmVTUVdxSTkxRW1FZVlXY1pKYm1EdFEwVVY4amt1MnZxbU90VVM3eEY4cS9P?=
 =?utf-8?B?eDNaeVNVZVRRaUQrWmhvT0MrbVIwMFlPWStIT2xpN04xcmNHRmxROVBBbFlE?=
 =?utf-8?B?MTQ2UEhtcC9wcEdNb1Z2SFVzdEwwNXJTUUZsWVAxVUtIMGNoUGlzSEZPOXF3?=
 =?utf-8?B?aXppa3hSaHFDeURONnhRVUtIYldoTHUvOTNPeUxjUFhFMVVDTXNtbjJ1UERY?=
 =?utf-8?B?NlFMcG1GREZqYWQrZmp5UlNIbGVKVmNaUDlqR2doSWJxZXNoM2VoUnl0SjB5?=
 =?utf-8?B?b0ZQYWRVMlVLSFZlVVFXT1lpZ2hGaktDOWxlc0RNZDQ0SUpsaFhPaXcwY0VT?=
 =?utf-8?B?TjlkOHFqNjl0Qm9xNzhTL3Q2VDZrYm5IY0lJbkNCNUk0RUZnQmw0SHhvV3ZP?=
 =?utf-8?B?U1RvZ3lHbnhPWXF3UW01VGdRNWlhUG9iUGRwbXA2S3puekkyaTRUS0pxclNT?=
 =?utf-8?B?cElKa09rejY4OTBTaDNXSFlLRi80dTJjVkNGS2VKU2VNM3dJV2M4aGNqZDFK?=
 =?utf-8?B?VTBJaUlkN2RUWXoweHpLVWFrQWRydmZaQWR4NTFvVTJJazNMMlJyRk1DTzNl?=
 =?utf-8?B?RmV3UVh4bUtvVzRPU0VFanZrS1ZQcXZUalN5OWIreXZwS3pYamZhRS96dTY5?=
 =?utf-8?B?YVZMRkt5eDBnd1RuYVF0YTJJSUFZM2ZjUDQ2NVpZaTRMelAzSVIvY0pqWTNH?=
 =?utf-8?B?cGJOQmI0a3JKbnlPeHlYL2QvSDFaQXVIdlNkR2FTaUJJNDRnMVJ5OXNlQURj?=
 =?utf-8?B?MWFJZXRtL0w2Y2pmclBrVU5sNTB1SkdHdkFFbTlIUXY0MUpCVC83dlhUdEE0?=
 =?utf-8?B?NWhiUS9lREYxWmRWeGFnZDRPYTRBbEg1cmo0a2s2NHRkdzlsa1pkRC9WVDIr?=
 =?utf-8?B?MVc0R25rUUZyWmVPUWN6U2RlMFFoSG1DazhLRUJ2YmV1Ni9Ia1hPdnIzL3N4?=
 =?utf-8?B?bFV0NWw0eFVwaTZQWWNVT3BVS0c1NnRwOXZ1U0Y4NjJQazBoK05MS0lZbU1U?=
 =?utf-8?B?ZzhPWXhwS0tFeUhYdi8rSW5IemxaMEVsenJoT0hUQThpM2RTcFJpa3NBODh4?=
 =?utf-8?B?OHBVdUR6ZFg5ejUzckU2UTBNa1hSM0ViK2wyQ2g1UHByLzVFd01COHcwbnBi?=
 =?utf-8?B?cGZxUUtXSFdITzBkNWYxN2lDWmhYMUZMbm9xbStENnhrNjZIWGFRa0hsek8w?=
 =?utf-8?B?djVub1NzWDc3QnRZVWl5T2NWNU5CMzZIeWxNeERZN0JhTCs3eElQMGFkNGdp?=
 =?utf-8?B?REJ3ZzRqNWt3aWk3ZFdPUWVSbW5ueGx0YzJKL1locnBxWStmR2F3enNPam1Z?=
 =?utf-8?B?aDdvUVFNSmFVNTIyb21wS0VXbjhhdXJaTW5WN296TCtqbXRlOHVzREYxS3Bt?=
 =?utf-8?B?QUJscHVaOTBWdHRlRlc5SkI2bHhob0VWU2dWQkM4TDVNMkRoaEFZamZpK0pB?=
 =?utf-8?B?bDlrZXAzYlZIUGIwMFFXSmpHZ2NoWjFNWHJHQ3oxTzI4S1V4MUk4blZJU2dS?=
 =?utf-8?B?Yk5BcW54M1VlalgwYUZkelVXL29XNjNTWHFKSlhQMit4cDJPOEZla1JJM3lr?=
 =?utf-8?B?TTF1VGNmNnQxKzA0UmpzUkNxTXhSYi9JRXo0YkxuZnJybDVkQWwxSTBxMFpl?=
 =?utf-8?B?M0ljK2tXKzNQTCtZb0FET2VQOWlzdnExWnFWM1VSdVRrMERuL3JNVUJsOFg2?=
 =?utf-8?B?Qit3Si9jamtiVmR0eFpmb1o3VlNsV3FzeXh6eHBmaWlnTllLd3BDKzlpNFFu?=
 =?utf-8?B?bjVwN0N6T0cxWk4yMm5RcDF4d003azZqYnJCbzd2d2ppekJUWnpvWU9RMDky?=
 =?utf-8?B?aDJISXYzVU9KVWtpdEJGa3VoSVdSc2VmYVVHL2ZMWVdORHI4QS90SVlMeXdR?=
 =?utf-8?Q?uQ7tsRiFvGu/XG5lnkBkAAajA?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 40f5072c-0e7c-4097-612d-08dc3d9bafc8
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5176.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Mar 2024 05:10:06.1110
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: EJz37g7jqjOJzsVLasQQ0yt35MNzh44P848YQ5/8IhZfadvDSIJNitOEghqAiI2KeAJ3qkzkVm7fJ0iZ8PMKkQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM6PR12MB4091


On 3/5/2024 02:20, Armin Wolf wrote:
> This patch series fixes various issues inside the policy binary
> handling code.
> The first patch makes sure that a valid error code is returned upon
> failing to start the policy engine, while the second patch drops the
> usage of readl() on non-io memory.
> The last two patches fix a possible out-of-bounds memory access when
> parsing the policy binary header.
> 
> All patches are compile-tested only.
> 
> Changes since v2:
> - add patches 1 and 3
> 
> Changes since v1:
> - get the full dword instead of only 8 bits when reading the header
> - check if the policy buffer also has enough room for storing the length

Thank you Armin. Series looks good to me.

Reviewed-by: Shyam Sundar S K Shyam-sundar.S-k@amd.com

> 
> Armin Wolf (4):
>   platform/x86/amd/pmf: Fix return value of
>     amd_pmf_start_policy_engine()
>   platform/x86/amd/pmf: Do not use readl() for policy buffer access
>   platform/x86/amd/pmf: Use struct for cookie header
>   platform/x86/amd/pmf: Fix possible out-of-bound memory accesses
> 
>  drivers/platform/x86/amd/pmf/pmf.h    |  6 +++++-
>  drivers/platform/x86/amd/pmf/tee-if.c | 21 +++++++++++++--------
>  2 files changed, 18 insertions(+), 9 deletions(-)
> 
> --
> 2.39.2
>