Received-SPF: pass (google.com: domain of linux-kernel+bounces-93347-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Precedence: bulk
MIME-Version: 1.0
References: <20240228093013.8263-1-linyunsheng@huawei.com> <20240228093013.8263-6-linyunsheng@huawei.com>
 <65c3503409c0e1670bdf06fecfd58ec483a114b9.camel@redhat.com>
In-Reply-To: <65c3503409c0e1670bdf06fecfd58ec483a114b9.camel@redhat.com>
From: Jason Wang <jasowang@redhat.com>
Date: Wed, 6 Mar 2024 13:28:16 +0800
Message-ID: <CACGkMEts-S7=p8aY+p+1JcTGZdLO65ug6t7c_yNj8xwRrhg9tA@mail.gmail.com>
Subject: Re: [PATCH net-next v6 5/5] tools: virtio: introduce vhost_net_test
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, 
	"Michael S. Tsirkin" <mst@redhat.com>, Xuan Zhuo <xuanzhuo@linux.alibaba.com>, 
	virtualization@lists.linux.dev, Yunsheng Lin <linyunsheng@huawei.com>, 
	davem@davemloft.net, kuba@kernel.org
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Mar 5, 2024 at 5:47=E2=80=AFPM Paolo Abeni <pabeni@redhat.com> wrot=
e:
>
> On Wed, 2024-02-28 at 17:30 +0800, Yunsheng Lin wrote:
> > introduce vhost_net_test for both vhost_net tx and rx basing
> > on virtio_test to test vhost_net changing in the kernel.
> >
> > Steps for vhost_net tx testing:
> > 1. Prepare a out buf.
> > 2. Kick the vhost_net to do tx processing.
> > 3. Do the receiving in the tun side.
> > 4. verify the data received by tun is correct.
> >
> > Steps for vhost_net rx testing:
> > 1. Prepare a in buf.
> > 2. Do the sending in the tun side.
> > 3. Kick the vhost_net to do rx processing.
> > 4. verify the data received by vhost_net is correct.
> >
> > Signed-off-by: Yunsheng Lin <linyunsheng@huawei.com>
>
> @Jason: AFAICS this addresses the points you raised on v5, could you
> please have a look?
>
> Thanks!

Looks good to me.

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks

>
> Paolo
>
>