Received-SPF: pass (google.com: domain of linux-kernel+bounces-93389-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <160fdf7f-553a-40ed-8493-95a7d31a8b38@gmail.com>
Date: Wed, 6 Mar 2024 13:39:54 +0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
Content-Language: en-US
To: "Bolan Wang(Bolan)" <bolan.wang@fibocom.com>,
 "johan@kernel.org" <johan@kernel.org>,
 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <KL1PR02MB6283EBD2786A3B3E4E373F0389212@KL1PR02MB6283.apcprd02.prod.outlook.com>
From: Lars Melin <larsm17@gmail.com>
In-Reply-To: <KL1PR02MB6283EBD2786A3B3E4E373F0389212@KL1PR02MB6283.apcprd02.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-03-06 13:18, Bolan Wang(Bolan) wrote:
>> If the device with pid 0x01a1 only has an mbim interface as you have indicated then why do you add it to the option serial driver?
> 
> Hi Lars:
>    The pid 0x01a1 may include at, diag ports in different usb modes. Currently, only has the mbim interface.
> 
> thanks
> bolan

Hi Bolan,
so you already know that other versions of the card will have the pid 
0x01a1 and the serial interfaces will be of class ff but you don't
know what those interfaces will be used for?
You shall only add driver support for what you know today and not for 
something that might or might not be implemented in the future.

For the device with pid 0x0115 you have listed an adb interface and adb 
interfaces should not be in the option driver.

thanks
Lars