Received-SPF: pass (google.com: domain of linux-kernel+bounces-93452-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240304-gpio-keys-v4-1-03604d778c86@quicinc.com>
 <f09dc3a4-ed5e-40b7-ae71-7c6cfd79da1b@linaro.org> <02a2e93b-f0f1-4506-9e17-444cfd1a208f@quicinc.com>
In-Reply-To: <02a2e93b-f0f1-4506-9e17-444cfd1a208f@quicinc.com>
From: Dmitry Baryshkov <dmitry.baryshkov@linaro.org>
Date: Wed, 6 Mar 2024 09:56:04 +0200
Message-ID: <CAA8EJpq64dwEi3NrEnvqnFR5YTSDitx9sgZVheho+UL0rz0FsQ@mail.gmail.com>
Subject: Re: [PATCH v4] arm64: dts: qcom: qcm6490-idp: enable PMIC Volume and
 Power buttons
To: hui liu <quic_huliu@quicinc.com>
Cc: Konrad Dybcio <konrad.dybcio@linaro.org>, Bjorn Andersson <andersson@kernel.org>, 
	Rob Herring <robh@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, 
	Conor Dooley <conor+dt@kernel.org>, linux-arm-msm@vger.kernel.org, 
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 6 Mar 2024 at 05:02, hui liu <quic_huliu@quicinc.com> wrote:
>
>
>
> On 3/6/2024 5:20 AM, Konrad Dybcio wrote:
> >
> >
> > On 3/4/24 08:09, Hui Liu via B4 Relay wrote:
> >> From: Hui Liu <quic_huliu@quicinc.com>
> >>
> >> The Volume Down & Power buttons are controlled by the PMIC via
> >> the PON hardware, and the Volume Up is connected to a PMIC gpio.
> >>
> >> Enable the necessary hardware and setup the GPIO state for the
> >> Volume Up gpio key.
> >>
> >> Signed-off-by: Hui Liu <quic_huliu@quicinc.com>
> >> ---
> >
> > [...]
> >
> >
> >> +&pmk8350_pon {
> >> +    status = "okay";
> >> +};
> >
> > This device is already enabled
> Hi Konrad,
>
> The status is not set in pmk8350.dtsi, so I thought we should set it for
> "okay" manually. Do you think so?

What is the default device status if there is no status property?


-- 
With best wishes
Dmitry