Received-SPF: pass (google.com: domain of linux-kernel+bounces-93463-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Date: Wed, 6 Mar 2024 09:07:39 +0100
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: KR Kim <kr.kim@skyhighmemory.com>
Cc: richard@nod.at, vigneshr@ti.com, mmkurbanov@salutedevices.com,
 ddrokosov@sberdevices.ru, gch981213@gmail.com,
 linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
 moh.sardi@skyhighmemory.com, changsub.shim@skyhighmemory.com
Subject: Re: [PATCH 2/2] SPI Nand Patch code for SkyHigh Momory
Message-ID: <20240306090739.31911391@xps-13>
In-Reply-To: <20240306041532.16985-1-kr.kim@skyhighmemory.com>
References: <20240306041532.16985-1-kr.kim@skyhighmemory.com>
Organization: Bootlin
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable

Hello,

The subject tag is wrong (v2), the prefix is wrong, you are missing
the commit message, there is no Signed-off-by, and you sent a diff with
your v1 rather than a full patch.

You should probably try sending these using --dry-run and
--suppress-cc=3Dall while you are working on your series :)

Thanks,
Miqu=C3=A8l

kr.kim@skyhighmemory.com wrote on Wed,  6 Mar 2024 13:15:32 +0900:

> ---
>  drivers/mtd/nand/spi/Makefile  |  2 +-
>  drivers/mtd/nand/spi/skyhigh.c | 57 ++++++----------------------------
>  2 files changed, 11 insertions(+), 48 deletions(-)
>=20
> diff --git a/drivers/mtd/nand/spi/Makefile b/drivers/mtd/nand/spi/Makefile
> index 48b429d90460..1e61ab21893a 100755
> --- a/drivers/mtd/nand/spi/Makefile
> +++ b/drivers/mtd/nand/spi/Makefile
> @@ -1,4 +1,4 @@
>  # SPDX-License-Identifier: GPL-2.0
>  spinand-objs :=3D core.o alliancememory.o ato.o esmt.o foresee.o gigadev=
ice.o macronix.o
> -spinand-objs +=3D micron.o paragon.o toshiba.o winbond.o xtx.o skyhigh.o
> +spinand-objs +=3D micron.o paragon.o skyhigh.o toshiba.o winbond.o xtx.o
>  obj-$(CONFIG_MTD_SPI_NAND) +=3D spinand.o
> diff --git a/drivers/mtd/nand/spi/skyhigh.c b/drivers/mtd/nand/spi/skyhig=
h.c
> index 71de4fa34406..dd348849216d 100644
> --- a/drivers/mtd/nand/spi/skyhigh.c
> +++ b/drivers/mtd/nand/spi/skyhigh.c
> @@ -12,8 +12,8 @@
>  #define SPINAND_MFR_SKYHIGH		0x01
> =20
>  #define SKYHIGH_STATUS_ECC_1TO2_BITFLIPS	(1 << 4)
> -#define SKYHIGH_STATUS_ECC_3TO4_BITFLIPS	(2 << 4)
> -#define SKYHIGH_STATUS_ECC_5TO6_BITFLIPS	(3 << 4)
> +#define SKYHIGH_STATUS_ECC_3TO6_BITFLIPS	(2 << 4)
> +#define SKYHIGH_STATUS_ECC_UNCOR_ERROR  	(3 << 4)
> =20
>  #define SKYHIGH_CONFIG_PROTECT_EN	BIT(1)
> =20
> @@ -62,49 +62,15 @@ static const struct mtd_ooblayout_ops skyhigh_spinand=
_ooblayout =3D {
>  	.free =3D skyhigh_spinand_ooblayout_free,
>  };
> =20
> -#if 0
> -bool skyhigh_spinand_isbad(struct spinand_device *spinand,
> -			   const struct nand_pos *pos)
> -{
> -	u8 marker;
> -	struct nand_page_io_req req =3D {
> -		.pos =3D *pos,
> -		.ooblen =3D 1,
> -		.ooboffs =3D 0,
> -		.oobbuf.in =3D &marker,
> -		.mode =3D MTD_OPS_RAW,
> -	};
> -
> -	req.pos.page =3D 0;
> -	spinand_read_page(spinand, &req);
> -	if (marker !=3D 0xff)
> -		return true;
> -
> -#if 0
> -	req.pos.page =3D 1;
> -	spinand_read_page(spinand, &req);
> -	if (marker !=3D 0xff)
> -		return true;
> -
> -	req.pos.page =3D 63;
> -	spinand_read_page(spinand, &req);
> -	if (marker !=3D 0xff)
> -		return true;
> -#endif
> -
> -	return false;
> -}
> -#endif
> -
>  static int skyhigh_spinand_ecc_get_status(struct spinand_device *spinand,
>  				  u8 status)
>  {
>  	/* SHM
> -	00 : No bit-flip
> -	01 : 1-2 errors corrected
> -	10 : 3-6 errors corrected        =20
> -	11 : uncorrectable
> -	*/
> +	 * 00 : No bit-flip
> +	 * 01 : 1-2 errors corrected
> +	 * 10 : 3-6 errors corrected        =20
> +	 * 11 : uncorrectable
> +	 */
> =20
>  	switch (status & STATUS_ECC_MASK) {
>  	case STATUS_ECC_NO_BITFLIPS:
> @@ -113,12 +79,10 @@ static int skyhigh_spinand_ecc_get_status(struct spi=
nand_device *spinand,
>  	case SKYHIGH_STATUS_ECC_1TO2_BITFLIPS:
>  		return 2;
> =20
> -	/* change from 4 to 6 */
> -	case SKYHIGH_STATUS_ECC_3TO4_BITFLIPS:
> + 	case SKYHIGH_STATUS_ECC_3TO6_BITFLIPS:
>  		return 6;=20
> =20
> -	/* uncorrectable for '11' */
> -	case SKYHIGH_STATUS_ECC_5TO6_BITFLIPS:
> + 	case SKYHIGH_STATUS_ECC_UNCOR_ERROR:
>  		return -EBADMSG;;
> =20
>  	default:
> @@ -179,8 +143,7 @@ static int skyhigh_spinand_init(struct spinand_device=
 *spinand)
> =20
>  static const struct spinand_manufacturer_ops skyhigh_spinand_manuf_ops =
=3D {
>  	.init =3D skyhigh_spinand_init,
> -/*	.isbad =3D skyhigh_spinand_isbad,*/
> -};
> + };
> =20
>  const struct spinand_manufacturer skyhigh_spinand_manufacturer =3D {
>  	.id =3D SPINAND_MFR_SKYHIGH,