Received-SPF: pass (google.com: domain of linux-kernel+bounces-93501-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <f93317e4-1848-4fa0-85b7-c9a0d303d0fc@gmail.com>
Date: Wed, 6 Mar 2024 15:29:53 +0700
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] USB: serial: option: add Fibocom FM135-GL variants
Content-Language: en-US
To: "Bolan Wang(Bolan)" <bolan.wang@fibocom.com>,
 "johan@kernel.org" <johan@kernel.org>,
 "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
Cc: "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
 "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
References: <KL1PR02MB6283F5203E50CD87F344331689212@KL1PR02MB6283.apcprd02.prod.outlook.com>
From: Lars Melin <larsm17@gmail.com>
In-Reply-To: <KL1PR02MB6283F5203E50CD87F344331689212@KL1PR02MB6283.apcprd02.prod.outlook.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit

On 2024-03-06 14:41, Bolan Wang(Bolan) wrote:
>> Hi Bolan,
>> so you already know that other versions of the card will have the pid
>> 0x01a1 and the serial interfaces will be of class ff but you don't know what those interfaces will be used for?
>> You shall only add driver support for what you know today and not for something that might or might not be implemented in the future.
> 
>> For the device with pid 0x0115 you have listed an adb interface and adb interfaces should not be in the option driver.
> 
> Hi Lars:
> 
> Ok, I will remove 0x01a1 from option serial driver. And the adb listed in pid 0x0115 will also be removed.
> Actually adb interface info with pid 0x0115 is: Class_ff&SubClass_42&Prot_01, the option driver will not bind it?
> I will resubmit a new patch, please help review and abandon this.
> 
> thanks
> bolan
> 
> 

The option driver will bind because you have matched only on Class ff 
"{ USB_DEVICE_INTERFACE_CLASS(0x2cb7, 0x01a1, 0xff) }"
There are other macros that you could possibly use but I can't tell you 
which since you have not shown an usb-device listing for the device.
You can also blacklist an interface (RSV). The option driver source is 
full of examples of macro use and combinations.

thanks
Lars