Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755675AbYAEQjH (ORCPT ); Sat, 5 Jan 2008 11:39:07 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755946AbYAEQin (ORCPT ); Sat, 5 Jan 2008 11:38:43 -0500 Received: from ns.gsystems.sk ([62.176.172.50]:38280 "EHLO 192.168.0.33" rhost-flags-OK-OK-FAIL-FAIL) by vger.kernel.org with ESMTP id S1755847AbYAEQil (ORCPT ); Sat, 5 Jan 2008 11:38:41 -0500 X-Greylist: delayed 3023 seconds by postgrey-1.27 at vger.kernel.org; Sat, 05 Jan 2008 11:38:41 EST From: Ondrej Zary To: jgarzik@pobox.com Subject: [PATCH] libata and starting/stopping ATAPI floppy devices Date: Sat, 5 Jan 2008 16:47:57 +0100 User-Agent: KMail/1.9.7 Cc: linux-ide@vger.kernel.org, Linux Kernel MIME-Version: 1.0 Content-Disposition: inline X-Length: 1564 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Message-Id: <200801051647.58866.linux@rainbow-software.org> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1462 Lines: 42 Hello, I switched to libata drivers for my onboard PATA controller (PIIX4) recently. Everything works fine except that kernel tries to start not only my hard drive (sda) but also LS-120 floppy drive (sdb) which does not like it: sd 0:0:0:0: [sda] Starting disk ata1.00: configured for UDMA/33 sd 0:0:0:0: [sda] 58633344 512-byte hardware sectors (30020 MB) sd 0:0:0:0: [sda] Write Protect is off sd 0:0:0:0: [sda] Write cache: enabled, read cache: enabled, doesn't support DPO or FUA sd 1:0:1:0: [sdb] Starting disk ata2.00: configured for UDMA/33 ata2.01: configured for PIO2 sd 1:0:1:0: [sdb] Result: hostbyte=0x00 driverbyte=0x08 sd 1:0:1:0: [sdb] Sense Key : 0x2 [current] sd 1:0:1:0: [sdb] ASC=0x3a ASCQ=0x0 The question is: is it correct? Or a patch like this should be applied? --- linux-2.6.23-orig/drivers/ata/libata-scsi.c 2007-10-09 22:31:38.000000000 +0200 +++ linux-2.6.23-pentium/drivers/ata/libata-scsi.c 2008-01-05 15:50:16.000000000 +0100 @@ -802,7 +802,8 @@ blk_queue_max_phys_segments(sdev->request_queue, LIBATA_MAX_PRD); - sdev->manage_start_stop = 1; + if (dev->class == ATA_DEV_ATA) + sdev->manage_start_stop = 1; if (dev) ata_scsi_dev_config(sdev, dev); -- Ondrej Zary -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/