Received-SPF: pass (google.com: domain of linux-kernel+bounces-93485-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Wed, 6 Mar 2024 09:18:04 +0100
From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= <u.kleine-koenig@pengutronix.de>
To: Linux regressions mailing list <regressions@lists.linux.dev>
Cc: Lee Jones <lee@kernel.org>, linux-leds@vger.kernel.org, 
	linux-pwm@vger.kernel.org, LKML <linux-kernel@vger.kernel.org>
Subject: Re: [regression] stm32mp1xx based targets stopped entering suspend
 if pwm-leds exist
Message-ID: <2vbwacjy25z5vekylle3ehwi3be4urm6bssrbg6bxobtdlekt4@mazicwtgf4qb>
References: <5da6cf8a-4250-42f6-8b39-13bff7fcdd9c@leemhuis.info>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
	protocol="application/pgp-signature"; boundary="iyqdb55itbghrjyl"
Content-Disposition: inline
In-Reply-To: <5da6cf8a-4250-42f6-8b39-13bff7fcdd9c@leemhuis.info>


--iyqdb55itbghrjyl
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hello,

On Wed, Mar 06, 2024 at 08:05:15AM +0100, Linux regression tracking (Thorst=
en Leemhuis) wrote:
> Hi, Thorsten here, the Linux kernel's regression tracker.
>=20
> Uwe, I noticed a report about a regression in bugzilla.kernel.org that
> apparently is caused by a change of yours. As many (most?) kernel
> developers don't keep an eye on it, I decided to forward it by mail.
>=20
> Note, you have to use bugzilla to reach the reporter, as I sadly[1] can
> not CCed them in mails like this.
>=20
> Quoting from https://bugzilla.kernel.org/show_bug.cgi?id=3D218559 :
>=20
> > Commit 76fe464c8e64e71b2e4af11edeef0e5d85eeb6aa ("leds: pwm: Don't
> > disable the PWM when the LED should be off") prevents stm32mp1xx based
> > targets from entering suspend if pwm-leds exist, as the stm32 PWM driver
> > refuses to enter suspend if any PWM channels are still active ("PWM 0
> > still in use by consumer" see stm32_pwm_suspend in drivers/pwm/stm32-pw=
m.c).
> >=20
> > Reverting the mentioned commit fixes this behaviour but I'm not
> > certain if this is a problem with stm32-pwm or pwm-leds (what is the
> > usual behaviour for suspend with active PWM channels?).

I'd assume the following patch fixes this report. I didn't test it
though.

Best regards
Uwe

---->8----
=46rom: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
Subject: [PATCH] leds: pwm: Disable PWM when going to suspend

On stm32mp1xx based machines (and others) a PWM consumer has to disable
the PWM because an enabled PWM refuses to suspend. So check the
LED_SUSPENDED flag and depending on that set the .enabled property.

Link: https://bugzilla.kernel.org/show_bug.cgi?id=3D218559
Fixes: 76fe464c8e64 ("leds: pwm: Don't disable the PWM when the LED should =
be off")
Signed-off-by: Uwe Kleine-K=F6nig <u.kleine-koenig@pengutronix.de>
---
 drivers/leds/leds-pwm.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/drivers/leds/leds-pwm.c b/drivers/leds/leds-pwm.c
index 4e3936a39d0e..e1b414b40353 100644
--- a/drivers/leds/leds-pwm.c
+++ b/drivers/leds/leds-pwm.c
@@ -53,7 +53,13 @@ static int led_pwm_set(struct led_classdev *led_cdev,
 		duty =3D led_dat->pwmstate.period - duty;
=20
 	led_dat->pwmstate.duty_cycle =3D duty;
-	led_dat->pwmstate.enabled =3D true;
+	/*
+	 * Disabling a PWM doesn't guarantee that it emits the inactive level.
+	 * So keep it on. Only for suspending the PWM should be disabled because
+	 * otherwise it refuses to suspend. The possible downside is that the
+	 * LED might stay (or even go) on.
+	 */
+	led_dat->pwmstate.enabled =3D !(led_cdev->flags & LED_SUSPENDED);
 	return pwm_apply_might_sleep(led_dat->pwm, &led_dat->pwmstate);
 }

base-commit: 15facbd7bd3dbfa04721cb71e69954eb4686cb9e
---->8----

--=20
Pengutronix e.K.                           | Uwe Kleine-K=F6nig            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

--iyqdb55itbghrjyl
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmXoJrsACgkQj4D7WH0S
/k4dpAf/S1rWn4jV3PACJnwgcKd7Slhc18YY7FMyqrmXXVScL6Geh1ua+HD/rMiE
dAfgvBPgnpuggzm3K8AkyzNmY3ZRIf1poCPiGUhcG1+G1WxqBaqWsY+dnsbh1pFD
eoBKrZW1ssk7n1njzCZGspmI2samHJFHyUR6LVzhqsJZpKlW1fgknJQ4OhoSvDHf
iE3W6I1r9g7960HEFP7q9BrRLFymEo49Qpi+bnpLqGApZx8IA25aA0GTzyvRUBGk
yPd6mTo6heCLL6kbsK2juH5sigLJGEDLUXVYWQA0y15zNb8xgnlMJy+bE5B2vv1b
fHWuQd1kDchYrNeMiAGHytbXM/jQ5g==
=Aflk
-----END PGP SIGNATURE-----

--iyqdb55itbghrjyl--